Bugzilla – Attachment 188575 Details for
Bug 41006
Shelving location style changed in many places since Bug 40606
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 41006: Update shelving location style in some contexts
Bug-41006-Update-shelving-location-style-in-some-c.patch (text/plain), 4.58 KB, created by
Owen Leonard
on 2025-10-29 16:32:40 UTC
(
hide
)
Description:
Bug 41006: Update shelving location style in some contexts
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2025-10-29 16:32:40 UTC
Size:
4.58 KB
patch
obsolete
>From 7d235674ed4a0d7badd037c29b02346cf4455218 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Tue, 28 Oct 2025 17:34:50 +0000 >Subject: [PATCH] Bug 41006: Update shelving location style in some contexts > >Bug 40606 removed the italic style from the .shelvingloc class because >the information was moved into its own column on the bibliographic >detail holdings table. This doesn't work for several locations in Koha >where the shelving location is not displayed separately from the call >number. > >This patch adds some specificity to the .shelvingloc class so that it is >italic unless it is the direct descendant of a table cell. >Everywhere else it should be in italics. > >The patch also makes corrections to the checkin and transfer pages so >that shelving location is correctly displayed. > >To test, apply the patch and rebuild the staff interface CSS. > >- Check each instance of the .shelvingloc class. > - Places where the information appears in a table without italics: > - Acquisitions -> Vendor -> Receive order -> Receive a new shipment > -> Receive > - Circuation -> Transfers > - Circulation -> Check in > - Reports -> Most-circulated items > - Bibligraphic detail holdings table > - Cataloging -> Inventory > > - Places where the information should appear in italics: > - Cart > - Catalog search results > - Tools -> Tags -> Click a tag to see tagged records > - Lists -> List contents > >Sponsored-by: Athens County Public Libraries >--- > koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss | 5 +++++ > .../intranet-tmpl/prog/en/modules/circ/branchtransfers.tt | 4 +++- > koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt | 2 +- > 3 files changed, 9 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss >index f8c9cefcd75..545deeb753a 100644 >--- a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss >+++ b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss >@@ -1855,6 +1855,11 @@ i { > // style for shelving location in catalogsearch > .shelvingloc { > display: block; >+ font-style: italic; >+} >+ >+td > .shelvingloc { >+ font-style: normal; > } > > // style for bundled detail in catalogsearch >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchtransfers.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchtransfers.tt >index 56dd9901695..e545de2834a 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchtransfers.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchtransfers.tt >@@ -273,7 +273,9 @@ > >[% trsfitemloo.item.barcode | html %]</a > ></td > > >- <td class="tf-location"><span class="shelvingloc">[% AuthorisedValues.GetDescriptionByKohaField( kohafield => 'items.location', authorised_value => trsfitemloo.item.location ) | html %]</span></td> >+ <td class="tf-location"> >+ <span class="shelvingloc">[% AuthorisedValues.GetDescriptionByKohaField( kohafield => 'items.location', authorised_value => trsfitemloo.item.location ) | html %]</span> >+ </td> > <td class="tf-itemcallnumber">[% trsfitemloo.item.itemcallnumber | html %]</td> > <td class="tf-itemtype">[% ItemTypes.GetDescription( trsfitemloo.item.effective_itemtype ) | html %]</td> > <td class="tf-ccode">[% AuthorisedValues.GetDescriptionByKohaField( kohafield => 'items.ccode', authorised_value => trsfitemloo.item.ccode ) | html %]</td> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >index eb71cb8dbc7..c15b168d83a 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >@@ -1383,7 +1383,7 @@ > [%- END -%] > </td> > <td class="ci-shelvinglocation"> >- <span class="shelvingloc">[% checkin.item_location | html %]</span> >+ <span class="shelvingloc"> [% AuthorisedValues.GetDescriptionByKohaField( kohafield => 'items.location', authorised_value => checkin.item.location ) | html %] </span> > </td> > <td class="ci-callnumber"> [% checkin.item.itemcallnumber | html %] </td> > <td class="ci-dateaccessioned"> [% checkin.item.dateaccessioned | $KohaDates %] </td> >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 41006
: 188575