Bug 41006 - Shelving location style changed in many places since Bug 40606
Summary: Shelving location style changed in many places since Bug 40606
Status: BLOCKED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Owen Leonard
QA Contact: Laura Escamilla
URL:
Keywords:
Depends on: 40606 41126
Blocks:
  Show dependency treegraph
 
Reported: 2025-10-14 07:11 UTC by Fridolin Somers
Modified: 2025-12-29 16:37 UTC (History)
3 users (show)

See Also:
GIT URL:
Initiative type: ---
Sponsorship status: ---
Comma delimited list of Sponsors:
Crowdfunding goal: 0
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes the style for values shown for the shelving location in the staff interface - it is in italics where it is shown along with the call number, unless it is in a column by itself (for example, the shelving location column in the holdings table). Bug 40606 (Koha 25.11) removed the italic style from the .shelvingloc class because the information was moved into its own column on the bibliographic detail holdings table. This doesn't work for several locations in Koha where the shelving location is not displayed separately from the call number. Places where the information should appear in italics: * Cart * Catalog search results * Tools > Tags > Click a tag to see tagged records * Lists > List contents Everywhere else, where it is in its own shelving location column, it is shown without italics.
Version(s) released in:
Circulation function:


Attachments
Bug 41006: Update shelving location style in some contexts (4.58 KB, patch)
2025-10-29 16:32 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 41006: Update shelving location style in some contexts (4.62 KB, patch)
2025-12-13 03:08 UTC, David Nind
Details | Diff | Splinter Review
Bug 41006: Update shelving location style in some contexts (4.69 KB, patch)
2025-12-22 14:02 UTC, Laura Escamilla
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Fridolin Somers 2025-10-14 07:11:06 UTC
Shelving location style changed in many places since Bug 40606

See https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40606#c9
Comment 1 Owen Leonard 2025-10-29 16:32:40 UTC
Created attachment 188575 [details] [review]
Bug 41006: Update shelving location style in some contexts

Bug 40606 removed the italic style from the .shelvingloc class because
the information was moved into its own column on the bibliographic
detail holdings table. This doesn't work for several locations in Koha
where the shelving location is not displayed separately from the call
number.

This patch adds some specificity to the .shelvingloc class so that it is
italic unless it is the direct descendant of a table cell.
Everywhere else it should be in italics.

The patch also makes corrections to the checkin and transfer pages so
that shelving location is correctly displayed.

To test, apply the patch and rebuild the staff interface CSS.

- Check each instance of the .shelvingloc class.
  - Places where the information appears in a table without italics:
    - Acquisitions -> Vendor -> Receive order -> Receive a new shipment
      -> Receive
    - Circuation -> Transfers
    - Circulation -> Check in
    - Reports -> Most-circulated items
    - Bibligraphic detail holdings table
    - Cataloging -> Inventory

  - Places where the information should appear in italics:
    - Cart
    - Catalog search results
    - Tools -> Tags -> Click a tag to see tagged records
    - Lists -> List contents

Sponsored-by: Athens County Public Libraries
Comment 2 David Nind 2025-12-13 03:08:08 UTC
Created attachment 190476 [details] [review]
Bug 41006: Update shelving location style in some contexts

Bug 40606 removed the italic style from the .shelvingloc class because
the information was moved into its own column on the bibliographic
detail holdings table. This doesn't work for several locations in Koha
where the shelving location is not displayed separately from the call
number.

This patch adds some specificity to the .shelvingloc class so that it is
italic unless it is the direct descendant of a table cell.
Everywhere else it should be in italics.

The patch also makes corrections to the checkin and transfer pages so
that shelving location is correctly displayed.

To test, apply the patch and rebuild the staff interface CSS.

- Check each instance of the .shelvingloc class.
  - Places where the information appears in a table without italics:
    - Acquisitions -> Vendor -> Receive order -> Receive a new shipment
      -> Receive
    - Circuation -> Transfers
    - Circulation -> Check in
    - Reports -> Most-circulated items
    - Bibligraphic detail holdings table
    - Cataloging -> Inventory

  - Places where the information should appear in italics:
    - Cart
    - Catalog search results
    - Tools -> Tags -> Click a tag to see tagged records
    - Lists -> List contents

Sponsored-by: Athens County Public Libraries
Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Laura Escamilla 2025-12-22 14:02:04 UTC
Created attachment 190669 [details] [review]
Bug 41006: Update shelving location style in some contexts

Bug 40606 removed the italic style from the .shelvingloc class because
the information was moved into its own column on the bibliographic
detail holdings table. This doesn't work for several locations in Koha
where the shelving location is not displayed separately from the call
number.

This patch adds some specificity to the .shelvingloc class so that it is
italic unless it is the direct descendant of a table cell.
Everywhere else it should be in italics.

The patch also makes corrections to the checkin and transfer pages so
that shelving location is correctly displayed.

To test, apply the patch and rebuild the staff interface CSS.

- Check each instance of the .shelvingloc class.
  - Places where the information appears in a table without italics:
    - Acquisitions -> Vendor -> Receive order -> Receive a new shipment
      -> Receive
    - Circuation -> Transfers
    - Circulation -> Check in
    - Reports -> Most-circulated items
    - Bibligraphic detail holdings table
    - Cataloging -> Inventory

  - Places where the information should appear in italics:
    - Cart
    - Catalog search results
    - Tools -> Tags -> Click a tag to see tagged records
    - Lists -> List contents

Sponsored-by: Athens County Public Libraries
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com>
Comment 4 Lucas Gass (lukeg) 2025-12-29 16:37:32 UTC
Setting this to BLOCKED until the dependency is resolved.