Bugzilla – Attachment 188828 Details for
Bug 40843
On modborrowers.pl patron attributes should sort by the description, not the code
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 40843: Sort patron attributes by description
Bug-40843-Sort-patron-attributes-by-description.patch (text/plain), 1.17 KB, created by
Brendan Lawlor
on 2025-10-31 17:45:15 UTC
(
hide
)
Description:
Bug 40843: Sort patron attributes by description
Filename:
MIME Type:
Creator:
Brendan Lawlor
Created:
2025-10-31 17:45:15 UTC
Size:
1.17 KB
patch
obsolete
>From 3d4da387189a8827e2f1a1a52edf9905ac5133d2 Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Fri, 19 Sep 2025 17:22:53 +0000 >Subject: [PATCH] Bug 40843: Sort patron attributes by description > >To test: > >1/ Have several borrower attributes set up so you can see how they sort >2/ Go to Tools > Batch patron modification >3/ Notice the "Patron attribute:: dropdown near the bottom >4/ It is sorted by the attribute code, not the description. >5/ APPLY PATCH and restart_all >6/ Try again, it should sort by the description > >Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> >--- > tools/modborrowers.pl | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/tools/modborrowers.pl b/tools/modborrowers.pl >index 46eb565f49..b09a41d343 100755 >--- a/tools/modborrowers.pl >+++ b/tools/modborrowers.pl >@@ -176,6 +176,7 @@ if ( $op eq 'cud-show' || $op eq 'show' ) { > category_lib => $category_lib, > type => $attr_type->authorised_value_category ? 'select' : 'text', > }; >+ @patron_attributes_codes = sort { $a->{attribute_lib} cmp $b->{attribute_lib} } @patron_attributes_codes; > } > > my @attributes_header = (); >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 40843
:
186626
|
186627
| 188828