Bugzilla – Attachment 189180 Details for
Bug 41201
Definite article in some labels confuses screen readers
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 41201: Removed definite article from hold and cart
Bug-41201-Removed-definite-article-from-hold-and-c.patch (text/plain), 7.14 KB, created by
Owen Leonard
on 2025-11-06 14:41:55 UTC
(
hide
)
Description:
Bug 41201: Removed definite article from hold and cart
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2025-11-06 14:41:55 UTC
Size:
7.14 KB
patch
obsolete
>From 25a2c74c30cad1117d375ece6fcd0b34deb2442f Mon Sep 17 00:00:00 2001 >From: Jake Deery <jake.deery@openfifth.co.uk> >Date: Thu, 2 Oct 2025 12:21:48 +0000 >Subject: [PATCH] Bug 41201: Removed definite article from hold and cart > >This patch removes the definite article from some labels, so that their >visual and hidden labels are in sync. > >== TO TEST == >a) (optionally) read the patch code to understand what locations have change >b) inspect the code on the results and details pages >c) note that some visual and hidden labels differ > *) specifically, the add to cart and place hold labels >== APPLY PATCH == >d) repeat step b) >e) notice now that the visual and hidden labels match >== SIGN OFF == > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >--- > .../intranet-tmpl/prog/en/modules/reserve/request.tt | 4 ++-- > .../bootstrap/en/includes/title-actions-menu.inc | 8 ++++---- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt | 6 +++--- > 3 files changed, 9 insertions(+), 9 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >index 14868aaff46..e75e33c44f0 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >@@ -27,7 +27,7 @@ > >[% FILTER collapse %] > [% UNLESS ( multi_hold ) %] > [% title_in_title = INCLUDE 'biblio-title-head.inc' %] >- [% tx("Place a hold on {title}", { title = title_in_title }) | html %] >+ [% tx("Place hold on {title}", { title = title_in_title }) | html %] > › > [% ELSE %] > [% t("Confirm holds") | html %] >@@ -286,7 +286,7 @@ > [% END %] > > [% UNLESS ( multi_hold ) %] >- <h2>Place a hold on [% INCLUDE 'biblio-title.inc' link = 1 %] [% IF biblio.author %]by [% biblio.author | html %][% END %]</h2> >+ <h2>Place hold on [% INCLUDE 'biblio-title.inc' link = 1 %] [% IF biblio.author %]by [% biblio.author | html %][% END %]</h2> > [% ELSE %] > <h2> > [% IF ( patron ) %] >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/title-actions-menu.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/title-actions-menu.inc >index cffc84910f6..0cb2ba1361f 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/title-actions-menu.inc >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/title-actions-menu.inc >@@ -4,14 +4,14 @@ > [% IF ( shelf AND op == 'view' ) # Lists view has more granular checking of hold availability %] > [% IF ( items.allow_onshelf_holds ) %] > <span class="actions" >- ><a class="btn btn-link btn-sm" aria-label="Place a hold on [% items.title | html %]" href="/cgi-bin/koha/opac-reserve.pl?biblionumber=[% items.biblionumber | html %]" >+ ><a class="btn btn-link btn-sm" aria-label="Place hold on [% items.title | html %]" href="/cgi-bin/koha/opac-reserve.pl?biblionumber=[% items.biblionumber | html %]" > ><i class="fa fa-fw fa-bookmark" aria-hidden="true"></i> Place hold</a > ></span > > > [% ELSE %] > [% IF ( items.itemsissued ) %] > <span class="actions" >- ><a class="btn btn-link btn-sm" aria-label="Place a hold on [% items.title | html %]" href="/cgi-bin/koha/opac-reserve.pl?biblionumber=[% items.biblionumber | html %]" >+ ><a class="btn btn-link btn-sm" aria-label="Place hold on [% items.title | html %]" href="/cgi-bin/koha/opac-reserve.pl?biblionumber=[% items.biblionumber | html %]" > ><i class="fa fa-fw fa-bookmark" aria-hidden="true"></i> Place hold</a > ></span > > >@@ -19,7 +19,7 @@ > [% END %] > [% ELSE %] > <span class="actions" >- ><a class="btn btn-link btn-sm" aria-label="Place a hold on [% items.title | html %]" href="/cgi-bin/koha/opac-reserve.pl?biblionumber=[% items.biblionumber | html %]" >+ ><a class="btn btn-link btn-sm" aria-label="Place hold on [% items.title | html %]" href="/cgi-bin/koha/opac-reserve.pl?biblionumber=[% items.biblionumber | html %]" > ><i class="fa fa-fw fa-bookmark" aria-hidden="true"></i> Place hold</a > ></span > > >@@ -87,7 +87,7 @@ > > > [% ELSE %] > <span class="actions cart-actions" >- ><a aria-label="Add [% items.title | html %] to the cart" data-biblionumber="[% items.biblionumber | html %]" class="btn btn-link btn-sm addtocart cart cart[% items.biblionumber | html %]" href="#" >+ ><a aria-label="Add [% items.title | html %] to cart" data-biblionumber="[% items.biblionumber | html %]" class="btn btn-link btn-sm addtocart cart cart[% items.biblionumber | html %]" href="#" > ><i class="fa fa-fw fa-shopping-cart" aria-hidden="true"></i> Add to cart</a > > > <a style="display:none;" data-biblionumber="[% items.biblionumber | html %]" class="btn btn-link btn-sm remove cartRemove cartR[% items.biblionumber | html %]" href="#">(remove)</a></span >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt >index 363702f9262..3c3c64d686c 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt >@@ -169,7 +169,7 @@ > id="single_[% bibitemloo.biblionumber | html %]" > value="any" > /> >- <label class="confirm_label" for="single_[% bibitemloo.biblionumber | html %]">Place a hold on </label> >+ <label class="confirm_label" for="single_[% bibitemloo.biblionumber | html %]">Place hold on </label> > </span> > [% END # / bibitemloo.holdable %] > >@@ -598,13 +598,13 @@ > $(".confirmjs_hold").each(function(){ > var bib = $(this).attr("title"); > var html = "<label><input type =\"checkbox\" class=\"confirmjs\" checked=\"checked\""; >- html += "value=\"" + bib + "\" id=\"" + bib + "\" /> " + _("Place a hold on") + " </label> "; >+ html += "value=\"" + bib + "\" id=\"" + bib + "\" /> " + _("Place hold on") + " </label> "; > $(this).html(html); > }); > $(".confirmjs_nohold").each(function(){ > var bib = $(this).attr("title"); > var html = "<label><input type =\"checkbox\" class=\"confirmjs\" disabled=\"disabled\""; >- html += "value=\"" + bib + "\" id=\"" + bib + "\" />" + _("Place a hold on: ") + "</label>"; >+ html += "value=\"" + bib + "\" id=\"" + bib + "\" />" + _("Place hold on: ") + "</label>"; > $(this).html(html); > }); > >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 41201
:
189150
|
189180
|
189251