Bugzilla – Attachment 189450 Details for
Bug 35211
Make it possible to split holdings tab using library groups in intranet
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35211: (QA follow-up) fix display of other results tab and move template toolkit logic outside of script array
Bug-35211-QA-follow-up-fix-display-of-other-result.patch (text/plain), 2.46 KB, created by
Lisette Scheer
on 2025-11-10 21:24:49 UTC
(
hide
)
Description:
Bug 35211: (QA follow-up) fix display of other results tab and move template toolkit logic outside of script array
Filename:
MIME Type:
Creator:
Lisette Scheer
Created:
2025-11-10 21:24:49 UTC
Size:
2.46 KB
patch
obsolete
>From 0ca9a2ddc138f80cfba1a6c5568ea50c49c8ddf1 Mon Sep 17 00:00:00 2001 >From: Lisette Scheer <lisette@bywatersolutions.com> >Date: Fri, 7 Nov 2025 22:24:35 +0000 >Subject: [PATCH] Bug 35211: (QA follow-up) fix display of other results tab > and move template toolkit logic outside of script array > >--- > .../prog/en/modules/catalogue/detail.tt | 20 ++++++++++++------- > 1 file changed, 13 insertions(+), 7 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >index ab0e9c1a8ef..a673a4062ba 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >@@ -344,7 +344,7 @@ > [% END %] > > [% IF Koha.Preference('SeparateHoldings') %] >- [% IF other_holdings_count %] >+ [% IF other_holdings_count > 0 %] > [% WRAPPER tab_item tabname= "otherholdings" %] > <span>Other holdings ([% other_holdings_count || 0 | html %])</span> > [% END %] >@@ -1750,23 +1750,29 @@ > [% END %] > <script> > var browser; >+ var group_tabs; > browser = KOHA.browser("[% searchid | html %]", parseInt(biblionumber, 10)); > browser.show(); >+ let group_tabs_array = new Array; >+ [% IF Koha.Preference('SeparateHoldingsByGroup') && lib_groups %] >+ [% FOREACH group IN lib_groups %] >+ group_tabs = "group_holdings_[% group.id | html %]" >+ group_tabs_array.push(group_tabs); >+ [% END %] >+ [% END %] > > [% IF bundlesEnabled %] > var bundle_settings = [% TablesSettings.GetTableSettings('catalogue', 'detail','bundle_tables','json') | $raw %]; > var bundle_lost_value = [% Koha.Preference('BundleLostValue') | html %]; > [% END %] > >- let items_tab_ids = [ >+ let items_tab_ids_default = [ > 'holdings', > 'otherholdings' >- [% IF Koha.Preference('SeparateHoldingsByGroup') && lib_groups %] >- [% FOREACH group IN lib_groups %] >- , 'group_holdings_[% group.id | html %]' >- [% END %] >- [% END %] > ]; >+ >+ let items_tab_ids = items_tab_ids_default.concat(group_tabs_array); >+ > items_tab_ids.forEach( function( tab_id, index ) { > > // Early return if the tab is not shown (ie. no table) >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35211
:
183075
|
183099
|
183143
|
183144
|
183420
|
183615
|
183642
|
183643
|
183901
|
183945
|
183949
|
183950
|
183966
|
183967
|
183968
|
184016
|
185336
|
185515
|
185525
|
185526
|
185527
|
185528
|
185529
|
185530
|
185531
|
188553
|
188554
|
188555
|
188556
|
188557
|
188558
|
188559
|
189379
|
189442
|
189443
|
189444
|
189445
|
189446
|
189447
|
189448
|
189449
| 189450 |
189451