Bugzilla – Attachment 189517 Details for
Bug 41040
Empty patron search from the header should not trigger a patron search
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 41040: Empty patron search from the header should not trigger a patron search
Bug-41040-Empty-patron-search-from-the-header-shou.patch (text/plain), 1.50 KB, created by
David Nind
on 2025-11-12 18:11:56 UTC
(
hide
)
Description:
Bug 41040: Empty patron search from the header should not trigger a patron search
Filename:
MIME Type:
Creator:
David Nind
Created:
2025-11-12 18:11:56 UTC
Size:
1.50 KB
patch
obsolete
>From c6472a1e1a5da848e689a1dd79b872988b0b5825 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Fri, 17 Oct 2025 06:53:38 -0400 >Subject: [PATCH] Bug 41040: Empty patron search from the header should not > trigger a patron search > >If the "arrow" button on the patron search is clicked with no value in >the textbox, it redirects to members/members-home.pl and performs a >search with no value automatically. It makes more send for it to behave >as the "Patrons" link in the navbar that directs to members-home.pl >where the librarian can then perform a more advanced search. > >Test Plan: >1) Click the "Search patrons" link on the header, then the arrow button >2) Note an empty patron search is performed immediately >3) Apply this patch >4) Restart all the things! >5) Repeat step 1 >6) Note a paton search is no longer triggered automatically > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >Signed-off-by: David Nind <david@davidnind.com> >--- > members/member.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/members/member.pl b/members/member.pl >index bd749ccc44..f0b68ade6f 100755 >--- a/members/member.pl >+++ b/members/member.pl >@@ -78,7 +78,7 @@ $template->param( > searchfieldstype => $searchfieldstype, > PatronsPerPage => C4::Context->preference("PatronsPerPage") || 20, > circsearch => $circsearch, >- defer_loading => 0, >+ defer_loading => $searchmember ? 0 : 1, > ); > > output_html_with_http_headers $input, $cookie, $template->output; >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 41040
:
188062
|
189016
|
189017
|
189018
|
189197
|
189198
|
189199
|
189508
|
189509
|
189510
|
189511
| 189517 |
189518
|
189519
|
189520