If the "arrow" button on the patron search is clicked with no value in the textbox, it redirects to members/members-home.pl and performs a search with no value automatically. It makes more send for it to behave as the "Patrons" link in the navbar that directs to members-home.pl where the librarian can then perform a more advanced search.
Created attachment 188062 [details] [review] Bug 41040: Empty patron search from the header should not trigger a patron search If the "arrow" button on the patron search is clicked with no value in the textbox, it redirects to members/members-home.pl and performs a search with no value automatically. It makes more send for it to behave as the "Patrons" link in the navbar that directs to members-home.pl where the librarian can then perform a more advanced search. Test Plan: 1) Click the "Search patrons" link on the header, then the arrow button 2) Note an empty patron search is performed immediately 3) Apply this patch 4) Restart all the things! 5) Repeat step 1 6) Note a paton search is no longer triggered automatically
The patch works. But... I often use this to get the list of patrons. Although my use case might not be what "normal" staff users do since I don't work in a library.
(In reply to Caroline Cyr La Rose from comment #2) > The patch works. > > But... > > I often use this to get the list of patrons. Although my use case might not > be what "normal" staff users do since I don't work in a library. The letter searches should still work for your use case!
(In reply to Caroline Cyr La Rose from comment #2) > The patch works. > > But... > > I often use this to get the list of patrons. Although my use case might not > be what "normal" staff users do since I don't work in a library. As a developer, I do this a lot too. But is this actually a work flow any real life librarian uses? Certainly not in a large system.
(In reply to Lucas Gass (lukeg) from comment #4) > (In reply to Caroline Cyr La Rose from comment #2) > > The patch works. > > > > But... > > > > I often use this to get the list of patrons. Although my use case might not > > be what "normal" staff users do since I don't work in a library. > > As a developer, I do this a lot too. But is this actually a work flow any > real life librarian uses? Certainly not in a large system. Hence my sentence > > [...] Although my use case might not > > be what "normal" staff users do since I don't work in a library.