Bug 41040 - Empty patron search from the header should not trigger a patron search
Summary: Empty patron search from the header should not trigger a patron search
Status: Needs Signoff
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low minor
Assignee: Kyle M Hall (khall)
QA Contact: Testopia
URL:
Keywords: RM_priority
Depends on:
Blocks:
 
Reported: 2025-10-16 23:19 UTC by Kyle M Hall (khall)
Modified: 2025-10-20 13:13 UTC (History)
7 users (show)

See Also:
GIT URL:
Sponsorship status: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 41040: Empty patron search from the header should not trigger a patron search (1.42 KB, patch)
2025-10-17 10:56 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle M Hall (khall) 2025-10-16 23:19:29 UTC
If the "arrow" button on the patron search is clicked with no value in the textbox, it redirects to members/members-home.pl and performs a search with no value automatically. It makes more send for it to behave as the "Patrons" link in the navbar that directs to members-home.pl where the librarian can then perform a more advanced search.
Comment 1 Kyle M Hall (khall) 2025-10-17 10:56:53 UTC
Created attachment 188062 [details] [review]
Bug 41040: Empty patron search from the header should not trigger a patron search

If the "arrow" button on the patron search is clicked with no value in the textbox, it redirects to members/members-home.pl and performs a search with no value automatically. It makes more send for it to behave as the "Patrons" link in the navbar that directs to members-home.pl where the librarian can then perform a more advanced search.

Test Plan:
1) Click the "Search patrons" link on the header, then the arrow button
2) Note an empty patron search is performed immediately
3) Apply this patch
4) Restart all the things!
5) Repeat step 1
6) Note a paton search is no longer triggered automatically
Comment 2 Caroline Cyr La Rose 2025-10-17 18:38:00 UTC
The patch works.

But...

I often use this to get the list of patrons. Although my use case might not be what "normal" staff users do since I don't work in a library.
Comment 3 Kyle M Hall (khall) 2025-10-20 11:20:56 UTC
(In reply to Caroline Cyr La Rose from comment #2)
> The patch works.
> 
> But...
> 
> I often use this to get the list of patrons. Although my use case might not
> be what "normal" staff users do since I don't work in a library.

The letter searches should still work for your use case!
Comment 4 Lucas Gass (lukeg) 2025-10-20 13:11:36 UTC
(In reply to Caroline Cyr La Rose from comment #2)
> The patch works.
> 
> But...
> 
> I often use this to get the list of patrons. Although my use case might not
> be what "normal" staff users do since I don't work in a library.

As a developer, I do this a lot too. But is this actually a work flow any real life librarian uses? Certainly not in a large system.
Comment 5 Caroline Cyr La Rose 2025-10-20 13:13:30 UTC
(In reply to Lucas Gass (lukeg) from comment #4)
> (In reply to Caroline Cyr La Rose from comment #2)
> > The patch works.
> > 
> > But...
> > 
> > I often use this to get the list of patrons. Although my use case might not
> > be what "normal" staff users do since I don't work in a library.
> 
> As a developer, I do this a lot too. But is this actually a work flow any
> real life librarian uses? Certainly not in a large system.

Hence my sentence

> > [...] Although my use case might not
> > be what "normal" staff users do since I don't work in a library.