Bugzilla – Attachment 190129 Details for
Bug 41369
SIP payments have no branchcode
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 41369 - SIP payments have no branchcode
Bug-41369---SIP-payments-have-no-branchcode.patch (text/plain), 4.34 KB, created by
Kyle M Hall (khall)
on 2025-12-03 18:53:43 UTC
(
hide
)
Description:
Bug 41369 - SIP payments have no branchcode
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2025-12-03 18:53:43 UTC
Size:
4.34 KB
patch
obsolete
>From 5dc03d80fb4d6e533e1f9460ffe86f41c6326427 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Wed, 3 Dec 2025 13:13:52 -0500 >Subject: [PATCH] Bug 41369 - SIP payments have no branchcode > >For SIP based payments, no branchcode is recorded for the corresponding credit. Koha should be recording the institution id ( i.e. branchcode ) for SIP payments. > >Test plan: >1) Apply this patch >2) prove t/db_dependent/SIP/Transaction.t >--- > C4/SIP/ILS.pm | 4 ++-- > C4/SIP/ILS/Transaction/FeePayment.pm | 2 ++ > C4/SIP/Sip/MsgType.pm | 4 ++-- > t/db_dependent/SIP/Transaction.t | 9 ++++++--- > 4 files changed, 12 insertions(+), 7 deletions(-) > >diff --git a/C4/SIP/ILS.pm b/C4/SIP/ILS.pm >index 1dd3453bd27..174a8eacafe 100644 >--- a/C4/SIP/ILS.pm >+++ b/C4/SIP/ILS.pm >@@ -358,7 +358,7 @@ sub end_patron_session { > sub pay_fee { > my ( > $self, $patron_id, $patron_pwd, $fee_amt, $fee_type, $pay_type, $fee_id, $trans_id, $currency, $is_writeoff, >- $disallow_overpayment, $register_id >+ $disallow_overpayment, $register_id, $inst_id > ) = @_; > > my $trans = C4::SIP::ILS::Transaction::FeePayment->new(); >@@ -372,7 +372,7 @@ sub pay_fee { > } > my $trans_result = $trans->pay( > $patron->{borrowernumber}, $fee_amt, $pay_type, $fee_id, $is_writeoff, $disallow_overpayment, >- $register_id >+ $register_id, $inst_id > ); > my $ok = $trans_result->{ok}; > $trans->ok($ok); >diff --git a/C4/SIP/ILS/Transaction/FeePayment.pm b/C4/SIP/ILS/Transaction/FeePayment.pm >index d8824f2cad4..ff1b801e2e7 100644 >--- a/C4/SIP/ILS/Transaction/FeePayment.pm >+++ b/C4/SIP/ILS/Transaction/FeePayment.pm >@@ -50,6 +50,7 @@ sub pay { > my $is_writeoff = shift; > my $disallow_overpayment = shift; > my $register_id = shift; >+ my $inst_id = shift; > > my $type = $is_writeoff ? 'WRITEOFF' : 'PAYMENT'; > >@@ -66,6 +67,7 @@ sub pay { > payment_type => 'SIP' . $sip_type, > interface => C4::Context->interface, > cash_register => $register_id, >+ library_id => $inst_id, > }; > > if ($fee_id) { >diff --git a/C4/SIP/Sip/MsgType.pm b/C4/SIP/Sip/MsgType.pm >index d77c8088d16..37cb7d1a7e8 100644 >--- a/C4/SIP/Sip/MsgType.pm >+++ b/C4/SIP/Sip/MsgType.pm >@@ -1237,8 +1237,8 @@ sub handle_fee_paid { > $ils->check_inst_id( $inst_id, "handle_fee_paid" ); > > my $pay_result = $ils->pay_fee( >- $patron_id, $patron_pwd, $fee_amt, $fee_type, $pay_type, $fee_id, $trans_id, $currency, >- $is_writeoff, $disallow_overpayment, $register_id >+ $patron_id, $patron_pwd, $fee_amt, $fee_type, $pay_type, $fee_id, $trans_id, $currency, >+ $is_writeoff, $disallow_overpayment, $register_id, $ils->institution > ); > $status = $pay_result->{status}; > my $pay_response = $pay_result->{pay_response}; >diff --git a/t/db_dependent/SIP/Transaction.t b/t/db_dependent/SIP/Transaction.t >index 5196d4b3bfa..1d91c693ab5 100755 >--- a/t/db_dependent/SIP/Transaction.t >+++ b/t/db_dependent/SIP/Transaction.t >@@ -129,7 +129,9 @@ subtest fill_holds_at_checkout => sub { > > subtest "FeePayment->pay tests" => sub { > >- plan tests => 5; >+ plan tests => 6; >+ >+ my $inst_id = $builder->build_object( { class => 'Koha::Libraries' } )->id; > > # Create a borrower and add some outstanding debts to their account > my $patron = $builder->build( { source => 'Borrower' } ); >@@ -152,7 +154,7 @@ subtest "FeePayment->pay tests" => sub { > my $pay_type = '00'; # 00 - Cash, 01 - VISA, 02 - Creditcard > my $ok = $trans->pay( > $patron->{borrowernumber}, 100, $pay_type, $debt1->id, 0, >- 0 >+ 0, undef, $inst_id > ); > ok( $ok, "FeePayment transaction succeeded" ); > $debt1->discard_changes; >@@ -163,7 +165,8 @@ subtest "FeePayment->pay tests" => sub { > my $offsets = Koha::Account::Offsets->search( { debit_id => $debt1->id, credit_id => { '!=' => undef } } ); > is( $offsets->count, 1, "FeePayment produced an offset line correctly" ); > my $credit = $offsets->next->credit; >- is( $credit->payment_type, 'SIP00', "Payment type was set correctly" ); >+ is( $credit->payment_type, 'SIP00', "Payment type was set correctly" ); >+ is( $credit->branchcode, $inst_id, "Branchcode was set correctly" ); > }; > > subtest cancel_hold => sub { >-- >2.50.1 (Apple Git-155)
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 41369
:
190127
|
190129
|
190133