For SIP based payments, no branchcode is recorded for the corresponding credit. Koha should be recording the institution id ( i.e. branchcode ) for SIP payments.
Created attachment 190127 [details] [review] Bug 41369 - SIP payments have no branchcode For SIP based payments, no branchcode is recorded for the corresponding credit. Koha should be recording the institution id ( i.e. branchcode ) for SIP payments. Test plan: 1) Apply this patch 2) prove t/db_dependent/SIP/Transaction.t
Created attachment 190129 [details] [review] Bug 41369 - SIP payments have no branchcode For SIP based payments, no branchcode is recorded for the corresponding credit. Koha should be recording the institution id ( i.e. branchcode ) for SIP payments. Test plan: 1) Apply this patch 2) prove t/db_dependent/SIP/Transaction.t
Created attachment 190133 [details] [review] Bug 41369: SIP payments have no branchcode For SIP based payments, no branchcode is recorded for the corresponding credit. Koha should be recording the institution id (i.e. branchcode) for SIP payments. Test plan: 1) Apply this patch 2) prove t/db_dependent/SIP/Transaction.t Signed-off-by: David Nind <david@davidnind.com>
* Proving /usr/share/koha/t/db_dependent/SIP/Transaction.t FAIL # Looks like you planned 14 tests but ran 9. # Failed test 'do_checkin' # at /usr/share/koha/t/db_dependent/SIP/Transaction.t line 714. Can't call method "branchtransfer_id" on an undefined value at /usr/share/koha/t/db_dependent/SIP/Transaction.t line 501. Do we need to mock some circ preferences to get this always working ?
(In reply to Marcel de Rooy from comment #4) > * Proving /usr/share/koha/t/db_dependent/SIP/Transaction.t FAIL > # Looks like you planned 14 tests but ran 9. > > # Failed test 'do_checkin' > # at /usr/share/koha/t/db_dependent/SIP/Transaction.t line 714. > Can't call method "branchtransfer_id" on an undefined value at > /usr/share/koha/t/db_dependent/SIP/Transaction.t line 501. > > Do we need to mock some circ preferences to get this always working ? Possibly, but this would be unrelated to this patch. The failed unit test is not even in the subtest I modified!
(In reply to Kyle M Hall (khall) from comment #5) > (In reply to Marcel de Rooy from comment #4) > > * Proving /usr/share/koha/t/db_dependent/SIP/Transaction.t FAIL > > # Looks like you planned 14 tests but ran 9. > > > > # Failed test 'do_checkin' > > # at /usr/share/koha/t/db_dependent/SIP/Transaction.t line 714. > > Can't call method "branchtransfer_id" on an undefined value at > > /usr/share/koha/t/db_dependent/SIP/Transaction.t line 501. > > > > Do we need to mock some circ preferences to get this always working ? > > Possibly, but this would be unrelated to this patch. The failed unit test is > not even in the subtest I modified! Ah. Thats true.
Seems that AutomaticItemReturn was the cause; enabling it makes the test pass. Seems logical given the error message..
Created attachment 190280 [details] [review] Bug 41369: SIP payments have no branchcode For SIP based payments, no branchcode is recorded for the corresponding credit. Koha should be recording the institution id (i.e. branchcode) for SIP payments. Test plan: 1) Apply this patch 2) prove t/db_dependent/SIP/Transaction.t Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Nice work everyone! Pushed to main for 26.05