Bugzilla – Attachment 190135 Details for
Bug 41361
Incorrect markup in category code confirmation modal
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 41361: Fix markup in category code confirmation modal
Bug-41361-Fix-markup-in-category-code-confirmation.patch (text/plain), 3.33 KB, created by
David Nind
on 2025-12-03 22:05:04 UTC
(
hide
)
Description:
Bug 41361: Fix markup in category code confirmation modal
Filename:
MIME Type:
Creator:
David Nind
Created:
2025-12-03 22:05:04 UTC
Size:
3.33 KB
patch
obsolete
>From deed4e5fe5879219f8389eff8659b05444345624 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Wed, 3 Dec 2025 08:18:17 -0500 >Subject: [PATCH] Bug 41361: Fix markup in category code confirmation modal > >This patch fixes the markup in the modal, introduced by Bug 32581, >asking whether to update the patron's expiration date when changing the >patron category. The markup needs to be updated to conform with >Bootstrap 5. > >To test, apply the patch and go to Patrons. > >- Search for any patron and edit it. >- Scroll down to the "Library management" section. >- Change the category. > - You should see a confirmation modal: "Confirm expiration date" > - Test each of the controls to confirm that they work correctly: The > "X" close button, the "Yes" and "No" buttons. > >Sponsored-by: Athens County Public Libraries >Signed-off-by: David Nind <david@davidnind.com> >--- > .../prog/en/modules/members/memberentrygen.tt | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt >index db1ad64809..15ccf28f45 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt >@@ -962,7 +962,6 @@ > [% IF limited_category %] > <span title="The patron's current category ([% patron_category.description | html %]) is limited to other libraries"><i class="fa fa-exclamation-triangle" aria-hidden="true"></i></span> > [% END %] >- <span class="required">Required</span> > </li> > > [% UNLESS nosort1 %] >@@ -1663,18 +1662,18 @@ > > <!-- Expiration date modal--> > <div id="expirationDateModal" class="modal" tabindex="-1" role="dialog" aria-labelledby="expirationDateModalLabel" aria-hidden="true"> >- <div class="modal-dialog" role="document"> >+ <div class="modal-dialog"> > <div class="modal-content"> > <div class="modal-header"> >- <button type="button" class="closebtn" data-dismiss="modal" aria-label="Close"><span aria-hidden="true">×</span></button> >- <h4 class="modal-title" id="expirationDateModalLabel">Confirm expiration date</h4> >+ <h1 class="modal-title" id="expirationDateModalLabel">Confirm expiration date</h1> >+ <button type="button" class="btn-close" data-bs-dismiss="modal" aria-label="Close"></button> > </div> > <div class="modal-body"> > <p>Change expiration date to default for this category?</p> > </div> > <div class="modal-footer"> > <button id="expirationDateConfirmBtn" class="btn btn-primary"><i class="fa fa-check" aria-hidden="true"></i> Yes</button> >- <button id="expirationDateCancelBtn" data-dismiss="modal" class="btn btn-secondary"><i class="fa fa-times" aria-hidden="true"></i> No</button> >+ <button id="expirationDateCancelBtn" data-bs-dismiss="modal" class="btn btn-secondary"><i class="fa fa-times" aria-hidden="true"></i> No</button> > </div> > </div> > </div> >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 41361
:
190109
| 190135 |
190136
|
190137