Bug 32581 introduced a new modal asking whether to update the patron's expiration date when changing the patron category. This modal uses older Bootstrap markup and doesn't work right.
Created attachment 190109 [details] [review] Bug 41361: Fix markup in category code confirmation modal This patch fixes the markup in the modal, introduced by Bug 32581, asking whether to update the patron's expiration date when changing the patron category. The markup needs to be updated to conform with Bootstrap 5. To test, apply the patch and go to Patrons. - Search for any patron and edit it. - Scroll down to the "Library management" section. - Change the category. - You should see a confirmation modal: "Confirm expiration date" - Test each of the controls to confirm that they work correctly: The "X" close button, the "Yes" and "No" buttons. Sponsored-by: Athens County Public Libraries
Created attachment 190135 [details] [review] Bug 41361: Fix markup in category code confirmation modal This patch fixes the markup in the modal, introduced by Bug 32581, asking whether to update the patron's expiration date when changing the patron category. The markup needs to be updated to conform with Bootstrap 5. To test, apply the patch and go to Patrons. - Search for any patron and edit it. - Scroll down to the "Library management" section. - Change the category. - You should see a confirmation modal: "Confirm expiration date" - Test each of the controls to confirm that they work correctly: The "X" close button, the "Yes" and "No" buttons. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com>
Testing notes (using KTD): 1. I changed the patron category for Mary Burton from Patron to Home Bound: 1.1 Browser pop-up with message: Change messaging preferences to default for this category? 1.2 Press OK 1.3 Dialog box/Modal appears (see screenshot 1) 1.4 Clicking the "No" option does nothing 1.5 The dialog box is not formatted correctly 2. Apply the patch and repeat the steps. 3. The "No" option now works. 4. The dialog box (see screenshot 2)
Created attachment 190136 [details] Screenshot 1 - Before the patch
Created attachment 190137 [details] Screenshot 2 - After the patch