Bug 41361 - Incorrect markup in category code confirmation modal
Summary: Incorrect markup in category code confirmation modal
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on: 32581
Blocks:
  Show dependency treegraph
 
Reported: 2025-12-03 13:17 UTC by Owen Leonard
Modified: 2025-12-03 22:14 UTC (History)
1 user (show)

See Also:
GIT URL:
Initiative type: ---
Sponsorship status: ---
Comma delimited list of Sponsors:
Crowdfunding goal: 0
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes the "Confirm expiration date" dialog box that is shown when changing an individual patron's category: - The "No" option now works. - It is now formatted using our standard Bootstrap 5 styles.
Version(s) released in:
Circulation function:


Attachments
Bug 41361: Fix markup in category code confirmation modal (3.28 KB, patch)
2025-12-03 13:28 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 41361: Fix markup in category code confirmation modal (3.33 KB, patch)
2025-12-03 22:05 UTC, David Nind
Details | Diff | Splinter Review
Screenshot 1 - Before the patch (11.13 KB, image/png)
2025-12-03 22:14 UTC, David Nind
Details
Screenshot 2 - After the patch (12.84 KB, image/png)
2025-12-03 22:14 UTC, David Nind
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2025-12-03 13:17:07 UTC
Bug 32581 introduced a new modal asking whether to update the patron's expiration date when changing the patron category. This modal uses older Bootstrap markup and doesn't work right.
Comment 1 Owen Leonard 2025-12-03 13:28:29 UTC
Created attachment 190109 [details] [review]
Bug 41361: Fix markup in category code confirmation modal

This patch fixes the markup in the modal, introduced by Bug 32581,
asking whether to update the patron's expiration date when changing the
patron category. The markup needs to be updated to conform with
Bootstrap 5.

To test, apply the patch and go to Patrons.

- Search for any patron and edit it.
- Scroll down to the "Library management" section.
- Change the category.
  - You should see a confirmation modal: "Confirm expiration date"
  - Test each of the controls to confirm that they work correctly: The
    "X" close button, the "Yes" and "No" buttons.

Sponsored-by: Athens County Public Libraries
Comment 2 David Nind 2025-12-03 22:05:04 UTC
Created attachment 190135 [details] [review]
Bug 41361: Fix markup in category code confirmation modal

This patch fixes the markup in the modal, introduced by Bug 32581,
asking whether to update the patron's expiration date when changing the
patron category. The markup needs to be updated to conform with
Bootstrap 5.

To test, apply the patch and go to Patrons.

- Search for any patron and edit it.
- Scroll down to the "Library management" section.
- Change the category.
  - You should see a confirmation modal: "Confirm expiration date"
  - Test each of the controls to confirm that they work correctly: The
    "X" close button, the "Yes" and "No" buttons.

Sponsored-by: Athens County Public Libraries
Signed-off-by: David Nind <david@davidnind.com>
Comment 3 David Nind 2025-12-03 22:14:02 UTC
Testing notes (using KTD):

1. I changed the patron category for Mary Burton from Patron to Home Bound:
   1.1 Browser pop-up with message: Change messaging preferences to default for this category?
   1.2 Press OK
   1.3 Dialog box/Modal appears (see screenshot 1)
   1.4 Clicking the "No" option does nothing
   1.5 The dialog box is not formatted correctly
2. Apply the patch and repeat the steps.
3. The "No" option now works.
4. The dialog box (see screenshot 2)
Comment 4 David Nind 2025-12-03 22:14:29 UTC
Created attachment 190136 [details]
Screenshot 1 - Before the patch
Comment 5 David Nind 2025-12-03 22:14:54 UTC
Created attachment 190137 [details]
Screenshot 2 - After the patch