Bugzilla – Attachment 190193 Details for
Bug 40567
Correct eslint errors in recalls.js
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 40567: Correct eslint errors in recalls.js
Bug-40567-Correct-eslint-errors-in-recallsjs.patch (text/plain), 4.31 KB, created by
Marcel de Rooy
on 2025-12-05 07:23:48 UTC
(
hide
)
Description:
Bug 40567: Correct eslint errors in recalls.js
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2025-12-05 07:23:48 UTC
Size:
4.31 KB
patch
obsolete
>From c8f630fb0c3edc21b66ea33488e44738584e7643 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Thu, 31 Jul 2025 15:21:04 +0000 >Subject: [PATCH] Bug 40567: Correct eslint errors in recalls.js >Content-Type: text/plain; charset=utf-8 > >This patch corrects a few minor errors in recalls.js. There should be no >change to how the pages work. > >The following functions have been changed: > >- Cancel a recall from the recalls tab on a patron record >- Expire a recall or revert the waiting status of a recall from the > "Recalls awaiting pickup" page. >- Cancel a recall which has been transferred from the "Recalls queue" > page. >- Mark a recall "Overdue" from the "Recalls queue" page. >- Cancel selected recalls on the "Recalls queue" page. > >Sponsored-by: Athens County Public Libraries >Signed-off-by: David Nind <david@davidnind.com> > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > koha-tmpl/intranet-tmpl/prog/js/recalls.js | 18 ++++++++++++------ > 1 file changed, 12 insertions(+), 6 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/recalls.js b/koha-tmpl/intranet-tmpl/prog/js/recalls.js >index 5c6255b23d..e32a943cd1 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/recalls.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/recalls.js >@@ -1,10 +1,12 @@ >+/* global APIClient __ confirmDelete */ > $(document).ready(function () { > const client = APIClient.recall; > >- $(".cancel_recall").click(function (e) { >+ $(".cancel_recall").click(function () { > if (confirmDelete(__("Are you sure you want to remove this recall?"))) { > let td_node = $(this).parents("td"); > let recall_id = $(this).data("id"); >+ let message; > client.recalls.cancel(recall_id).then( > success => { > if (success.success == 0) { >@@ -23,10 +25,11 @@ $(document).ready(function () { > } > }); > >- $(".expire_recall").click(function (e) { >+ $(".expire_recall").click(function () { > if (confirmDelete(__("Are you sure you want to expire this recall?"))) { > let td_node = $(this).parents("td"); > let recall_id = $(this).data("id"); >+ let message; > client.recalls.expire(recall_id).then( > success => { > if (success.success == 0) { >@@ -45,7 +48,7 @@ $(document).ready(function () { > } > }); > >- $(".revert_recall").click(function (e) { >+ $(".revert_recall").click(function () { > if ( > confirmDelete( > __( >@@ -55,6 +58,7 @@ $(document).ready(function () { > ) { > let td_node = $(this).parents("td"); > let recall_id = $(this).data("id"); >+ let message; > client.recalls.revert(recall_id).then( > success => { > if (success.success == 0) { >@@ -73,7 +77,7 @@ $(document).ready(function () { > } > }); > >- $(".overdue_recall").click(function (e) { >+ $(".overdue_recall").click(function () { > if ( > confirmDelete( > __("Are you sure you want to mark this recall as overdue?") >@@ -81,6 +85,7 @@ $(document).ready(function () { > ) { > let td_node = $(this).parents("td"); > let recall_id = $(this).data("id"); >+ let message; > client.recalls.overdue(recall_id).then( > success => { > if (success.success == 0) { >@@ -99,7 +104,7 @@ $(document).ready(function () { > } > }); > >- $(".transit_recall").click(function (e) { >+ $(".transit_recall").click(function () { > if ( > confirmDelete( > __( >@@ -109,6 +114,7 @@ $(document).ready(function () { > ) { > let td_node = $(this).parents("td"); > let recall_id = $(this).data("id"); >+ let message; > client.recalls.transit(recall_id).then( > success => { > if (success.success == 0) { >@@ -132,7 +138,7 @@ $(document).ready(function () { > pagingType: "full_numbers", > }); > >- $("#cancel_selected").click(function (e) { >+ $("#cancel_selected").click(function () { > if ($("input[name='recall_ids']:checked").length > 0) { > return confirmDelete( > __("Are you sure you want to remove the selected recall(s)?") >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 40567
:
184934
|
189383
| 190193