Following coding guideline JS8: "Follow guidelines set by ESLint," some errors should be corrected in recalls.js
Created attachment 184934 [details] [review] Bug 40567: Correct eslint errors in recalls.js This patch corrects a few minor errors in recalls.js. There should be no change to how the pages work. The following functions have been changed: - Cancel a recall from the recalls tab on a patron record - Expire a recall or revert the waiting status of a recall from the "Recalls awaiting pickup" page. - Cancel a recall which has been transferred from the "Recalls queue" page. - Mark a recall "Overdue" from the "Recalls queue" page. - Cancel selected recalls on the "Recalls queue" page. Sponsored-by: Athens County Public Libraries
Created attachment 189383 [details] [review] Bug 40567: Correct eslint errors in recalls.js This patch corrects a few minor errors in recalls.js. There should be no change to how the pages work. The following functions have been changed: - Cancel a recall from the recalls tab on a patron record - Expire a recall or revert the waiting status of a recall from the "Recalls awaiting pickup" page. - Cancel a recall which has been transferred from the "Recalls queue" page. - Mark a recall "Overdue" from the "Recalls queue" page. - Cancel selected recalls on the "Recalls queue" page. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com>
Not sure how to do "Mark a recall "Overdue" from the "Recalls queue" page.", so I didn't test that one. Everything else worked fine.
Created attachment 190193 [details] [review] Bug 40567: Correct eslint errors in recalls.js This patch corrects a few minor errors in recalls.js. There should be no change to how the pages work. The following functions have been changed: - Cancel a recall from the recalls tab on a patron record - Expire a recall or revert the waiting status of a recall from the "Recalls awaiting pickup" page. - Cancel a recall which has been transferred from the "Recalls queue" page. - Mark a recall "Overdue" from the "Recalls queue" page. - Cancel selected recalls on the "Recalls queue" page. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Nice work everyone! Pushed to main for 26.05