Bug 40567 - Correct eslint errors in recalls.js
Summary: Correct eslint errors in recalls.js
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial
Assignee: Owen Leonard
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks: 23833 40589
  Show dependency treegraph
 
Reported: 2025-07-31 15:20 UTC by Owen Leonard
Modified: 2025-12-17 22:10 UTC (History)
2 users (show)

See Also:
GIT URL:
Initiative type: ---
Sponsorship status: ---
Comma delimited list of Sponsors:
Crowdfunding goal: 0
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes a few minor coding guideline errors in the JavaScript used on recalls pages (JS8: Follow guidelines set by ESLint). There are no changes to how the recalls pages work.
Version(s) released in:
26.05.00
Circulation function:


Attachments
Bug 40567: Correct eslint errors in recalls.js (4.17 KB, patch)
2025-07-31 15:54 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 40567: Correct eslint errors in recalls.js (4.21 KB, patch)
2025-11-08 03:05 UTC, David Nind
Details | Diff | Splinter Review
Bug 40567: Correct eslint errors in recalls.js (4.31 KB, patch)
2025-12-05 07:23 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2025-07-31 15:20:21 UTC
Following coding guideline JS8: "Follow guidelines set by ESLint," some errors should be corrected in recalls.js
Comment 1 Owen Leonard 2025-07-31 15:54:19 UTC
Created attachment 184934 [details] [review]
Bug 40567: Correct eslint errors in recalls.js

This patch corrects a few minor errors in recalls.js. There should be no
change to how the pages work.

The following functions have been changed:

- Cancel a recall from the recalls tab on a patron record
- Expire a recall or revert the waiting status of a recall from the
  "Recalls awaiting pickup" page.
- Cancel a recall which has been transferred from the "Recalls queue"
  page.
- Mark a recall "Overdue" from the "Recalls queue" page.
- Cancel selected recalls on the "Recalls queue" page.

Sponsored-by: Athens County Public Libraries
Comment 2 David Nind 2025-11-08 03:05:40 UTC
Created attachment 189383 [details] [review]
Bug 40567: Correct eslint errors in recalls.js

This patch corrects a few minor errors in recalls.js. There should be no
change to how the pages work.

The following functions have been changed:

- Cancel a recall from the recalls tab on a patron record
- Expire a recall or revert the waiting status of a recall from the
  "Recalls awaiting pickup" page.
- Cancel a recall which has been transferred from the "Recalls queue"
  page.
- Mark a recall "Overdue" from the "Recalls queue" page.
- Cancel selected recalls on the "Recalls queue" page.

Sponsored-by: Athens County Public Libraries
Signed-off-by: David Nind <david@davidnind.com>
Comment 3 David Nind 2025-11-08 03:06:36 UTC
Not sure how to do "Mark a recall "Overdue" from the "Recalls queue" page.", so I didn't test that one.

Everything else worked fine.
Comment 4 Marcel de Rooy 2025-12-05 07:23:48 UTC
Created attachment 190193 [details] [review]
Bug 40567: Correct eslint errors in recalls.js

This patch corrects a few minor errors in recalls.js. There should be no
change to how the pages work.

The following functions have been changed:

- Cancel a recall from the recalls tab on a patron record
- Expire a recall or revert the waiting status of a recall from the
  "Recalls awaiting pickup" page.
- Cancel a recall which has been transferred from the "Recalls queue"
  page.
- Mark a recall "Overdue" from the "Recalls queue" page.
- Cancel selected recalls on the "Recalls queue" page.

Sponsored-by: Athens County Public Libraries
Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 5 Lucas Gass (lukeg) 2025-12-17 20:26:33 UTC
Nice work everyone!

Pushed to main for 26.05