Bugzilla – Attachment 191479 Details for
Bug 41623
Missing translation string in catalogue_detail.inc (again)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 41623 : Fix translation pickup in catalogue_details.inc
Bug-41623--Fix-translation-pickup-in-cataloguedeta.patch (text/plain), 3.13 KB, created by
Caroline Cyr La Rose
on 2026-01-14 21:59:17 UTC
(
hide
)
Description:
Bug 41623 : Fix translation pickup in catalogue_details.inc
Filename:
MIME Type:
Creator:
Caroline Cyr La Rose
Created:
2026-01-14 21:59:17 UTC
Size:
3.13 KB
patch
obsolete
>From bc6182ce68b6b4718cfba90b5ebe66462295f6fa Mon Sep 17 00:00:00 2001 >From: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> >Date: Wed, 14 Jan 2026 16:45:53 -0500 >Subject: [PATCH] Bug 41623 : Fix translation pickup in catalogue_details.inc > >This patch redoes the fix that was made in bug 38450 to make sure >the "Waiting at ... since ..." string is picked up by the translation >tool. It's a parenthesis move. > >See bug 38450 for explanation. > >_("This %s is picked").format(foo) >_("This %s is NOT picked".format(bar)) > >To test: >1. Install a new langage >gulp po:update --lang fr-CA >./misc/translator/translate install fr-CA > >2. Place a hold > >3. Check in the item on hold and confirm the hold > >4. Go to the record details page > --> Waiting at ... since ... is in English > >5. Check the translation files >cd misc/translator/po/ >git grep "Waiting at" fr-CA* > >--> There is no "Waiting at %s, %s since %s." > >6. Apply patch > >7. Update strings again > >8. Check translation files again >--> The string should be there > >9. Translate the string (making sure to remove the fuzzy line if any) > >10. Install the translation again (only the translate install part) > >11. Check the record details page > --> It should be translated! >--- > .../includes/html_helpers/tables/items/catalogue_detail.inc | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc >index 01f57749716..7bd0b733e68 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc >@@ -596,9 +596,9 @@ > if ( status == 'on_hold') { > if ( row.first_hold.waiting_date ) { > if ( row.first_hold.desk ) { >- nodes += '<span class="waitingat">%s</span>'.format(_("Waiting at %s, %s since %s.".format(row.first_hold._strings.pickup_library_id.str, row.first_hold.desk.desk_name, $date(row.first_hold.waiting_date)))); >+ nodes += '<span class="waitingat">%s</span>'.format(_("Waiting at %s, %s since %s.").format(row.first_hold._strings.pickup_library_id.str, row.first_hold.desk.desk_name, $date(row.first_hold.waiting_date))); > } else { >- nodes += '<span class="waitingat">%s</span>'.format(_("Waiting at %s since %s.".format(row.first_hold._strings.pickup_library_id.str, $date(row.first_hold.waiting_date)))); >+ nodes += '<span class="waitingat">%s</span>'.format(_("Waiting at %s since %s.").format(row.first_hold._strings.pickup_library_id.str, $date(row.first_hold.waiting_date))); > } > [% IF Koha.Preference('canreservefromotherbranches') %] > if ( row.first_hold.waiting_date || row.first_hold.priority == 1 ) { >-- >2.43.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 41623
:
191479
|
191483
|
191484
|
191504
|
191561
|
191562