Jonathan did a change to the strings in bug 38450 and this change was overwritten in bug 37334. Probably a rebase error or something like that... In short, Waiting at ... since ... in the record details is not translatables since at least 25.05 (probably 24.11.08 also since both were backported to that version). To recreate: 1. Install a new langage gulp po:update --lang fr-CA ./misc/translator/translate install fr-CA 2. Place a hold 3. Check in the item on hold and confirm the hold 4. Go to the record details page --> Waiting at ... since ... is in English 5. Check the translation files cd misc/translator/po/ git grep "Waiting at" fr-CA* --> There is no "Waiting at %s, %s since %s."
Created attachment 191479 [details] [review] Bug 41623 : Fix translation pickup in catalogue_details.inc This patch redoes the fix that was made in bug 38450 to make sure the "Waiting at ... since ..." string is picked up by the translation tool. It's a parenthesis move. See bug 38450 for explanation. _("This %s is picked").format(foo) _("This %s is NOT picked".format(bar)) To test: 1. Install a new langage gulp po:update --lang fr-CA ./misc/translator/translate install fr-CA 2. Place a hold 3. Check in the item on hold and confirm the hold 4. Go to the record details page --> Waiting at ... since ... is in English 5. Check the translation files cd misc/translator/po/ git grep "Waiting at" fr-CA* --> There is no "Waiting at %s, %s since %s." 6. Apply patch 7. Update strings again 8. Check translation files again --> The string should be there 9. Translate the string (making sure to remove the fuzzy line if any) 10. Install the translation again (only the translate install part) 11. Check the record details page --> It should be translated!
Created attachment 191483 [details] [review] Bug 41623: Fix translation pickup in catalogue_details.inc This patch redoes the fix that was made in bug 38450 to make sure the "Waiting at ... since ..." string is picked up by the translation tool. It's a parenthesis move. See bug 38450 for explanation. _("This %s is picked").format(foo) _("This %s is NOT picked".format(bar)) To test: 1. Install a new langage gulp po:update --lang fr-CA ./misc/translator/translate install fr-CA 2. Place a hold 3. Check in the item on hold and confirm the hold 4. Go to the record details page --> Waiting at ... since ... is in English 5. Check the translation files cd misc/translator/po/ git grep "Waiting at" fr-CA* --> There is no "Waiting at %s, %s since %s." 6. Apply patch 7. Update strings again 8. Check translation files again --> The string should be there 9. Translate the string (making sure to remove the fuzzy line if any) 10. Install the translation again (only the translate install part) 11. Check the record details page --> It should be translated! Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 191484 [details] [review] Bug 41623: (follow-up) Correct JS variable name This patch fixes the variable name meant to display the circulation desk name when the waiting hold was checked in at a specific circ desk. A revised test plan to test this specific case: - Install a new langage gulp po:update --lang fr-CA ./misc/translator/translate install fr-CA - Log in to the staff client and set your circulation desk - Requires that the UseCirculationDesks preference is enabled and at least one desk is defined in Administration -> Desks. - Place a hold to be picked up at your logged-in library - Check in the item on hold and confirm the hold - Go to the record details page. In the holdings table you should see this under "Status" for that item: --> "Waiting at [library], undefined since [date]." - Check the translation files cd misc/translator/po/ git grep "Waiting at" fr-CA* --> There is no "Waiting at %s, %s since %s." - Apply patch - Update strings again - Check translation files again --> The string should be there - Translate the string (making sure to remove the fuzzy line if any) - Install the translation again (only the translate install part) - Check the record details page again. You should now see: --> "Waiting at [library], [desk] since [date]."
Created attachment 191504 [details] [review] Bug 41623: (follow-up) Correct JS variable name This patch fixes the variable name meant to display the circulation desk name when the waiting hold was checked in at a specific circ desk. A revised test plan to test this specific case: - Install a new langage gulp po:update --lang fr-CA ./misc/translator/translate install fr-CA - Log in to the staff client and set your circulation desk - Requires that the UseCirculationDesks preference is enabled and at least one desk is defined in Administration -> Desks. - Place a hold to be picked up at your logged-in library - Check in the item on hold and confirm the hold - Go to the record details page. In the holdings table you should see this under "Status" for that item: --> "Waiting at [library], undefined since [date]." - Check the translation files cd misc/translator/po/ git grep "Waiting at" fr-CA* --> There is no "Waiting at %s, %s since %s." - Apply patch - Update strings again - Check translation files again --> The string should be there - Translate the string (making sure to remove the fuzzy line if any) - Install the translation again (only the translate install part) - Check the record details page again. You should now see: --> "Waiting at [library], [desk] since [date]." Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Thanks Owen!
Created attachment 191561 [details] [review] Bug 41623: Fix translation pickup in catalogue_details.inc This patch redoes the fix that was made in bug 38450 to make sure the "Waiting at ... since ..." string is picked up by the translation tool. It's a parenthesis move. See bug 38450 for explanation. _("This %s is picked").format(foo) _("This %s is NOT picked".format(bar)) To test: 1. Install a new langage gulp po:update --lang fr-CA ./misc/translator/translate install fr-CA 2. Place a hold 3. Check in the item on hold and confirm the hold 4. Go to the record details page --> Waiting at ... since ... is in English 5. Check the translation files cd misc/translator/po/ git grep "Waiting at" fr-CA* --> There is no "Waiting at %s, %s since %s." 6. Apply patch 7. Update strings again 8. Check translation files again --> The string should be there 9. Translate the string (making sure to remove the fuzzy line if any) 10. Install the translation again (only the translate install part) 11. Check the record details page --> It should be translated! Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 191562 [details] [review] Bug 41623: (follow-up) Correct JS variable name This patch fixes the variable name meant to display the circulation desk name when the waiting hold was checked in at a specific circ desk. A revised test plan to test this specific case: - Install a new langage gulp po:update --lang fr-CA ./misc/translator/translate install fr-CA - Log in to the staff client and set your circulation desk - Requires that the UseCirculationDesks preference is enabled and at least one desk is defined in Administration -> Desks. - Place a hold to be picked up at your logged-in library - Check in the item on hold and confirm the hold - Go to the record details page. In the holdings table you should see this under "Status" for that item: --> "Waiting at [library], undefined since [date]." - Check the translation files cd misc/translator/po/ git grep "Waiting at" fr-CA* --> There is no "Waiting at %s, %s since %s." - Apply patch - Update strings again - Check translation files again --> The string should be there - Translate the string (making sure to remove the fuzzy line if any) - Install the translation again (only the translate install part) - Check the record details page again. You should now see: --> "Waiting at [library], [desk] since [date]." Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Thanks for the quick QA Jonathan!
Nice work everyone! Pushed to main for 26.05