Bugzilla – Attachment 191484 Details for
Bug 41623
Missing translation string in catalogue_detail.inc (again)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 41623: (follow-up) Correct JS variable name
Bug-41623-follow-up-Correct-JS-variable-name.patch (text/plain), 2.93 KB, created by
Owen Leonard
on 2026-01-15 13:20:35 UTC
(
hide
)
Description:
Bug 41623: (follow-up) Correct JS variable name
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2026-01-15 13:20:35 UTC
Size:
2.93 KB
patch
obsolete
>From c49b92f52d45f442303c134c75c29d968b3e5955 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Thu, 15 Jan 2026 08:03:24 -0500 >Subject: [PATCH] Bug 41623: (follow-up) Correct JS variable name > >This patch fixes the variable name meant to display the circulation desk >name when the waiting hold was checked in at a specific circ desk. > >A revised test plan to test this specific case: > >- Install a new langage > gulp po:update --lang fr-CA > ./misc/translator/translate install fr-CA >- Log in to the staff client and set your circulation desk > - Requires that the UseCirculationDesks preference is enabled and at > least one desk is defined in Administration -> Desks. >- Place a hold to be picked up at your logged-in library >- Check in the item on hold and confirm the hold >- Go to the record details page. In the holdings table you should see > this under "Status" for that item: > --> "Waiting at [library], undefined since [date]." >- Check the translation files > cd misc/translator/po/ > git grep "Waiting at" fr-CA* > --> There is no "Waiting at %s, %s since %s." > >- Apply patch >- Update strings again >- Check translation files again > --> The string should be there >- Translate the string (making sure to remove the fuzzy line if any) >- Install the translation again (only the translate install part) >- Check the record details page again. You should now see: > --> "Waiting at [library], [desk] since [date]." >--- > .../en/includes/html_helpers/tables/items/catalogue_detail.inc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc >index 7bd0b733e68..12ef030734e 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc >@@ -596,7 +596,7 @@ > if ( status == 'on_hold') { > if ( row.first_hold.waiting_date ) { > if ( row.first_hold.desk ) { >- nodes += '<span class="waitingat">%s</span>'.format(_("Waiting at %s, %s since %s.").format(row.first_hold._strings.pickup_library_id.str, row.first_hold.desk.desk_name, $date(row.first_hold.waiting_date))); >+ nodes += '<span class="waitingat">%s</span>'.format(_("Waiting at %s, %s since %s.").format(row.first_hold._strings.pickup_library_id.str, row.first_hold.desk.name, $date(row.first_hold.waiting_date))); > } else { > nodes += '<span class="waitingat">%s</span>'.format(_("Waiting at %s since %s.").format(row.first_hold._strings.pickup_library_id.str, $date(row.first_hold.waiting_date))); > } >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 41623
:
191479
|
191483
|
191484
|
191504
|
191561
|
191562