Bugzilla – Attachment 191560 Details for
Bug 41060
Add a value_builder to check if ISSN is valid
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 41060: (QA follow-up) Consistent return for empty string
Bug-41060-QA-follow-up-Consistent-return-for-empty.patch (text/plain), 1.13 KB, created by
Marcel de Rooy
on 2026-01-16 10:40:07 UTC
(
hide
)
Description:
Bug 41060: (QA follow-up) Consistent return for empty string
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2026-01-16 10:40:07 UTC
Size:
1.13 KB
patch
obsolete
>From 4ee2077af236b96646491ba79a98f66582a55d75 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Fri, 16 Jan 2026 11:28:13 +0100 >Subject: [PATCH] Bug 41060: (QA follow-up) Consistent return for empty string >Content-Type: text/plain; charset=utf-8 > >An empty ISBN should not warn just like an empty ISSN. > >Test plan: >Verify that clearing ISBN or ISSN does not warn anymore. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > cataloguing/value_builder/validate_isbn.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/cataloguing/value_builder/validate_isbn.pl b/cataloguing/value_builder/validate_isbn.pl >index 4bc977e239..a67784084f 100755 >--- a/cataloguing/value_builder/validate_isbn.pl >+++ b/cataloguing/value_builder/validate_isbn.pl >@@ -66,7 +66,7 @@ my $launcher = sub { > flagsrequired => { editcatalogue => '*' }, > } > ); >- my $is_valid = valid_isbn_checksum($isbn); >+ my $is_valid = $isbn eq q{} ? 1 : valid_isbn_checksum($isbn); > $template->param( return => $is_valid ); > output_html_with_http_headers $cgi, $cookie, $template->output; > }; >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 41060
:
188200
|
188418
|
190929
|
190930
|
190943
|
190944
|
191557
|
191558
|
191559
| 191560