Bug 41060 - Add a value_builder to check if ISSN is valid
Summary: Add a value_builder to check if ISSN is valid
Status: Failed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Arthur Suzuki
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-10-21 08:53 UTC by Arthur Suzuki
Modified: 2025-10-31 10:41 UTC (History)
2 users (show)

See Also:
GIT URL:
Initiative type: ---
Sponsorship status: ---
Crowdfunding goal: 0
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This enhancement adds a new cataloging plugin (value builder) for validating ISSNs. If you enter an invalid ISSN, a browser pop-up window warns that the ISSN is invalid, but you can ignore this (the field is highlighted in yellow) and still save the record. For new installations, the validate_issn.pl plugin is added to the bibliographic frameworks by default for 022$a (MARC21) or 011$a (UNIMARC). For existing installations, update your frameworks manually.
Version(s) released in:
Circulation function:


Attachments
Bug 41060: Add a cataloguing plugin to check ISSN (4.70 KB, patch)
2025-10-21 08:55 UTC, Arthur Suzuki
Details | Diff | Splinter Review
Bug 41060: Add a cataloguing plugin to check ISSN (4.76 KB, patch)
2025-10-24 16:04 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Arthur Suzuki 2025-10-21 08:53:58 UTC
same as Bug29980 but for ISSN.
Comment 1 Arthur Suzuki 2025-10-21 08:55:45 UTC
Created attachment 188200 [details] [review]
Bug 41060: Add a cataloguing plugin to check ISSN

Test plan:
- without patch login to Koha
- edit a biblio and put a wrong ISSN in 022a (011a for unimarc).
- leave the input field (looses focus), no warning
- apply patch and do "reset_all" to make a full re-install.
- edit the biblio again and put an invalid ISSN in 022a (011a for unimarc).
- when you leave the input field you should have a warning saying "invalid ISSN".
- the input field should turn yellow
- you can still save the biblio with a wrong issn, it is just a warning.
- if you apply the patch on an existing install, you must manually link the value builder to your existing frameworks to get it working.
Comment 2 Owen Leonard 2025-10-24 16:04:15 UTC
Created attachment 188418 [details] [review]
Bug 41060: Add a cataloguing plugin to check ISSN

Test plan:
- without patch login to Koha
- edit a biblio and put a wrong ISSN in 022a (011a for unimarc).
- leave the input field (looses focus), no warning
- apply patch and do "reset_all" to make a full re-install.
- edit the biblio again and put an invalid ISSN in 022a (011a for unimarc).
- when you leave the input field you should have a warning saying
  "invalid ISSN".
- the input field should turn yellow
- you can still save the biblio with a wrong issn, it is just a warning.
- if you apply the patch on an existing install, you must manually link
  the value builder to your existing frameworks to get it working.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Marcel de Rooy 2025-10-31 10:41:27 UTC
Some observations:

If I leave 022 empty, there is a warn about invalid ISSN. Thats weird. Please fix.

If I enter a valid ISSN like 1234-5679, it is ok. If I enter 1234-5679A, it is ok too and that is confusing. If I enter 1234-5679X, it is wrong.
Coming from Business::ISSN. So out of scope ?