Bugzilla – Attachment 191996 Details for
Bug 41689
"Staff note" and "OPAC" message types in patron files untranslatable
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 41689: Make patron message labels translatable
Bug-41689-Make-patron-message-labels-translatable.patch (text/plain), 3.84 KB, created by
Ayoub Glizi-Vicioso
on 2026-01-23 22:08:05 UTC
(
hide
)
Description:
Bug 41689: Make patron message labels translatable
Filename:
MIME Type:
Creator:
Ayoub Glizi-Vicioso
Created:
2026-01-23 22:08:05 UTC
Size:
3.84 KB
patch
obsolete
>From 79b27c93fb840a2ef44a82fd63551a094cfd57fe Mon Sep 17 00:00:00 2001 >From: Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> >Date: Fri, 23 Jan 2026 15:20:28 -0500 >Subject: [PATCH] Bug 41689: Make patron message labels translatable >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >To Test: > >BEFORE APPLYING PATCH: >1- Go to any patron account > Add message >2- Add a message for: "Staff - Internal note" >3- Add a second message for: "OPAC - [NAME OF THE PATRON SELECTED]" > >4- Add any language (I'll use french-Canada, fr-CA, in this case): >From your koha instance, enter on the command line: >./misc/translator/translate install fr-CA > >5- Go to Administration > System preferences > enter language >6- Make sure to check 'Français (fr-CA)' box from the 'StaffInterfaceLanguages'preference and save. > >7- Go back to the specific patron in which you added the messages >8- Switch language to 'Français' (bottom left corner) > >9- Notice that: >--> 'OPAC' is still the same (Since we spell OPAC the same way in both english and french. However, it might not be the case in other languages). >--> 'Staff note' is not translated. > >10- apply patch > >AFTER APPLYING PATCH: > >11 - From you koha instance, enter on the command line: > >./misc/translator/translate update fr-CA > >./misc/translator/translate install fr-CA > >12- Reload patron's page > >13- Notice that 'Staff note' is now translated >** You should see this output: 'Note interne' >--- > .../prog/en/includes/patron_messages.inc | 22 +++++++++++-------- > 1 file changed, 13 insertions(+), 9 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc >index e661464b4a..c5664bfc24 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc >@@ -328,21 +328,25 @@ > <ul> > [% FOREACH patron_message IN patron_messages %] > <li> >- [% SET span_class = '' %] >- [% SET msg_type = 'OPAC' %] >- [% IF(patron_message.message_type == "L") %] >+ [% SET span_class = '' %] >+ [% IF patron_message.message_type == "L" %] > [% span_class = 'circ-hlt' %] >- [% msg_type = 'Staff note' %] > [% END %] > <span class="[% span_class | html %]"> > [% patron_message.message_date | $KohaDates %] >- [% Branches.GetName( patron_message.branchcode ) | html %] >- - [% t(msg_type) | html %] >+ [% Branches.GetName(patron_message.branchcode) | html %] >+ - >+ [% IF patron_message.message_type == 'L' %] >+ <span>Staff note</span> >+ [% ELSE %] >+ <span>OPAC</span> >+ [% END %] >+ > [% IF patron_message.manager_id %] > ( >- <a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% patron_message.manager_id | uri %]" >- >[% patron_message.get_column('manager_firstname') | html %] [% patron_message.get_column('manager_surname') | html %]</a >- > >+ <a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% patron_message.manager_id | uri %]"> >+ [% patron_message.get_column('manager_firstname') | html %] [% patron_message.get_column('manager_surname') | html %] >+ </a> > ) > [% END %] > <em>"[% patron_message.message | html | html_line_break %]"</em> >-- >2.52.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 41689
:
191989
|
191993
|
191996
|
191998