The message types were added by bug 40367, but they are not translatable. To recreate: 1. Go to a patron account > Add message 2. Add a message with "Staff - Internal note" 3. Add a second message with "OPAC - [Name]" 4. Add a language to your Koha gulp po:update --lang fr-CA ./misc/translator/translate install fr-CA Add the language in StaffInterfaceLanguages 5. Switch to the new language 6. Go to the patron's account --> Staff note is in english --> OPAC is in English (this is normal in fr-CA because we still call it OPAC even if it's an english term, but could be different in another language) 7. Check the translation files cd misc/translator/po/ git grep "Staff notes" fr-CA* --> There is nothing from patron-messages.inc
Created attachment 191989 [details] [review] Bug 41689: Make patron message labels translatable
Created attachment 191993 [details] [review] Bug 41689: Make patron message labels translatable To Test: BEFORE APPLYING PATCH: 1- Go to any patron account > Add message 2- Add a message for: "Staff - Internal note" 3- Add a second message for: "OPAC - [NAME OF THE PATRON SELECTED]" ** NOTE: make sure to have the LAST version of the translation file (.po) or it might not work. (from: koha-traductions-main) 4- Add any language (I'll use french-Canada, fr-CA, in this case): From your koha instance, enter on the command line: ./misc/translator/translate install fr-CA 5- Go to Administration > System preferences > enter language 6- Make sure to check 'Français (fr-CA)' box from the 'StaffInterfaceLanguages'preference and save. 7- Go back to the specific patron in which you added the messages 8- Switch language to 'Français' (bottom left corner) 9- Notice that: --> 'OPAC' is still the same (Since we spell OPAC the same way in both english and french. However, it might not be the case in other languages). --> 'Staff note' is not translated. 10- apply patch AFTER APPLYING PATCH: 11 - From you koha instance, enter on the command line: ./misc/translator/translate update fr-CA ./misc/translator/translate install fr-CA 12- Reload patron's page 13- Notice that 'Staff note' is now translated ** You should see this output: 'Note interne'
Created attachment 191996 [details] [review] Bug 41689: Make patron message labels translatable To Test: BEFORE APPLYING PATCH: 1- Go to any patron account > Add message 2- Add a message for: "Staff - Internal note" 3- Add a second message for: "OPAC - [NAME OF THE PATRON SELECTED]" 4- Add any language (I'll use french-Canada, fr-CA, in this case): From your koha instance, enter on the command line: ./misc/translator/translate install fr-CA 5- Go to Administration > System preferences > enter language 6- Make sure to check 'Français (fr-CA)' box from the 'StaffInterfaceLanguages'preference and save. 7- Go back to the specific patron in which you added the messages 8- Switch language to 'Français' (bottom left corner) 9- Notice that: --> 'OPAC' is still the same (Since we spell OPAC the same way in both english and french. However, it might not be the case in other languages). --> 'Staff note' is not translated. 10- apply patch AFTER APPLYING PATCH: 11 - From you koha instance, enter on the command line: ./misc/translator/translate update fr-CA ./misc/translator/translate install fr-CA 12- Reload patron's page 13- Notice that 'Staff note' is now translated ** You should see this output: 'Note interne'
Created attachment 191998 [details] [review] Bug 41689: Make patron message labels translatable To Test: BEFORE APPLYING PATCH: 1- Go to any patron account > Add message 2- Add a message for: "Staff - Internal note" 3- Add a second message for: "OPAC - [NAME OF THE PATRON SELECTED]" 4- Add any language (I'll use french-Canada, fr-CA, in this case): From your koha instance, enter on the command line: ./misc/translator/translate install fr-CA 5- Go to Administration > System preferences > enter language 6- Make sure to check 'Français (fr-CA)' box from the 'StaffInterfaceLanguages'preference and save. 7- Go back to the specific patron in which you added the messages 8- Switch language to 'Français' (bottom left corner) 9- Notice that: --> 'OPAC' is still the same (Since we spell OPAC the same way in both english and french. However, it might not be the case in other languages). --> 'Staff note' is not translated. 10- apply patch AFTER APPLYING PATCH: 11 - From you koha instance, enter on the command line: ./misc/translator/translate update fr-CA ./misc/translator/translate install fr-CA 12- Reload patron's page 13- Notice that 'Staff note' is now translated ** You should see this output: 'Note interne' Signed-off-by: David Nind <david@davidnind.com>