Bugzilla – Attachment 19252 Details for
Bug 10511
Odd behavior for messaging preferences with Talking Tech enabled
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 10511 - Odd behavior for messaging preferences with Talking Tech enabled
Bug-10511---Odd-behavior-for-messaging-preferences.patch (text/plain), 2.71 KB, created by
Kyle M Hall (khall)
on 2013-06-26 20:43:49 UTC
(
hide
)
Description:
Bug 10511 - Odd behavior for messaging preferences with Talking Tech enabled
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2013-06-26 20:43:49 UTC
Size:
2.71 KB
patch
obsolete
>From 556b9250a760252cbc456807d7cbe939f0f9221f Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Wed, 26 Jun 2013 16:40:09 -0400 >Subject: [PATCH] Bug 10511 - Odd behavior for messaging preferences with Talking Tech enabled > >An error in the onclick for phone notices causes the "Do not notify" >checkbox to be checked when the phone checkbox is checked. Also, >checking "Do not notify" does not uncheck the phone checkbox. > >Test plan: >1) Enable TalkingTechItivaPhoneNotification >2) Browse to the new patron screen ( memberentry.pl ) >3) In the patron messaging preferences check the Phone checkbox >4) Not the "do not notify" checkbox is then checked >5) Uncheck the "do not notify" checkbox, and check the Email checkbox as well >6) Now check the "do not notify" checkbox, note the Phone checkbox remains checked >7) Apply this patch >8) Repeat steps 3-6, noting the odd behavior is no longer present >--- > .../prog/en/includes/messaging-preference-form.inc | 5 +++-- > 1 files changed, 3 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/messaging-preference-form.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/messaging-preference-form.inc >index ed6b067..367969d 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/messaging-preference-form.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/messaging-preference-form.inc >@@ -7,6 +7,7 @@ > newid = Number(rowid.replace("none","")) > $("#sms"+newid).removeAttr("checked"); > $("#email"+newid).removeAttr("checked"); >+ $("#phone"+newid).removeAttr("checked"); > $("#digest"+newid).removeAttr("checked"); > $("#rss"+newid).removeAttr("checked"); > } >@@ -99,12 +100,12 @@ > <input type="checkbox" > id="phone[% messaging_preference.message_attribute_id %]" > name="[% messaging_preference.message_attribute_id %]" >- value="phone" checked="checked" onclick = "$('#none'+'[% messaging_preference.message_attribute_id %]').attr('checked','');" /> >+ value="phone" checked="checked" onclick = "$('#none'+'[% messaging_preference.message_attribute_id %]').removeAttr('checked','');" /> > [% ELSE %] > <input type="checkbox" > id="phone[% messaging_preference.message_attribute_id %]" > name="[% messaging_preference.message_attribute_id %]" >- value="phone" onclick = "$('#none'+'[% messaging_preference.message_attribute_id %]').attr('checked','');" /> >+ value="phone" onclick = "$('#none'+'[% messaging_preference.message_attribute_id %]').removeAttr('checked','');" /> > [% END %] > [% END %] > </td>[% END %] >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10511
:
19252
|
19783
|
19850
|
20271
|
20272