Bugzilla – Attachment 192889 Details for
Bug 10190
Overdue notice triggers based on item type
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 10190: refactor: remove redundant try..catch
Bug-10190-refactor-remove-redundant-trycatch.patch (text/plain), 5.82 KB, created by
ChloƩ Zermatten
on 2026-02-10 13:08:13 UTC
(
hide
)
Description:
Bug 10190: refactor: remove redundant try..catch
Filename:
MIME Type:
Creator:
ChloƩ Zermatten
Created:
2026-02-10 13:08:13 UTC
Size:
5.82 KB
patch
obsolete
>From 2a651c67cb398db595239d98b8428cb623c3de76 Mon Sep 17 00:00:00 2001 >From: Chloe Zermatten <chloe.zermatten@openfifth.co.uk> >Date: Wed, 4 Feb 2026 18:08:10 +0000 >Subject: [PATCH] Bug 10190: refactor: remove redundant try..catch > >--- > .../prog/js/vue/stores/circulation-rules.js | 83 ++++++------------- > 1 file changed, 27 insertions(+), 56 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/stores/circulation-rules.js b/koha-tmpl/intranet-tmpl/prog/js/vue/stores/circulation-rules.js >index 56f03894135..3594fe63aa9 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/vue/stores/circulation-rules.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/stores/circulation-rules.js >@@ -362,11 +362,8 @@ export const useCircRulesStore = defineStore("circRules", () => { > }, > async setAllRawRuleSets() { > const client = APIClient.circRule; >- try { >- await this.getAllRawRuleSets(); >- } catch (e) { >- //TODO: handle e >- } >+ await this.getAllRawRuleSets(); >+ > this.currentAndDefaultRawRuleSets = [ > ...this.allCurrentLibraryRawRuleSets, > ...this.allDefaultLibraryRawRuleSets, >@@ -399,20 +396,14 @@ export const useCircRulesStore = defineStore("circRules", () => { > }, > async getAllRawRuleSets() { > const client = APIClient.circRule; >- try { >- this.allDefaultLibraryRawRuleSets = >- await client.circ_rules.getAll( >- {}, >- { library_id: "*", effective: false } >- ); >- this.allCurrentLibraryRawRuleSets = >- await client.circ_rules.getAll( >- {}, >- { library_id: this.currentLibraryId, effective: false } >- ); >- } catch (e) { >- throw e; >- } >+ this.allDefaultLibraryRawRuleSets = await client.circ_rules.getAll( >+ {}, >+ { library_id: "*", effective: false } >+ ); >+ this.allCurrentLibraryRawRuleSets = await client.circ_rules.getAll( >+ {}, >+ { library_id: this.currentLibraryId, effective: false } >+ ); > }, > async getConfigurationOptions() { > const client = APIClient.circRule; >@@ -421,12 +412,8 @@ export const useCircRulesStore = defineStore("circRules", () => { > }, > async getItemTypes() { > const client = APIClient.item; >- let itemTypes = []; >- try { >- itemTypes = await client.item_types.getAll(); >- } catch (e) { >- // TODO: handle e >- } >+ let itemTypes = await client.item_types.getAll(); >+ > itemTypes.unshift({ > item_type_id: "*", > description: $__("Default rule for all item types"), >@@ -436,11 +423,8 @@ export const useCircRulesStore = defineStore("circRules", () => { > async getLibraries() { > const client = APIClient.library; > let libraries = []; >- try { >- libraries = await client.libraries.getAll(); >- } catch (e) { >- // TODO: handle e >- } >+ libraries = await client.libraries.getAll(); >+ > libraries.unshift({ > library_id: "*", > name: $__("Default rule for all libraries"), >@@ -449,12 +433,8 @@ export const useCircRulesStore = defineStore("circRules", () => { > }, > async getPatronCategories() { > const client = APIClient.patron; >- let patronCategories = []; >- try { >- patronCategories = await client.categories.getAll(); >- } catch (e) { >- // TODO: handle e >- } >+ let patronCategories = await client.categories.getAll(); >+ > patronCategories.unshift({ > patron_category_id: "*", > name: $__("Default rule for all categories"), >@@ -466,20 +446,15 @@ export const useCircRulesStore = defineStore("circRules", () => { > context.library_id = "*"; > } > const client = APIClient.circRule; >- let result; >- try { >- result = await client.circ_rules.getAll( >- {}, >- { >- library_id: context.library_id, >- patron_category_id: context.patron_category_id, >- item_type_id: context.item_type_id, >- effective, >- } >- ); >- } catch (e) { >- throw e; >- } >+ const result = await client.circ_rules.getAll( >+ {}, >+ { >+ library_id: context.library_id, >+ patron_category_id: context.patron_category_id, >+ item_type_id: context.item_type_id, >+ effective, >+ } >+ ); > return result[0] ?? null; > }, > async updateCircRuleSets(existingRuleSet, triggerNumber) { >@@ -494,12 +469,8 @@ export const useCircRulesStore = defineStore("circRules", () => { > existingRuleSet[`overdue_${triggerNumber}_mtt`]; > circRuleSet[`overdue_${triggerNumber}_has_rules`] = > existingRuleSet[`overdue_${triggerNumber}_has_rules`]; >- try { >- const client = APIClient.circRule; >- await client.circ_rules.update(circRuleSet); >- } catch (e) { >- //TODO: handle e >- } >+ const client = APIClient.circRule; >+ await client.circ_rules.update(circRuleSet); > }, > ...permissionsActions(store), > }; >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10190
:
170357
|
170358
|
170359
|
170360
|
170361
|
170362
|
170363
|
170364
|
170365
|
170366
|
170367
|
170368
|
170369
|
170370
|
170371
|
170372
|
170373
|
170374
|
170375
|
170376
|
170380
|
170449
|
171727
|
171728
|
171729
|
171730
|
171731
|
171732
|
171733
|
171734
|
171735
|
171736
|
171737
|
171738
|
171739
|
171740
|
171741
|
171742
|
171743
|
171744
|
171745
|
171746
|
171747
|
171748
|
171749
|
171750
|
171751
|
171752
|
171753
|
171754
|
171755
|
172588
|
172589
|
172590
|
172591
|
172592
|
172593
|
172594
|
172595
|
172596
|
172597
|
172598
|
172599
|
172600
|
172601
|
172602
|
172603
|
172604
|
172605
|
172606
|
172607
|
172608
|
172609
|
172612
|
172614
|
172617
|
172619
|
172621
|
172622
|
172623
|
172624
|
172625
|
172626
|
172630
|
172631
|
172632
|
172633
|
172634
|
172635
|
172636
|
172637
|
172638
|
172639
|
172640
|
172641
|
172642
|
172643
|
172644
|
172645
|
172646
|
172647
|
172648
|
172649
|
172650
|
172651
|
172652
|
172653
|
172654
|
172655
|
172656
|
172657
|
172658
|
172659
|
172660
|
172661
|
172662
|
172663
|
178643
|
178644
|
178645
|
178646
|
178647
|
178648
|
178649
|
178650
|
178651
|
178652
|
178653
|
178654
|
178655
|
178656
|
178657
|
178658
|
178659
|
178660
|
178661
|
178662
|
178663
|
178664
|
178665
|
178666
|
178667
|
178668
|
178669
|
178670
|
178671
|
178672
|
178673
|
178674
|
178675
|
188075
|
188076
|
188077
|
188078
|
188079
|
188080
|
188081
|
188082
|
188083
|
188084
|
188085
|
188086
|
188087
|
188088
|
188476
|
189345
|
189863
|
189864
|
189865
|
189866
|
189867
|
189868
|
191749
|
191750
|
191751
|
191752
|
191753
|
191754
|
191755
|
191756
|
191757
|
191758
|
191759
|
191760
|
191761
|
191762
|
191763
|
191795
|
191796
|
191805
|
191854
|
191873
|
192871
|
192872
|
192873
|
192874
|
192875
|
192876
|
192877
|
192878
|
192879
|
192880
|
192881
|
192882
|
192883
|
192884
|
192885
|
192886
|
192887
|
192888
| 192889 |
192890
|
192891
|
192892
|
192893
|
192894
|
192895
|
192896
|
192897
|
192898
|
192899