Bug 10190 - Overdue notice triggers based on item type
Summary: Overdue notice triggers based on item type
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Notices (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Martin Renvoize (ashimema)
QA Contact:
URL: https://docs.google.com/document/d/1N...
Keywords: Hackfest, roadmap_24_11, roadmap_25_05
Depends on: 36641 37256
Blocks: 38135
  Show dependency treegraph
 
Reported: 2013-05-03 21:47 UTC by Melia Meggs
Modified: 2025-03-20 10:56 UTC (History)
22 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 10190: DB migration for overduerules (11.68 KB, patch)
2024-08-15 11:36 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Fix unit test to exclude _X_ rules (973 bytes, patch)
2024-08-15 11:36 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Add support for incrementable circulation rules (5.21 KB, patch)
2024-08-15 11:36 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Add a vue app for circulation triggers (16.63 KB, patch)
2024-08-15 11:36 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Add components to list/add and edit circulation triggers (42.46 KB, patch)
2024-08-15 11:36 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Add a library API client (2.71 KB, patch)
2024-08-15 11:36 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Add itemtypes and patron categories to the item/patron api clients (2.04 KB, patch)
2024-08-15 11:36 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Let the circulation_rules endpoint accept query parameters (1.87 KB, patch)
2024-08-15 11:36 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Update GetBranchcodesWithOverdueRules to use CirculationRules (5.72 KB, patch)
2024-08-15 11:36 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Update overdue_notices script to refer to circ rules (11.00 KB, patch)
2024-08-15 11:36 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Add itemtype handling to overdue_notices script (39.48 KB, patch)
2024-08-15 11:37 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Update has_restricting_overdues to refer to circulation rules (7.22 KB, patch)
2024-08-15 11:37 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Add letter names to tables (4.60 KB, patch)
2024-08-15 11:37 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Set tab based on trigger edited/created (2.92 KB, patch)
2024-08-15 11:37 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Add fallback to 'Default' text for notice (1.21 KB, patch)
2024-08-15 11:37 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Migrate MarkIssueReturned test to circulation rules (4.19 KB, patch)
2024-08-15 11:37 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Remove old overduerules interface (34.31 KB, patch)
2024-08-15 11:37 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Drop overduerules and overduerules_transport_types (4.28 KB, patch)
2024-08-15 11:52 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: DBIC Schema update (8.82 KB, patch)
2024-08-15 11:54 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Remove OverdueRule Koha Objects (2.79 KB, patch)
2024-08-15 11:56 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Update itiva script to reflect move to circ_rules (4.62 KB, patch)
2024-08-15 13:37 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Add comments to overdue_notices and rename variable (5.02 KB, patch)
2024-08-16 13:09 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: DB migration for overduerules (15.65 KB, patch)
2024-09-19 13:20 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: DBIC Schema update (8.82 KB, patch)
2024-09-19 13:20 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Remove OverdueRule Koha Objects (2.79 KB, patch)
2024-09-19 13:20 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Fix unit test to exclude _X_ rules (973 bytes, patch)
2024-09-19 13:20 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Add support for incrementable circulation rules (5.21 KB, patch)
2024-09-19 13:20 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Add a vue app for circulation triggers (16.63 KB, patch)
2024-09-19 13:20 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Add components to list/add and edit circulation triggers (42.46 KB, patch)
2024-09-19 13:20 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Add a library API client (2.71 KB, patch)
2024-09-19 13:20 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Add itemtypes and patron categories to the item/patron api clients (2.04 KB, patch)
2024-09-19 13:20 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Let the circulation_rules endpoint accept query parameters (1.87 KB, patch)
2024-09-19 13:20 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Update GetBranchcodesWithOverdueRules to use CirculationRules (5.72 KB, patch)
2024-09-19 13:20 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Update overdue_notices script to refer to circ rules (11.00 KB, patch)
2024-09-19 13:20 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Add itemtype handling to overdue_notices script (39.48 KB, patch)
2024-09-19 13:20 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Update has_restricting_overdues to refer to circulation rules (7.22 KB, patch)
2024-09-19 13:21 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Add letter names to tables (4.60 KB, patch)
2024-09-19 13:21 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Set tab based on trigger edited/created (2.92 KB, patch)
2024-09-19 13:21 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Add fallback to 'Default' text for notice (1.21 KB, patch)
2024-09-19 13:21 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Migrate MarkIssueReturned test to circulation rules (4.19 KB, patch)
2024-09-19 13:21 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Remove old overduerules interface (34.32 KB, patch)
2024-09-19 13:21 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Update itiva script to reflect move to circ_rules (4.63 KB, patch)
2024-09-19 13:21 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Add comments to overdue_notices and rename variable (5.02 KB, patch)
2024-09-19 13:21 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Rework logic of overdue_notices (53.32 KB, patch)
2024-09-19 13:21 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Display effective values and highlight them (14.13 KB, patch)
2024-09-19 13:21 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Restore 'edit' from 'Add/Edit' Modal (1.83 KB, patch)
2024-09-19 13:21 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Modal form improvements (32.54 KB, patch)
2024-09-19 13:21 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Add custom input for delay (40.83 KB, patch)
2024-09-19 13:21 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Clarify workflow (8.10 KB, patch)
2024-09-19 13:21 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Update for bootstrap 5 (5.24 KB, patch)
2024-09-19 13:21 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Rebase for rspack (838 bytes, patch)
2024-09-19 13:22 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: DB migration for overduerules (15.65 KB, patch)
2024-10-10 14:39 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: DBIC Schema update (8.82 KB, patch)
2024-10-10 14:39 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Remove OverdueRule Koha Objects (2.79 KB, patch)
2024-10-10 14:39 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Fix unit test to exclude _X_ rules (973 bytes, patch)
2024-10-10 14:39 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Add support for incrementable circulation rules (5.21 KB, patch)
2024-10-10 14:39 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Add a vue app for circulation triggers (16.63 KB, patch)
2024-10-10 14:39 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Add components to list/add and edit circulation triggers (42.46 KB, patch)
2024-10-10 14:39 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Add a library API client (2.71 KB, patch)
2024-10-10 14:39 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Add itemtypes and patron categories to the item/patron api clients (2.04 KB, patch)
2024-10-10 14:39 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Let the circulation_rules endpoint accept query parameters (1.87 KB, patch)
2024-10-10 14:39 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Update GetBranchcodesWithOverdueRules to use CirculationRules (5.72 KB, patch)
2024-10-10 14:39 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Update overdue_notices script to refer to circ rules (11.00 KB, patch)
2024-10-10 14:39 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Add itemtype handling to overdue_notices script (39.48 KB, patch)
2024-10-10 14:39 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Update has_restricting_overdues to refer to circulation rules (7.22 KB, patch)
2024-10-10 14:39 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Add letter names to tables (4.60 KB, patch)
2024-10-10 14:40 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Set tab based on trigger edited/created (2.92 KB, patch)
2024-10-10 14:40 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Add fallback to 'Default' text for notice (1.21 KB, patch)
2024-10-10 14:40 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Migrate MarkIssueReturned test to circulation rules (4.19 KB, patch)
2024-10-10 14:40 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Remove old overduerules interface (34.32 KB, patch)
2024-10-10 14:40 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Update itiva script to reflect move to circ_rules (4.63 KB, patch)
2024-10-10 14:40 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Add comments to overdue_notices and rename variable (5.02 KB, patch)
2024-10-10 14:40 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Rework logic of overdue_notices (53.32 KB, patch)
2024-10-10 14:40 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Display effective values and highlight them (14.13 KB, patch)
2024-10-10 14:40 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Restore 'edit' from 'Add/Edit' Modal (1.83 KB, patch)
2024-10-10 14:40 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Modal form improvements (32.54 KB, patch)
2024-10-10 14:40 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Add custom input for delay (40.83 KB, patch)
2024-10-10 14:40 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Clarify workflow (8.10 KB, patch)
2024-10-10 14:40 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Update for bootstrap 5 (5.24 KB, patch)
2024-10-10 14:40 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Rebase for rspack (838 bytes, patch)
2024-10-10 14:40 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Rename 'All *' to 'Default rule for *' (3.65 KB, patch)
2024-10-10 14:41 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Take DefaultToLoggedInLibraryOverdueTriggers into account (2.50 KB, patch)
2024-10-10 14:41 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Only display default and library specific letters (4.03 KB, patch)
2024-10-10 14:41 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Display value of OverdueNoticeFrom in note (2.08 KB, patch)
2024-10-10 16:13 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: DB migration for overduerules (15.77 KB, patch)
2024-10-10 16:19 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: DBIC Schema update (8.98 KB, patch)
2024-10-10 16:19 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Remove OverdueRule Koha Objects (2.95 KB, patch)
2024-10-10 16:19 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Fix unit test to exclude _X_ rules (1.07 KB, patch)
2024-10-10 16:19 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Add support for incrementable circulation rules (5.33 KB, patch)
2024-10-10 16:19 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Add a vue app for circulation triggers (16.74 KB, patch)
2024-10-10 16:19 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Add components to list/add and edit circulation triggers (42.57 KB, patch)
2024-10-10 16:19 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Add a library API client (2.83 KB, patch)
2024-10-10 16:19 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Add itemtypes and patron categories to the item/patron api clients (2.16 KB, patch)
2024-10-10 16:20 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Let the circulation_rules endpoint accept query parameters (1.99 KB, patch)
2024-10-10 16:20 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Update GetBranchcodesWithOverdueRules to use CirculationRules (5.84 KB, patch)
2024-10-10 16:20 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Update overdue_notices script to refer to circ rules (11.11 KB, patch)
2024-10-10 16:20 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Add itemtype handling to overdue_notices script (39.59 KB, patch)
2024-10-10 16:20 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Update has_restricting_overdues to refer to circulation rules (7.34 KB, patch)
2024-10-10 16:20 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Add letter names to tables (4.72 KB, patch)
2024-10-10 16:20 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Set tab based on trigger edited/created (3.04 KB, patch)
2024-10-10 16:20 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Add fallback to 'Default' text for notice (1.33 KB, patch)
2024-10-10 16:20 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Migrate MarkIssueReturned test to circulation rules (4.31 KB, patch)
2024-10-10 16:20 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Remove old overduerules interface (34.44 KB, patch)
2024-10-10 16:20 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Update itiva script to reflect move to circ_rules (4.79 KB, patch)
2024-10-10 16:20 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Add comments to overdue_notices and rename variable (5.18 KB, patch)
2024-10-10 16:20 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Rework logic of overdue_notices (53.48 KB, patch)
2024-10-10 16:20 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Display effective values and highlight them (14.29 KB, patch)
2024-10-10 16:20 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Restore 'edit' from 'Add/Edit' Modal (1.99 KB, patch)
2024-10-10 16:21 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Modal form improvements (32.70 KB, patch)
2024-10-10 16:21 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Add custom input for delay (40.99 KB, patch)
2024-10-10 16:21 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Clarify workflow (8.26 KB, patch)
2024-10-10 16:21 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Update for bootstrap 5 (5.40 KB, patch)
2024-10-10 16:21 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Rebase for rspack (1002 bytes, patch)
2024-10-10 16:21 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Rename 'All *' to 'Default rule for *' (3.81 KB, patch)
2024-10-10 16:21 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Take DefaultToLoggedInLibraryOverdueTriggers into account (2.66 KB, patch)
2024-10-10 16:21 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Only display default and library specific letters (4.19 KB, patch)
2024-10-10 16:21 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Display value of OverdueNoticeFrom in note (2.24 KB, patch)
2024-10-10 16:21 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: DB migration for overduerules (15.85 KB, patch)
2025-02-25 11:56 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: DBIC Schema update (9.12 KB, patch)
2025-02-25 11:56 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Remove OverdueRule Koha Objects (2.95 KB, patch)
2025-02-25 11:56 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Fix unit test to exclude _X_ rules (1.07 KB, patch)
2025-02-25 11:57 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Add support for incrementable circulation rules (5.31 KB, patch)
2025-02-25 11:57 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Add a vue app for circulation triggers (17.11 KB, patch)
2025-02-25 11:57 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Add components to list/add and edit circulation triggers (42.72 KB, patch)
2025-02-25 11:57 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Add a library API client (2.98 KB, patch)
2025-02-25 11:57 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Add itemtypes and patron categories to the item/patron api clients (2.16 KB, patch)
2025-02-25 11:57 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Let the circulation_rules endpoint accept query parameters (1.96 KB, patch)
2025-02-25 11:57 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Update GetBranchcodesWithOverdueRules to use CirculationRules (5.14 KB, patch)
2025-02-25 11:57 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Update overdue_notices script to refer to circ rules (9.48 KB, patch)
2025-02-25 11:57 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Add itemtype handling to overdue_notices script (38.82 KB, patch)
2025-02-25 11:57 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Update has_restricting_overdues to refer to circulation rules (7.37 KB, patch)
2025-02-25 11:57 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Add letter names to tables (4.73 KB, patch)
2025-02-25 11:57 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Set tab based on trigger edited/created (3.04 KB, patch)
2025-02-25 11:57 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Add fallback to 'Default' text for notice (1.33 KB, patch)
2025-02-25 11:57 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Migrate MarkIssueReturned test to circulation rules (3.78 KB, patch)
2025-02-25 11:57 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Remove old overduerules interface (34.01 KB, patch)
2025-02-25 11:58 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Update itiva script to reflect move to circ_rules (4.37 KB, patch)
2025-02-25 11:58 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Add comments to overdue_notices and rename variable (5.18 KB, patch)
2025-02-25 11:58 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Rework logic of overdue_notices (42.81 KB, patch)
2025-02-25 11:58 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Display effective values and highlight them (15.94 KB, patch)
2025-02-25 11:58 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Restore 'edit' from 'Add/Edit' Modal (2.07 KB, patch)
2025-02-25 11:58 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Modal form improvements (36.79 KB, patch)
2025-02-25 11:58 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Add custom input for delay (19.19 KB, patch)
2025-02-25 11:58 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Clarify workflow (8.03 KB, patch)
2025-02-25 11:58 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Update for bootstrap 5 (5.40 KB, patch)
2025-02-25 11:58 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Rebase for rspack (1002 bytes, patch)
2025-02-25 11:58 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Rename 'All *' to 'Default rule for *' (3.82 KB, patch)
2025-02-25 11:58 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Take DefaultToLoggedInLibraryOverdueTriggers into account (2.80 KB, patch)
2025-02-25 11:58 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Only display default and library specific letters (4.20 KB, patch)
2025-02-25 11:58 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 10190: Display value of OverdueNoticeFrom in note (2.36 KB, patch)
2025-02-25 11:59 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Melia Meggs 2013-05-03 21:47:34 UTC
Many libraries in my system lend DVDs out for a shorter period than their normal checkout period, like 2 days versus 14 or 21 days for other items. They also charge larger fines on DVDs than other items. They would like to be able to generate overdue notices for DVDs on the first day overdue, unlike the first notice generation of 7 days on their other items. 

So this is an enhancement request to allow libraries to generate an overdue notice for a particular item type separate from the three notice triggers.
Comment 1 Barton Chittenden 2015-08-18 03:51:32 UTC
This is standard behavior now, right?
Comment 2 Katrin Fischer 2015-08-23 19:42:50 UTC
Right now we can only set the overdue notices by patron category, but we can't differentiate by item type. I think this is still valid.
Comment 3 Amy Voorhees 2017-12-04 19:43:56 UTC
Here in 2017 still wishing for greater flexibility for overdue notices based on Item Type, not only Patron Category -- in our case (school library) for better communication about items on Reserve (in our case loan period is 2 hours).
Comment 4 Marjorie Barry-Vila 2022-02-25 18:16:05 UTC
+1
Comment 5 Eileen Chandler 2022-12-05 21:09:24 UTC
This is important in our consortium of mainly public libraries as our Library of Things (LoT) items go out for shorter periods of time and are overdue on a different time schedule to regular items like books.  We would like overdues to be based on item type not just patron type. We also have one college member library in our consortium and their items go out on for different time periods again based on Item type not just patron type.
Comment 6 Koha collecto 2024-05-31 19:26:56 UTC
+1
Comment 7 Martin Renvoize (ashimema) 2024-08-08 08:22:12 UTC
Matt and I are working on this together.. we're not too far off submitting code as per the spec above.. getting the API patches linked above through would certainly help it keep marching forward.
Comment 8 Martin Renvoize (ashimema) 2024-08-15 11:36:28 UTC
Created attachment 170357 [details] [review]
Bug 10190: DB migration for overduerules

This patch adds the data migration for overduerules to circulation
rules.

We attempt to create the default rules based on most commonly occuring
rule values and then add overrides for all other rule values we find.

Sponsored-by: Glasgow Colleges Library Group
Comment 9 Martin Renvoize (ashimema) 2024-08-15 11:36:31 UTC
Created attachment 170358 [details] [review]
Bug 10190: Fix unit test to exclude _X_ rules

Sponsored-by: Glasgow Colleges Library Group
Comment 10 Martin Renvoize (ashimema) 2024-08-15 11:36:34 UTC
Created attachment 170359 [details] [review]
Bug 10190: Add support for incrementable circulation rules

This patch adds support for _X_ grouped circulation rules to both the
internal and external API's for handling circulation rules.

This allows us to group overdue_X_rulename rules by an 'X' integer so we
can have triggers incremented and grouped together.

We also add the new overdue_x_* rule definition here for overdue trigger
rules.

Sponsored-by: Glasgow Colleges Library Group
Comment 11 Martin Renvoize (ashimema) 2024-08-15 11:36:38 UTC
Created attachment 170360 [details] [review]
Bug 10190: Add a vue app for circulation triggers

This patch adds a new vue based page for administering circulation
triggers.  This aims to replace the 'Overdue notice/status triggers'
page available from Tools.

The new page is available from Koha administration > Circulation triggers

Sponsored-by: Glasgow Colleges Library Group
Comment 12 Martin Renvoize (ashimema) 2024-08-15 11:36:41 UTC
Created attachment 170361 [details] [review]
Bug 10190: Add components to list/add and edit circulation triggers

These new components are used by the new 'Circulation triggers'
administration page to display existing trigger rules and add the
ability to add new rules and edit existing ones.

Sponsored-by: Glasgow Colleges Library Group
Comment 13 Martin Renvoize (ashimema) 2024-08-15 11:36:45 UTC
Created attachment 170362 [details] [review]
Bug 10190: Add a library API client

This patch adds a library api client to the vue ecosystem for later use
in the Circulation triggers page.

Sponsored-by: Glasgow Colleges Library Group
Comment 14 Martin Renvoize (ashimema) 2024-08-15 11:36:48 UTC
Created attachment 170363 [details] [review]
Bug 10190: Add itemtypes and patron categories to the item/patron api clients

This patch adds patron and itemtype api clients for the Vue ecosystem

Sponsored-by: Glasgow Colleges Library Group
Comment 15 Martin Renvoize (ashimema) 2024-08-15 11:36:51 UTC
Created attachment 170364 [details] [review]
Bug 10190: Let the circulation_rules endpoint accept query parameters

Sponsored-by: Glasgow Colleges Library Group
Comment 16 Martin Renvoize (ashimema) 2024-08-15 11:36:55 UTC
Created attachment 170365 [details] [review]
Bug 10190: Update GetBranchcodesWithOverdueRules to use CirculationRules

This patch updates the C4::Overdues method
GetBranchecodesWithOverdueRules to refer to the new location of these
rules in the circulation rules table. We also update the unit tests to
move the mocked data into the right location.

We could perhaps migrate this method in Koha::CirculationRules at a
later date?

Sponsored-by: Glasgow Colleges Library Group
Comment 17 Martin Renvoize (ashimema) 2024-08-15 11:36:58 UTC
Created attachment 170366 [details] [review]
Bug 10190: Update overdue_notices script to refer to circ rules

This patch updates the overdue_notices cron script to refer to the new
location for overdue rules found in the circulation rules table now.

Sponsored-by: Glasgow Colleges Library Group
Comment 18 Martin Renvoize (ashimema) 2024-08-15 11:37:01 UTC
Created attachment 170367 [details] [review]
Bug 10190: Add itemtype handling to overdue_notices script

This patch enhances the overdue_notices script to understand the newly
introduced itemtype level for overdue rules.

Sponsored-by: Glasgow Colleges Library Group
Comment 19 Martin Renvoize (ashimema) 2024-08-15 11:37:05 UTC
Created attachment 170368 [details] [review]
Bug 10190: Update has_restricting_overdues to refer to circulation rules

This patch updates the Koha::Patron->has_restriction_overdues method to
refer to the migrated overdue rules.

We also correct an oversight in the method prior to this patch that
meant that not all overdues were being correctly checked for a
restriction.. we were incorrectly filtering to only overdues at the
current checkin branch.

Finally, we also take account of the itemtype level addition here too.

NOTE: There weren't any unit tests for this Koha::Patron method.. we
should add some here!

Sponsored-by: Glasgow Colleges Library Group
Comment 20 Martin Renvoize (ashimema) 2024-08-15 11:37:08 UTC
Created attachment 170369 [details] [review]
Bug 10190: Add letter names to tables

Sponsored-by: Glasgow Colleges Library Group
Comment 21 Martin Renvoize (ashimema) 2024-08-15 11:37:11 UTC
Created attachment 170370 [details] [review]
Bug 10190: Set tab based on trigger edited/created

Sponsored-by: Glasgow Colleges Library Group
Comment 22 Martin Renvoize (ashimema) 2024-08-15 11:37:14 UTC
Created attachment 170371 [details] [review]
Bug 10190: Add fallback to 'Default' text for notice

Sponsored-by: Glasgow Colleges Library Group
Comment 23 Martin Renvoize (ashimema) 2024-08-15 11:37:17 UTC
Created attachment 170372 [details] [review]
Bug 10190: Migrate MarkIssueReturned test to circulation rules

Sponsored-by: Glasgow Colleges Library Group
Comment 24 Martin Renvoize (ashimema) 2024-08-15 11:37:21 UTC
Created attachment 170373 [details] [review]
Bug 10190: Remove old overduerules interface

This patch updates the link from the tools homepage to open the new
circulation triggers administration page.

We then remove the old overduerules controller and template, and finally
we drop the no longer referenced
C4::Overdues::GetOverdueMessageTransportTypes method and associated unit
tests.

Sponsored-by: Glasgow Colleges Library Group
Comment 25 Martin Renvoize (ashimema) 2024-08-15 11:39:07 UTC
This is going to be fun to test..

Matt and I worked hard together on it, so whilst it's assigned to me we're both available to comment.

I'm happy to walk through intentions in a Jistsi or whatever.. reach out on chat.koha-community.org if you want any guidance.
Comment 26 Martin Renvoize (ashimema) 2024-08-15 11:52:38 UTC
Created attachment 170374 [details] [review]
Bug 10190: Drop overduerules and overduerules_transport_types
Comment 27 Martin Renvoize (ashimema) 2024-08-15 11:54:11 UTC
Created attachment 170375 [details] [review]
Bug 10190: DBIC Schema update
Comment 28 Martin Renvoize (ashimema) 2024-08-15 11:56:01 UTC
Created attachment 170376 [details] [review]
Bug 10190: Remove OverdueRule Koha Objects
Comment 29 Martin Renvoize (ashimema) 2024-08-15 13:37:45 UTC
Created attachment 170380 [details] [review]
Bug 10190: Update itiva script to reflect move to circ_rules
Comment 30 Martin Renvoize (ashimema) 2024-08-15 13:38:48 UTC
Whilst I've updated the itiva script to reflect the move to circulation rules.. I've not got any way to really test this.

We also need to expose itiva in the new admin page.. I'm going to ask Matt to take a look at that.
Comment 31 Martin Renvoize (ashimema) 2024-08-16 13:09:52 UTC
Created attachment 170449 [details] [review]
Bug 10190: Add comments to overdue_notices and rename variable

Trying to fully understand how this script operates.. this patch adds
some notes to the script for developers and also renames a variable that
I found was being re-used.
Comment 32 Martin Renvoize (ashimema) 2024-09-19 11:13:23 UTC
https://github.com/PTFS-Europe/koha/tree/bug_10190_submission
Comment 33 Martin Renvoize (ashimema) 2024-09-19 11:18:09 UTC
I'm still cleaning up the commits and Matt and I are working on adding tests.

But, it's all working pretty well now and testing is ongoing in production at a customer site.

I've set up a sandbox for anyone wanting to have a play: https://staff-overdues.sandboxes.ptfs-europe.co.uk/

Test plan:

1) Head on over to either 'Tools > Overdue notice/status triggers' or 'Administration > Circulation triggers' (They're the same page)
2) Add a base ALL, ALL, ALL rule
3) Add rule overrides for various combinations of Library, Patron category and Item type
Comment 34 Martin Renvoize (ashimema) 2024-09-19 13:20:13 UTC Comment hidden (obsolete)
Comment 35 Martin Renvoize (ashimema) 2024-09-19 13:20:16 UTC Comment hidden (obsolete)
Comment 36 Martin Renvoize (ashimema) 2024-09-19 13:20:20 UTC Comment hidden (obsolete)
Comment 37 Martin Renvoize (ashimema) 2024-09-19 13:20:24 UTC Comment hidden (obsolete)
Comment 38 Martin Renvoize (ashimema) 2024-09-19 13:20:27 UTC Comment hidden (obsolete)
Comment 39 Martin Renvoize (ashimema) 2024-09-19 13:20:31 UTC Comment hidden (obsolete)
Comment 40 Martin Renvoize (ashimema) 2024-09-19 13:20:36 UTC Comment hidden (obsolete)
Comment 41 Martin Renvoize (ashimema) 2024-09-19 13:20:39 UTC Comment hidden (obsolete)
Comment 42 Martin Renvoize (ashimema) 2024-09-19 13:20:43 UTC Comment hidden (obsolete)
Comment 43 Martin Renvoize (ashimema) 2024-09-19 13:20:46 UTC Comment hidden (obsolete)
Comment 44 Martin Renvoize (ashimema) 2024-09-19 13:20:50 UTC Comment hidden (obsolete)
Comment 45 Martin Renvoize (ashimema) 2024-09-19 13:20:54 UTC Comment hidden (obsolete)
Comment 46 Martin Renvoize (ashimema) 2024-09-19 13:20:57 UTC Comment hidden (obsolete)
Comment 47 Martin Renvoize (ashimema) 2024-09-19 13:21:01 UTC Comment hidden (obsolete, osbolete)
Comment 48 Martin Renvoize (ashimema) 2024-09-19 13:21:05 UTC Comment hidden (obsolete)
Comment 49 Martin Renvoize (ashimema) 2024-09-19 13:21:08 UTC Comment hidden (obsolete)
Comment 50 Martin Renvoize (ashimema) 2024-09-19 13:21:12 UTC Comment hidden (obsolete)
Comment 51 Martin Renvoize (ashimema) 2024-09-19 13:21:15 UTC Comment hidden (obsolete)
Comment 52 Martin Renvoize (ashimema) 2024-09-19 13:21:19 UTC Comment hidden (obsolete)
Comment 53 Martin Renvoize (ashimema) 2024-09-19 13:21:23 UTC Comment hidden (obsolete)
Comment 54 Martin Renvoize (ashimema) 2024-09-19 13:21:27 UTC Comment hidden (obsolete)
Comment 55 Martin Renvoize (ashimema) 2024-09-19 13:21:31 UTC Comment hidden (obsolete)
Comment 56 Martin Renvoize (ashimema) 2024-09-19 13:21:36 UTC Comment hidden (obsolete)
Comment 57 Martin Renvoize (ashimema) 2024-09-19 13:21:39 UTC Comment hidden (obsolete)
Comment 58 Martin Renvoize (ashimema) 2024-09-19 13:21:44 UTC Comment hidden (obsolete)
Comment 59 Martin Renvoize (ashimema) 2024-09-19 13:21:48 UTC Comment hidden (obsolete)
Comment 60 Martin Renvoize (ashimema) 2024-09-19 13:21:52 UTC Comment hidden (obsolete)
Comment 61 Martin Renvoize (ashimema) 2024-09-19 13:21:56 UTC Comment hidden (obsolete)
Comment 62 Martin Renvoize (ashimema) 2024-09-19 13:22:00 UTC Comment hidden (obsolete)
Comment 63 Martin Renvoize (ashimema) 2024-09-19 13:25:09 UTC
This is all ready for testing now and can be done using the sandbox above, a fresh sandbox or a local dev env.
Comment 64 Laurence Rault 2024-09-26 19:26:09 UTC
Installed on sandboxes : updatedatabase error, problem of foreign key constraint
Comment 65 Martin Renvoize (ashimema) 2024-09-27 15:48:21 UTC
Notes from Nick Clemens at KohaCon24
* Use syspref for 'All libraries' or 'Logged in library' by default - DefaultToLoggedInLibraryOverdueTriggers
* We should not be able to save a notice without a transport type (including aking into account fallbacks)
* Note about whether we're talking aobut 'patrons home library' or 'items home library'
* If a notice template is only set up for one library only display it in the notice dropdown when in that context
* Can we expose somewhere the list of all notice trigger context combinations..
Comment 66 Martin Renvoize (ashimema) 2024-10-10 14:39:09 UTC Comment hidden (obsolete)
Comment 67 Martin Renvoize (ashimema) 2024-10-10 14:39:13 UTC Comment hidden (obsolete)
Comment 68 Martin Renvoize (ashimema) 2024-10-10 14:39:16 UTC Comment hidden (obsolete)
Comment 69 Martin Renvoize (ashimema) 2024-10-10 14:39:20 UTC Comment hidden (obsolete)
Comment 70 Martin Renvoize (ashimema) 2024-10-10 14:39:24 UTC Comment hidden (obsolete)
Comment 71 Martin Renvoize (ashimema) 2024-10-10 14:39:28 UTC Comment hidden (obsolete)
Comment 72 Martin Renvoize (ashimema) 2024-10-10 14:39:32 UTC Comment hidden (obsolete)
Comment 73 Martin Renvoize (ashimema) 2024-10-10 14:39:36 UTC Comment hidden (obsolete)
Comment 74 Martin Renvoize (ashimema) 2024-10-10 14:39:40 UTC Comment hidden (obsolete)
Comment 75 Martin Renvoize (ashimema) 2024-10-10 14:39:44 UTC Comment hidden (obsolete)
Comment 76 Martin Renvoize (ashimema) 2024-10-10 14:39:47 UTC Comment hidden (obsolete)
Comment 77 Martin Renvoize (ashimema) 2024-10-10 14:39:51 UTC Comment hidden (obsolete)
Comment 78 Martin Renvoize (ashimema) 2024-10-10 14:39:54 UTC Comment hidden (obsolete)
Comment 79 Martin Renvoize (ashimema) 2024-10-10 14:39:58 UTC Comment hidden (obsolete)
Comment 80 Martin Renvoize (ashimema) 2024-10-10 14:40:02 UTC Comment hidden (obsolete)
Comment 81 Martin Renvoize (ashimema) 2024-10-10 14:40:06 UTC Comment hidden (obsolete)
Comment 82 Martin Renvoize (ashimema) 2024-10-10 14:40:10 UTC Comment hidden (obsolete)
Comment 83 Martin Renvoize (ashimema) 2024-10-10 14:40:14 UTC Comment hidden (obsolete)
Comment 84 Martin Renvoize (ashimema) 2024-10-10 14:40:18 UTC Comment hidden (obsolete)
Comment 85 Martin Renvoize (ashimema) 2024-10-10 14:40:22 UTC Comment hidden (obsolete)
Comment 86 Martin Renvoize (ashimema) 2024-10-10 14:40:25 UTC Comment hidden (obsolete)
Comment 87 Martin Renvoize (ashimema) 2024-10-10 14:40:29 UTC Comment hidden (obsolete)
Comment 88 Martin Renvoize (ashimema) 2024-10-10 14:40:34 UTC Comment hidden (obsolete)
Comment 89 Martin Renvoize (ashimema) 2024-10-10 14:40:37 UTC Comment hidden (obsolete)
Comment 90 Martin Renvoize (ashimema) 2024-10-10 14:40:41 UTC Comment hidden (obsolete)
Comment 91 Martin Renvoize (ashimema) 2024-10-10 14:40:45 UTC Comment hidden (obsolete)
Comment 92 Martin Renvoize (ashimema) 2024-10-10 14:40:50 UTC Comment hidden (obsolete)
Comment 93 Martin Renvoize (ashimema) 2024-10-10 14:40:53 UTC Comment hidden (obsolete)
Comment 94 Martin Renvoize (ashimema) 2024-10-10 14:40:57 UTC Comment hidden (obsolete)
Comment 95 Martin Renvoize (ashimema) 2024-10-10 14:41:01 UTC Comment hidden (obsolete)
Comment 96 Martin Renvoize (ashimema) 2024-10-10 14:41:05 UTC Comment hidden (obsolete)
Comment 97 Martin Renvoize (ashimema) 2024-10-10 14:41:10 UTC Comment hidden (obsolete)
Comment 98 Martin Renvoize (ashimema) 2024-10-10 16:13:06 UTC Comment hidden (obsolete)
Comment 99 Martin Renvoize (ashimema) 2024-10-10 16:19:28 UTC Comment hidden (obsolete)
Comment 100 Martin Renvoize (ashimema) 2024-10-10 16:19:32 UTC Comment hidden (obsolete)
Comment 101 Martin Renvoize (ashimema) 2024-10-10 16:19:36 UTC Comment hidden (obsolete)
Comment 102 Martin Renvoize (ashimema) 2024-10-10 16:19:41 UTC Comment hidden (obsolete)
Comment 103 Martin Renvoize (ashimema) 2024-10-10 16:19:45 UTC Comment hidden (obsolete)
Comment 104 Martin Renvoize (ashimema) 2024-10-10 16:19:49 UTC Comment hidden (obsolete)
Comment 105 Martin Renvoize (ashimema) 2024-10-10 16:19:53 UTC Comment hidden (obsolete)
Comment 106 Martin Renvoize (ashimema) 2024-10-10 16:19:57 UTC Comment hidden (obsolete)
Comment 107 Martin Renvoize (ashimema) 2024-10-10 16:20:01 UTC Comment hidden (obsolete)
Comment 108 Martin Renvoize (ashimema) 2024-10-10 16:20:04 UTC Comment hidden (obsolete)
Comment 109 Martin Renvoize (ashimema) 2024-10-10 16:20:08 UTC Comment hidden (obsolete)
Comment 110 Martin Renvoize (ashimema) 2024-10-10 16:20:12 UTC Comment hidden (obsolete)
Comment 111 Martin Renvoize (ashimema) 2024-10-10 16:20:16 UTC Comment hidden (obsolete)
Comment 112 Martin Renvoize (ashimema) 2024-10-10 16:20:21 UTC Comment hidden (obsolete)
Comment 113 Martin Renvoize (ashimema) 2024-10-10 16:20:24 UTC Comment hidden (obsolete)
Comment 114 Martin Renvoize (ashimema) 2024-10-10 16:20:29 UTC Comment hidden (obsolete)
Comment 115 Martin Renvoize (ashimema) 2024-10-10 16:20:33 UTC Comment hidden (obsolete)
Comment 116 Martin Renvoize (ashimema) 2024-10-10 16:20:36 UTC Comment hidden (obsolete)
Comment 117 Martin Renvoize (ashimema) 2024-10-10 16:20:40 UTC Comment hidden (obsolete)
Comment 118 Martin Renvoize (ashimema) 2024-10-10 16:20:44 UTC Comment hidden (obsolete)
Comment 119 Martin Renvoize (ashimema) 2024-10-10 16:20:48 UTC Comment hidden (obsolete)
Comment 120 Martin Renvoize (ashimema) 2024-10-10 16:20:53 UTC Comment hidden (obsolete)
Comment 121 Martin Renvoize (ashimema) 2024-10-10 16:20:57 UTC Comment hidden (obsolete)
Comment 122 Martin Renvoize (ashimema) 2024-10-10 16:21:01 UTC Comment hidden (obsolete)
Comment 123 Martin Renvoize (ashimema) 2024-10-10 16:21:05 UTC Comment hidden (obsolete)
Comment 124 Martin Renvoize (ashimema) 2024-10-10 16:21:10 UTC Comment hidden (obsolete)
Comment 125 Martin Renvoize (ashimema) 2024-10-10 16:21:13 UTC Comment hidden (obsolete)
Comment 126 Martin Renvoize (ashimema) 2024-10-10 16:21:17 UTC Comment hidden (obsolete)
Comment 127 Martin Renvoize (ashimema) 2024-10-10 16:21:21 UTC Comment hidden (obsolete)
Comment 128 Martin Renvoize (ashimema) 2024-10-10 16:21:25 UTC Comment hidden (obsolete)
Comment 129 Martin Renvoize (ashimema) 2024-10-10 16:21:29 UTC Comment hidden (obsolete)
Comment 130 Martin Renvoize (ashimema) 2024-10-10 16:21:32 UTC Comment hidden (obsolete)
Comment 131 Martin Renvoize (ashimema) 2024-10-10 16:21:36 UTC Comment hidden (obsolete)
Comment 132 Martin Renvoize (ashimema) 2024-10-23 13:52:25 UTC
(In reply to Martin Renvoize (ashimema) from comment #65)
> Notes from Nick Clemens at KohaCon24
> * Use syspref for 'All libraries' or 'Logged in library' by default -
> DefaultToLoggedInLibraryOverdueTriggers

DONE

> * Note about whether we're talking aobut 'patrons home library' or 'items
> home library'

DONE

> * If a notice template is only set up for one library only display it in the
> notice dropdown when in that context

DONE

> * Can we expose somewhere the list of all notice trigger context
> combinations..

In a follow-up bug I reckon.
Comment 133 Martin Renvoize (ashimema) 2025-02-25 11:56:47 UTC
Created attachment 178643 [details] [review]
Bug 10190: DB migration for overduerules

This patch adds the data migration for overduerules to circulation
rules.

We attempt to create the default rules based on most commonly occuring
rule values and then add overrides for all other rule values we find.

Sponsored-by: Glasgow Colleges Library Group <https://library.cityofglasgowcollege.ac.uk>
Signed-off-by: George Harkins <George.Harkins@cityofglasgowcollege.ac.uk>
Comment 134 Martin Renvoize (ashimema) 2025-02-25 11:56:51 UTC
Created attachment 178644 [details] [review]
Bug 10190: DBIC Schema update

Sponsored-by: Glasgow Colleges Library Group <https://library.cityofglasgowcollege.ac.uk>
Signed-off-by: George Harkins <George.Harkins@cityofglasgowcollege.ac.uk>
Comment 135 Martin Renvoize (ashimema) 2025-02-25 11:56:55 UTC
Created attachment 178645 [details] [review]
Bug 10190: Remove OverdueRule Koha Objects

Sponsored-by: Glasgow Colleges Library Group <https://library.cityofglasgowcollege.ac.uk>
Signed-off-by: George Harkins <George.Harkins@cityofglasgowcollege.ac.uk>
Comment 136 Martin Renvoize (ashimema) 2025-02-25 11:57:00 UTC
Created attachment 178646 [details] [review]
Bug 10190: Fix unit test to exclude _X_ rules

Sponsored-by: Glasgow Colleges Library Group <https://library.cityofglasgowcollege.ac.uk>
Signed-off-by: George Harkins <George.Harkins@cityofglasgowcollege.ac.uk>
Comment 137 Martin Renvoize (ashimema) 2025-02-25 11:57:04 UTC
Created attachment 178647 [details] [review]
Bug 10190: Add support for incrementable circulation rules

This patch adds support for _X_ grouped circulation rules to both the
internal and external API's for handling circulation rules.

This allows us to group overdue_X_rulename rules by an 'X' integer so we
can have triggers incremented and grouped together.

We also add the new overdue_x_* rule definition here for overdue trigger
rules.

Sponsored-by: Glasgow Colleges Library Group <https://library.cityofglasgowcollege.ac.uk>
Signed-off-by: George Harkins <George.Harkins@cityofglasgowcollege.ac.uk>
Comment 138 Martin Renvoize (ashimema) 2025-02-25 11:57:08 UTC
Created attachment 178648 [details] [review]
Bug 10190: Add a vue app for circulation triggers

This patch adds a new vue based page for administering circulation
triggers.  This aims to replace the 'Overdue notice/status triggers'
page available from Tools.

The new page is available from Koha administration > Circulation triggers

Sponsored-by: Glasgow Colleges Library Group <https://library.cityofglasgowcollege.ac.uk>
Signed-off-by: George Harkins <George.Harkins@cityofglasgowcollege.ac.uk>
Comment 139 Martin Renvoize (ashimema) 2025-02-25 11:57:12 UTC
Created attachment 178649 [details] [review]
Bug 10190: Add components to list/add and edit circulation triggers

These new components are used by the new 'Circulation triggers'
administration page to display existing trigger rules and add the
ability to add new rules and edit existing ones.

Sponsored-by: Glasgow Colleges Library Group <https://library.cityofglasgowcollege.ac.uk>
Signed-off-by: George Harkins <George.Harkins@cityofglasgowcollege.ac.uk>
Comment 140 Martin Renvoize (ashimema) 2025-02-25 11:57:17 UTC
Created attachment 178650 [details] [review]
Bug 10190: Add a library API client

This patch adds a library api client to the vue ecosystem for later use
in the Circulation triggers page.

Sponsored-by: Glasgow Colleges Library Group <https://library.cityofglasgowcollege.ac.uk>
Signed-off-by: George Harkins <George.Harkins@cityofglasgowcollege.ac.uk>
Comment 141 Martin Renvoize (ashimema) 2025-02-25 11:57:21 UTC
Created attachment 178651 [details] [review]
Bug 10190: Add itemtypes and patron categories to the item/patron api clients

This patch adds patron and itemtype api clients for the Vue ecosystem

Sponsored-by: Glasgow Colleges Library Group <https://library.cityofglasgowcollege.ac.uk>
Signed-off-by: George Harkins <George.Harkins@cityofglasgowcollege.ac.uk>
Comment 142 Martin Renvoize (ashimema) 2025-02-25 11:57:25 UTC
Created attachment 178652 [details] [review]
Bug 10190: Let the circulation_rules endpoint accept query parameters

Sponsored-by: Glasgow Colleges Library Group <https://library.cityofglasgowcollege.ac.uk>
Signed-off-by: George Harkins <George.Harkins@cityofglasgowcollege.ac.uk>
Comment 143 Martin Renvoize (ashimema) 2025-02-25 11:57:29 UTC
Created attachment 178653 [details] [review]
Bug 10190: Update GetBranchcodesWithOverdueRules to use CirculationRules

This patch updates the C4::Overdues method
GetBranchecodesWithOverdueRules to refer to the new location of these
rules in the circulation rules table. We also update the unit tests to
move the mocked data into the right location.

We could perhaps migrate this method in Koha::CirculationRules at a
later date?

Sponsored-by: Glasgow Colleges Library Group <https://library.cityofglasgowcollege.ac.uk>
Signed-off-by: George Harkins <George.Harkins@cityofglasgowcollege.ac.uk>
Comment 144 Martin Renvoize (ashimema) 2025-02-25 11:57:33 UTC
Created attachment 178654 [details] [review]
Bug 10190: Update overdue_notices script to refer to circ rules

This patch updates the overdue_notices cron script to refer to the new
location for overdue rules found in the circulation rules table now.

Sponsored-by: Glasgow Colleges Library Group <https://library.cityofglasgowcollege.ac.uk>
Signed-off-by: George Harkins <George.Harkins@cityofglasgowcollege.ac.uk>
Comment 145 Martin Renvoize (ashimema) 2025-02-25 11:57:37 UTC
Created attachment 178655 [details] [review]
Bug 10190: Add itemtype handling to overdue_notices script

This patch enhances the overdue_notices script to understand the newly
introduced itemtype level for overdue rules.

Sponsored-by: Glasgow Colleges Library Group <https://library.cityofglasgowcollege.ac.uk>
Signed-off-by: George Harkins <George.Harkins@cityofglasgowcollege.ac.uk>
Comment 146 Martin Renvoize (ashimema) 2025-02-25 11:57:41 UTC
Created attachment 178656 [details] [review]
Bug 10190: Update has_restricting_overdues to refer to circulation rules

This patch updates the Koha::Patron->has_restriction_overdues method to
refer to the migrated overdue rules.

We also correct an oversight in the method prior to this patch that
meant that not all overdues were being correctly checked for a
restriction.. we were incorrectly filtering to only overdues at the
current checkin branch.

Finally, we also take account of the itemtype level addition here too.

NOTE: There weren't any unit tests for this Koha::Patron method.. we
should add some here!

Sponsored-by: Glasgow Colleges Library Group <https://library.cityofglasgowcollege.ac.uk>
Signed-off-by: George Harkins <George.Harkins@cityofglasgowcollege.ac.uk>
Comment 147 Martin Renvoize (ashimema) 2025-02-25 11:57:46 UTC
Created attachment 178657 [details] [review]
Bug 10190: Add letter names to tables

Sponsored-by: Glasgow Colleges Library Group <https://library.cityofglasgowcollege.ac.uk>
Signed-off-by: George Harkins <George.Harkins@cityofglasgowcollege.ac.uk>
Comment 148 Martin Renvoize (ashimema) 2025-02-25 11:57:50 UTC
Created attachment 178658 [details] [review]
Bug 10190: Set tab based on trigger edited/created

Sponsored-by: Glasgow Colleges Library Group <https://library.cityofglasgowcollege.ac.uk>
Signed-off-by: George Harkins <George.Harkins@cityofglasgowcollege.ac.uk>
Comment 149 Martin Renvoize (ashimema) 2025-02-25 11:57:55 UTC
Created attachment 178659 [details] [review]
Bug 10190: Add fallback to 'Default' text for notice

Sponsored-by: Glasgow Colleges Library Group <https://library.cityofglasgowcollege.ac.uk>
Signed-off-by: George Harkins <George.Harkins@cityofglasgowcollege.ac.uk>
Comment 150 Martin Renvoize (ashimema) 2025-02-25 11:57:59 UTC
Created attachment 178660 [details] [review]
Bug 10190: Migrate MarkIssueReturned test to circulation rules

Sponsored-by: Glasgow Colleges Library Group <https://library.cityofglasgowcollege.ac.uk>
Signed-off-by: George Harkins <George.Harkins@cityofglasgowcollege.ac.uk>
Comment 151 Martin Renvoize (ashimema) 2025-02-25 11:58:03 UTC
Created attachment 178661 [details] [review]
Bug 10190: Remove old overduerules interface

This patch updates the link from the tools homepage to open the new
circulation triggers administration page.

We then remove the old overduerules controller and template, and finally
we drop the no longer referenced
C4::Overdues::GetOverdueMessageTransportTypes method and associated unit
tests.

Sponsored-by: Glasgow Colleges Library Group <https://library.cityofglasgowcollege.ac.uk>
Signed-off-by: George Harkins <George.Harkins@cityofglasgowcollege.ac.uk>
Comment 152 Martin Renvoize (ashimema) 2025-02-25 11:58:07 UTC
Created attachment 178662 [details] [review]
Bug 10190: Update itiva script to reflect move to circ_rules

Sponsored-by: Glasgow Colleges Library Group <https://library.cityofglasgowcollege.ac.uk>
Signed-off-by: George Harkins <George.Harkins@cityofglasgowcollege.ac.uk>
Comment 153 Martin Renvoize (ashimema) 2025-02-25 11:58:12 UTC
Created attachment 178663 [details] [review]
Bug 10190: Add comments to overdue_notices and rename variable

Trying to fully understand how this script operates.. this patch adds
some notes to the script for developers and also renames a variable that
I found was being re-used.

Sponsored-by: Glasgow Colleges Library Group <https://library.cityofglasgowcollege.ac.uk>
Signed-off-by: George Harkins <George.Harkins@cityofglasgowcollege.ac.uk>
Comment 154 Martin Renvoize (ashimema) 2025-02-25 11:58:16 UTC
Created attachment 178664 [details] [review]
Bug 10190: Rework logic of overdue_notices

The original logic for digesting overdues in the overdue notices script
was flawed given the additional itemtype handling introduced in this
patchset and the way in which it handles effective fallbacks for rules.

This patch tidies the file and reworks the logic so that we fetch
overdues by patron category and branch and then iterate through those
comparing to the correct effective rules and combing them into digest
groups based on notice + trigger level.

Sponsored-by: Glasgow Colleges Library Group <https://library.cityofglasgowcollege.ac.uk>
Signed-off-by: George Harkins <George.Harkins@cityofglasgowcollege.ac.uk>
Comment 155 Martin Renvoize (ashimema) 2025-02-25 11:58:20 UTC
Created attachment 178665 [details] [review]
Bug 10190: Display effective values and highlight them

Sponsored-by: Glasgow Colleges Library Group <https://library.cityofglasgowcollege.ac.uk>
Signed-off-by: George Harkins <George.Harkins@cityofglasgowcollege.ac.uk>
Comment 156 Martin Renvoize (ashimema) 2025-02-25 11:58:25 UTC
Created attachment 178666 [details] [review]
Bug 10190: Restore 'edit' from 'Add/Edit' Modal

Sponsored-by: Glasgow Colleges Library Group <https://library.cityofglasgowcollege.ac.uk>
Signed-off-by: George Harkins <George.Harkins@cityofglasgowcollege.ac.uk>
Comment 157 Martin Renvoize (ashimema) 2025-02-25 11:58:29 UTC
Created attachment 178667 [details] [review]
Bug 10190: Modal form improvements

We now fetch all rules on modal open and the effective rule on context
selection.

This allows us to compare the specific values of the rule we're
adding/editing to the fallback values present in the all rules set.

We use the fallback rule values as placeholders in the input boxes to
highlight to the end user what value will be used should they choose to
wipe the input.  We also allow wiping inputs and pass 'null' to the API
appropriately.

Finally, we set a minimum value for delay when adding a new rule to
highlight to the user that the new trigger will be added after existing
triggers.

Sponsored-by: Glasgow Colleges Library Group <https://library.cityofglasgowcollege.ac.uk>
Signed-off-by: George Harkins <George.Harkins@cityofglasgowcollege.ac.uk>
Comment 158 Martin Renvoize (ashimema) 2025-02-25 11:58:33 UTC
Created attachment 178668 [details] [review]
Bug 10190: Add custom input for delay

This custom input allows for dynamic min/max rules and it updates the
input styling to match other inputs on the page including a 'clear'
button.

Sponsored-by: Glasgow Colleges Library Group <https://library.cityofglasgowcollege.ac.uk>
Signed-off-by: George Harkins <George.Harkins@cityofglasgowcollege.ac.uk>
Comment 159 Martin Renvoize (ashimema) 2025-02-25 11:58:38 UTC
Created attachment 178669 [details] [review]
Bug 10190: Clarify workflow

This patch re-arranges the edit/add modal form to clarify the
need to select context, then decide on editing an existing trigger or
adding a new one and then, and only then, exposes the actual rule inputs

Sponsored-by: Glasgow Colleges Library Group <https://library.cityofglasgowcollege.ac.uk>
Signed-off-by: George Harkins <George.Harkins@cityofglasgowcollege.ac.uk>
Comment 160 Martin Renvoize (ashimema) 2025-02-25 11:58:42 UTC
Created attachment 178670 [details] [review]
Bug 10190: Update for bootstrap 5

Sponsored-by: Glasgow Colleges Library Group <https://library.cityofglasgowcollege.ac.uk>
Signed-off-by: George Harkins <George.Harkins@cityofglasgowcollege.ac.uk>
Comment 161 Martin Renvoize (ashimema) 2025-02-25 11:58:46 UTC
Created attachment 178671 [details] [review]
Bug 10190: Rebase for rspack

Sponsored-by: Glasgow Colleges Library Group <https://library.cityofglasgowcollege.ac.uk>
Signed-off-by: George Harkins <George.Harkins@cityofglasgowcollege.ac.uk>
Comment 162 Martin Renvoize (ashimema) 2025-02-25 11:58:50 UTC
Created attachment 178672 [details] [review]
Bug 10190: Rename 'All *' to 'Default rule for *'

Try to clarify that the 'All' rules are actually fallback/default rules
for when there's not a more specific rule for the context.

We need to expose these clearly for each 'Library' view too which we're
not currently doing.

Sponsored-by: Glasgow Colleges Library Group <https://library.cityofglasgowcollege.ac.uk>
Signed-off-by: George Harkins <George.Harkins@cityofglasgowcollege.ac.uk>
Comment 163 Martin Renvoize (ashimema) 2025-02-25 11:58:55 UTC
Created attachment 178673 [details] [review]
Bug 10190: Take DefaultToLoggedInLibraryOverdueTriggers into account

This updates the logic for the default page load to take account of
DefaultToLoggedInLibraryOverdueTriggers.

Sponsored-by: Glasgow Colleges Library Group <https://library.cityofglasgowcollege.ac.uk>
Signed-off-by: George Harkins <George.Harkins@cityofglasgowcollege.ac.uk>
Comment 164 Martin Renvoize (ashimema) 2025-02-25 11:58:59 UTC
Created attachment 178674 [details] [review]
Bug 10190: Only display default and library specific letters

This patch filters the list of letter templates available to use by only
those available for the context the rule is being added for (i.e. the
correct library relation)

Sponsored-by: Glasgow Colleges Library Group <https://library.cityofglasgowcollege.ac.uk>
Signed-off-by: George Harkins <George.Harkins@cityofglasgowcollege.ac.uk>
Comment 165 Martin Renvoize (ashimema) 2025-02-25 11:59:03 UTC
Created attachment 178675 [details] [review]
Bug 10190: Display value of OverdueNoticeFrom in note

Sponsored-by: Glasgow Colleges Library Group <https://library.cityofglasgowcollege.ac.uk>
Signed-off-by: George Harkins <George.Harkins@cityofglasgowcollege.ac.uk>
Comment 166 Victor Grousset/tuxayo 2025-02-26 23:23:39 UTC
Comment on attachment 178644 [details] [review]
Bug 10190: DBIC Schema update

Review of attachment 178644 [details] [review]:
-----------------------------------------------------------------

::: Koha/Schema/Result/MessageTransportType.pm
@@ +133,5 @@
>  );
>  
>  
> +# Created by DBIx::Class::Schema::Loader v0.07051 @ 2024-08-15 11:53:13
> +# DO NOT MODIFY THIS OR ANYTHING ABOVE! md5sum:Bx96QiqHxZ9SNbgK8dSwMg

There are no manual changes to split in separate commit. Whole commit should be marked as [DO NOT PUSH] https://wiki.koha-community.org/wiki/Database_updates#Files_to_change
Comment 167 Victor Grousset/tuxayo 2025-02-26 23:25:43 UTC
updatedatabase doesn't work:
(have a koha on main, apply the patches and update)

$ updatedatabase
Use of uninitialized value $branchcode_value in concatenation (.) or string at /kohadevbox/koha/installer/data/mysql/atomicupdate/bug_10190.pl line 218.
Use of uninitialized value $itemtype in concatenation (.) or string at /kohadevbox/koha/installer/data/mysql/atomicupdate/bug_10190.pl line 218.
Use of uninitialized value $branchcode_value in concatenation (.) or string at /kohadevbox/koha/installer/data/mysql/atomicupdate/bug_10190.pl line 229.
Use of uninitialized value $branchcode_value in concatenation (.) or string at /kohadevbox/koha/installer/data/mysql/atomicupdate/bug_10190.pl line 240.
Use of uninitialized value $branchcode_value in concatenation (.) or string at /kohadevbox/koha/installer/data/mysql/atomicupdate/bug_10190.pl line 251.
Use of uninitialized value $branchcode_value in concatenation (.) or string at /kohadevbox/koha/installer/data/mysql/atomicupdate/bug_10190.pl line 218.
Use of uninitialized value $itemtype in concatenation (.) or string at /kohadevbox/koha/installer/data/mysql/atomicupdate/bug_10190.pl line 218.
Use of uninitialized value $branchcode_value in concatenation (.) or string at /kohadevbox/koha/installer/data/mysql/atomicupdate/bug_10190.pl line 229.
Use of uninitialized value $branchcode_value in concatenation (.) or string at /kohadevbox/koha/installer/data/mysql/atomicupdate/bug_10190.pl line 240.
Use of uninitialized value $branchcode_value in concatenation (.) or string at /kohadevbox/koha/installer/data/mysql/atomicupdate/bug_10190.pl line 251.
Use of uninitialized value $branchcode_value in concatenation (.) or string at /kohadevbox/koha/installer/data/mysql/atomicupdate/bug_10190.pl line 218.
Use of uninitialized value $itemtype in concatenation (.) or string at /kohadevbox/koha/installer/data/mysql/atomicupdate/bug_10190.pl line 218.
Use of uninitialized value $branchcode_value in concatenation (.) or string at /kohadevbox/koha/installer/data/mysql/atomicupdate/bug_10190.pl line 229.
Use of uninitialized value $branchcode_value in concatenation (.) or string at /kohadevbox/koha/installer/data/mysql/atomicupdate/bug_10190.pl line 240.
Use of uninitialized value $branchcode_value in concatenation (.) or string at /kohadevbox/koha/installer/data/mysql/atomicupdate/bug_10190.pl line 251.
DEV atomic update /kohadevbox/koha/installer/data/mysql/atomicupdate/bug_10190.pl  [23:24:08]: Bug 10190 - Migrate overduerules to circulation_rules
        Inserting :undef: default most frequent delay for overdue_1:
        Inserting :undef:undef default most frequent notice for overdue_1:
        Inserting :undef:undef default most frequent mtt for overdue_1:
        Inserting :undef:undef default most frequent restrict for overdue_1: 0
        Inserting :undef: default most frequent delay for overdue_2:
        Inserting :undef:undef default most frequent notice for overdue_2:
        Inserting :undef:undef default most frequent mtt for overdue_2:
        Inserting :undef:undef default most frequent restrict for overdue_2: 0
        Inserting :undef: default most frequent delay for overdue_3:
        Inserting :undef:undef default most frequent notice for overdue_3:
        Inserting :undef:undef default most frequent mtt for overdue_3:
        Inserting :undef:undef default most frequent restrict for overdue_3: 0
        ERROR: {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Cannot delete or update a parent row: a foreign key constraint fails at /kohadevbox/koha/C4/Installer.pm line 771
Comment 168 Victor Grousset/tuxayo 2025-02-26 23:26:36 UTC
MariaDB 10.5.26 in case that matters.
Comment 169 Victor Grousset/tuxayo 2025-02-26 23:44:58 UTC
Comment on attachment 178648 [details] [review]
Bug 10190: Add a vue app for circulation triggers

Review of attachment 178648 [details] [review]:
-----------------------------------------------------------------

::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/circulation_triggers.tt
@@ +25,5 @@
> +    <!-- this is closed in intranet-bottom.inc -->
> +
> +    [% MACRO jsinclude BLOCK %]
> +        [% INCLUDE 'calendar.inc' %]
> +        <!-- FIXME: this shouldn't be needed -->

Is the FIXME for calendar.inc above or datatables.inc bellow or the 4 includes below?
Comment 170 Martin Renvoize (ashimema) 2025-03-03 12:22:46 UTC
(In reply to Victor Grousset/tuxayo from comment #169)
> Comment on attachment 178648 [details] [review] [review]
> Bug 10190: Add a vue app for circulation triggers
> 
> Review of attachment 178648 [details] [review] [review]:
> -----------------------------------------------------------------
> 
> ::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/circulation_triggers.tt
> @@ +25,5 @@
> > +    <!-- this is closed in intranet-bottom.inc -->
> > +
> > +    [% MACRO jsinclude BLOCK %]
> > +        [% INCLUDE 'calendar.inc' %]
> > +        <!-- FIXME: this shouldn't be needed -->
> 
> Is the FIXME for calendar.inc above or datatables.inc bellow or the 4
> includes below?

It was for calendar.inc and if you look at the other vue apps, it's consistent throughout them so far.