Bugzilla – Attachment 19363 Details for
Bug 4907
Suggestions "organize by" menu doesn't reflect current choice
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 4907: 'Organize by' filter in suggestions doesn't reflect selected option
Bug-4907-Organize-by-filter-in-suggestions-doesnt-.patch (text/plain), 3.54 KB, created by
Kyle M Hall (khall)
on 2013-07-03 10:50:21 UTC
(
hide
)
Description:
Bug 4907: 'Organize by' filter in suggestions doesn't reflect selected option
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2013-07-03 10:50:21 UTC
Size:
3.54 KB
patch
obsolete
>From 868774b733146e14dfe710dc1c35dc4fdd9d442f Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <Katrin.Fischer.83@web.de> >Date: Mon, 1 Jul 2013 23:44:39 +0200 >Subject: [PATCH] Bug 4907: 'Organize by' filter in suggestions doesn't reflect selected option > >When using the 'Organize by' option to change the display of the >suggestions, the option is applied, but the pull down always jumps >back to the first entry 'Status'. > >This patch fixes that. > >To test: >- Try out all settings and verify that after the page reloads the selected > option is applied to your suggestions and the pull down shows > the option you selected. > >Note: Until bug 10519 is properly fixed the tabs will not show >the correct descriptions, but the URL will show you the selected >option as parameter: displayby=acceptedby > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > .../prog/en/modules/suggestion/suggestion.tt | 30 ++++++++++++++++--- > 1 files changed, 25 insertions(+), 5 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt >index c1f54e3..0b4a4ab 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt >@@ -586,11 +586,31 @@ $(document).ready(function() { calcNewsuggTotal(); }); > <form name="suggestionfilter" action="suggestion.pl" method="get"> > <fieldset class="brief"><ol style="display:block;"><li><label for="displayby">Organize by: </label> > <select name="displayby" id="displayby" style="width:auto;"> >- <option value="STATUS">Status</option> >- <option value="branchcode">Library</option> >- <option value="itemtype">Item type</option> >- <option value="managedby">Managed by</option> >- <option value="acceptedby">Accepted by</option> >+ [% IF ( displayby == "STATUS" ) %] >+ <option value="STATUS" selected="selected">Status</option> >+ [% ELSE %] >+ <option value="STATUS">Status</option> >+ [% END %] >+ [% IF ( displayby == "branchcode" ) %] >+ <option value="branchcode" selected="selected">Library</option> >+ [% ELSE %] >+ <option value="branchcode">Library</option> >+ [% END %] >+ [% IF ( displayby == "itemtype" ) %] >+ <option value="itemtype" selected="selected">Item type</option> >+ [% ELSE %] >+ <option value="itemtype">Item type</option> >+ [% END %] >+ [% IF ( displayby == "managedby" ) %] >+ <option value="managedby" selected="selected">Managed by</option> >+ [% ELSE %] >+ <option value="managedby">Managed by</option> >+ [% END %] >+ [% IF ( displayby == "acceptedby" ) %] >+ <option value="acceptedby" selected="selected">Accepted by</option> >+ [% ELSE %] >+ <option value="acceptedby">Accepted by</option> >+ [% END %] > </select> <input type="submit" value="Go" /></li></ol></fieldset> > <h4>Filter by: <a style="font-size:80%;font-weight:normal;" href="/cgi-bin/koha/suggestion/suggestion.pl">[clear]</a></h4> > <div style="display:block;" id="limits"> >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 4907
:
19329
|
19363
|
19450