Bugzilla – Attachment 19367 Details for
Bug 10536
Error when editing an order note when receiving
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Proposed patch
0001-Bug-10536-Error-when-editing-an-order-note-when-rece.patch (text/plain), 2.94 KB, created by
Fridolin Somers
on 2013-07-03 13:28:32 UTC
(
hide
)
Description:
Proposed patch
Filename:
MIME Type:
Creator:
Fridolin Somers
Created:
2013-07-03 13:28:32 UTC
Size:
2.94 KB
patch
obsolete
>From 901be3c87dad00518da9761e440e7672e01c50b3 Mon Sep 17 00:00:00 2001 >From: Fridolyn SOMERS <fridolyn.somers@biblibre.com> >Date: Wed, 3 Jul 2013 15:19:00 +0200 >Subject: [PATCH] Bug 10536 - Error when editing an order note when receiving > >When receiving ordrers "acqui/parcel.pl?invoiceid=1", you can add or modify an order note directly from table. >After setting note "acqui/modordernotes.pl", you get an error : >Can't use an undefined value as an ARRAY reference at /acqui/parcel.pl line 156. > >This patch corrects this, there was an error in referrer build into link to acqui/modordernotes.pl. > >Test plan : >- Go to a vendor and click on "Receive shipments" >- Click on an invoice >- On an order without note, click on "Add note" >- Enter a note and click "Save" >=> You come back to invoice and note is added >- On an order with note, click on "Change note" >- Enter a note and click "Save" >=> You come back to invoice and note is added >--- > koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt >index 415c7e8..e96033b 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt >@@ -200,9 +200,9 @@ > [% END %] > <br /> > [% IF ( loop_order.notes ) %] >- <p class="ordernote"><strong>Note: </strong>[% loop_order.notes|html %] [<a href="/cgi-bin/koha/acqui/modordernotes.pl?ordernumber=[% loop_order.ordernumber %]&referrer=/cgi-bin/koha/acqui/parcel.pl%3Fbooksellerid=[% loop_order.booksellerid %]&datereceived=[% loop_order.invoicedatereceived %]&invoice=[% loop_order.invoice %]">Change note</a>]</p> >+ <p class="ordernote"><strong>Note: </strong>[% loop_order.notes|html %] [<a href="/cgi-bin/koha/acqui/modordernotes.pl?ordernumber=[% loop_order.ordernumber %]&referrer=/cgi-bin/koha/acqui/parcel.pl%3Finvoiceid=[% invoiceid %]">Change note</a>]</p> > [% ELSE %] >- [<a href="/cgi-bin/koha/acqui/modordernotes.pl?ordernumber=[% loop_order.ordernumber %]&referrer=/cgi-bin/koha/acqui/parcel.pl%3Fbooksellerid=[% loop_order.booksellerid %]&datereceived=[% loop_order.invoicedatereceived %]&invoice=[% loop_order.invoice %]">Add note</a>] >+ [<a href="/cgi-bin/koha/acqui/modordernotes.pl?ordernumber=[% loop_order.ordernumber %]&referrer=/cgi-bin/koha/acqui/parcel.pl%3Finvoiceid=[% invoiceid %]">Add note</a>] > [% END %] > </td> > <td><a href="/cgi-bin/koha/catalogue/showmarc.pl?id=[% loop_order.biblionumber %]" title="MARC" rel="gb_page_center[600,500]">MARC</a> | <a href="/cgi-bin/koha/catalogue/showmarc.pl?viewas=card&id=[% loop_order.biblionumber %]" title="MARC" rel="gb_page_center[600,500]">Card</a></td> >-- >1.7.10.4 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10536
:
19367
|
19382