Bug 10536 - Error when editing an order note when receiving
Summary: Error when editing an order note when receiving
Status: RESOLVED DUPLICATE of bug 10317
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Fridolin Somers
QA Contact:
URL:
Keywords:
: 9187 10525 (view as bug list)
Depends on:
Blocks:
 
Reported: 2013-07-03 13:18 UTC by Fridolin Somers
Modified: 2013-07-05 12:08 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Proposed patch (2.94 KB, patch)
2013-07-03 13:28 UTC, Fridolin Somers
Details | Diff | Splinter Review
[SIGNED OFF] Bug 10536 - Error when editing an order note when receiving (3.04 KB, patch)
2013-07-03 20:48 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Fridolin Somers 2013-07-03 13:18:37 UTC
When receiving ordrers "acqui/parcel.pl?invoiceid=1", you can add or modify an order note directly from table.
After setting note "acqui/modordernotes.pl", you get an error : 
Can't use an undefined value as an ARRAY reference at /acqui/parcel.pl line 156.
Comment 1 Fridolin Somers 2013-07-03 13:28:32 UTC Comment hidden (obsolete)
Comment 2 Katrin Fischer 2013-07-03 13:48:47 UTC
*** Bug 9187 has been marked as a duplicate of this bug. ***
Comment 3 Katrin Fischer 2013-07-03 20:16:09 UTC
*** Bug 10525 has been marked as a duplicate of this bug. ***
Comment 4 Katrin Fischer 2013-07-03 20:46:26 UTC
Hi Fridolyn, could you maybe take a look at 10301 too? The note is not shown in the receive page for the order line, but if you add a note there it will overwrite the existing one.
Comment 5 Katrin Fischer 2013-07-03 20:48:12 UTC
Created attachment 19382 [details] [review]
[SIGNED OFF] Bug 10536 - Error when editing an order note when receiving

When receiving ordrers "acqui/parcel.pl?invoiceid=1", you can add or modify an order note directly from table.
After setting note "acqui/modordernotes.pl", you get an error :
Can't use an undefined value as an ARRAY reference at /acqui/parcel.pl line 156.

This patch corrects this, there was an error in referrer build into link to acqui/modordernotes.pl.

Test plan :
- Go to a vendor and click on "Receive shipments"
- Click on an invoice
- On an order without note, click on "Add note"
- Enter a note and click "Save"
=> You come back to invoice and note is added
- On an order with note, click on "Change note"
- Enter a note and click "Save"
=> You come back to invoice and note is added

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works as described, template change only.
Comment 6 Jonathan Druart 2013-07-05 12:08:25 UTC
This issue is fixed by bug 10317 (already passed QA).

*** This bug has been marked as a duplicate of bug 10317 ***