Bugzilla – Attachment 194370 Details for
Bug 41970
PA_CLASS does not show in fieldset ID on opac-memberentry.pl
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 41970: Fix typo in pa_class in template
Bug-41970-Fix-typo-in-paclass-in-template.patch (text/plain), 2.02 KB, created by
Roman Dolny
on 2026-03-03 06:36:47 UTC
(
hide
)
Description:
Bug 41970: Fix typo in pa_class in template
Filename:
MIME Type:
Creator:
Roman Dolny
Created:
2026-03-03 06:36:47 UTC
Size:
2.02 KB
patch
obsolete
>From 4db3a0e5156d82730a47e2f2942ed1e24fcee005 Mon Sep 17 00:00:00 2001 >From: David Cook <dcook@prosentient.com.au> >Date: Tue, 3 Mar 2026 01:36:22 +0000 >Subject: [PATCH] Bug 41970: Fix typo in pa_class in template > >This change fixes a typo from pa_loo to pa_class, so that >the ID attribute of the fieldset is properly set when using PA_CLASS >to group patron attributes. > >Test plan: >0. Set up two PA_CLASS values >1. Set up two patron attributes which are viewable/editable on the >OPAC and assign them one class each >2. Go to http://localhost:8080/cgi-bin/koha/opac-memberentry.pl >3. Look at the HTML and note that fieldsets for both PA classes >have the ID of "aai_" > >4. Apply the patch > >5. Reload the page http://localhost:8080/cgi-bin/koha/opac-memberentry.pl >6. Note that now the fieldsets have ID attributes of >"aai_<PA_CLASS code>". >7. Rejoice as now it's easier to use Javascript and CSS and have valid >HTML! > >Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> >--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt >index 8a7563c775..f47c30acbb 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt >@@ -1238,7 +1238,7 @@ > [% SET legend = "Additional information" %] > [% FOREACH pa_class IN patron_attribute_classes %] > [% IF pa_class.class %] >- [% fieldset_id = "aai_" _ pa_loo.class %] >+ [% fieldset_id = "aai_" _ pa_class.class %] > [% legend = pa_class.lib %] > [% END %] > <fieldset id="[% fieldset_id | html %]" class="rows patron-attributes"> >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 41970
:
194369
|
194370
|
194371