Bugzilla – Attachment 19608 Details for
Bug 10507
Typo when warning about creating duplicate patron attribute
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 10507 Fix namespace collision in patron entry
Bug-10507-Fix-namespace-collision-in-patron-entry.patch (text/plain), 2.37 KB, created by
Kyle M Hall (khall)
on 2013-07-12 17:07:09 UTC
(
hide
)
Description:
Bug 10507 Fix namespace collision in patron entry
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2013-07-12 17:07:09 UTC
Size:
2.37 KB
patch
obsolete
>From a2651f7e7a7222b878f4a114b0a4f750e0b12832 Mon Sep 17 00:00:00 2001 >From: Colin Campbell <colin.campbell@ptfs-europe.com> >Date: Tue, 9 Jul 2013 11:18:49 +0100 >Subject: [PATCH] Bug 10507 Fix namespace collision in patron entry > >If a warning about a duplicated patron attribute is returned >the value was being passed back for display in the warning >message with the same name as the variable in errors > >as the message is displayed in the context of errors >the error value 1 was being displayed not the value >duplicated as intended. >Pass the value to the template with a unique name > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> > >I fixed another tiny typo while signing off: "is already in use" instead >of "is already is use." > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >Passes koha-qa.pl, works as advertised. >--- > .../prog/en/modules/members/memberentrygen.tt | 2 +- > members/memberentry.pl | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt >index 1bb8e3e..7a2d29e 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt >@@ -176,7 +176,7 @@ > [% END %] > [% IF ( ERROR_extended_unique_id_failed ) %] > <li id="ERROR_extended_unique_id_failed">The attribute value >- [% ERROR_extended_unique_id_failed %] is already is use by another patron record.</li> >+ [% ERROR_extended_unique_id_failed_value %] is already in use by another patron record.</li> > [% END %] > </ul> > </div> >diff --git a/members/memberentry.pl b/members/memberentry.pl >index b7123f2..0bf3122 100755 >--- a/members/memberentry.pl >+++ b/members/memberentry.pl >@@ -315,7 +315,7 @@ if ($op eq 'save' || $op eq 'insert'){ > foreach my $attr (@$extended_patron_attributes) { > unless (C4::Members::Attributes::CheckUniqueness($attr->{code}, $attr->{value}, $borrowernumber)) { > push @errors, "ERROR_extended_unique_id_failed"; >- $template->param(ERROR_extended_unique_id_failed => "$attr->{code}/$attr->{value}"); >+ $template->param(ERROR_extended_unique_id_failed_value => "$attr->{code}/$attr->{value}"); > } > } > } >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10507
:
19500
|
19503
| 19608