Bugzilla – Attachment 19822 Details for
Bug 10586
Printing cart from Firefox seems to be missing CSS
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 10586 - Printing cart from Firefox seems to be missing CSS
Bug-10586---Printing-cart-from-Firefox-seems-to-be.patch (text/plain), 2.41 KB, created by
Chris Cormack
on 2013-07-20 21:30:21 UTC
(
hide
)
Description:
Bug 10586 - Printing cart from Firefox seems to be missing CSS
Filename:
MIME Type:
Creator:
Chris Cormack
Created:
2013-07-20 21:30:21 UTC
Size:
2.41 KB
patch
obsolete
>From c61ded95ca6de54bc36153bfb533fda2022af5ae Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Fri, 19 Jul 2013 12:21:42 -0400 >Subject: [PATCH] Bug 10586 - Printing cart from Firefox seems to be missing > CSS > >When printing the Cart from Firefox the styling is off even though it >looks correct in preview. I think this may be because the preview is >including stylesheets designated for screen. > >This patch removes special handling of JS and CSS assets for the Cart's >print view, letting the page handle print styling like other pages in >the OPAC. > >To test, put items in your Cart in the OPAC. Open your Cart and click >the "print" link. Your printout should be correctly styled and match the >preview. > >Signed-off-by: Liz Rea <wizzyrea@gmail.com> >Tested both fail condition and condition with patch - display is much improved. Thanks, Owen! > >Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> >Works as advertised >--- > koha-tmpl/opac-tmpl/prog/en/modules/opac-basket.tt | 12 +++--------- > 1 file changed, 3 insertions(+), 9 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-basket.tt b/koha-tmpl/opac-tmpl/prog/en/modules/opac-basket.tt >index 09993af..5f79ac0 100644 >--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-basket.tt >+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-basket.tt >@@ -2,11 +2,8 @@ > > [% INCLUDE 'doc-head-open.inc' %] > [% IF ( LibraryNameTitle ) %][% LibraryNameTitle %][% ELSE %]Koha online[% END %] catalog › Your cart >- [% IF ( print_basket ) %]</title> >-<meta http-equiv="Content-Type" content="text/html; charset=utf-8" /> >-<link rel="shortcut icon" href="[% themelang %]/includes/favicon.ico" type="image/x-icon" /> >-<meta http-equiv="Content-Language" content="en-us" /> >-<script type="text/javascript" src="[% themelang %]/lib/jquery/jquery.js"></script> >+[% INCLUDE 'doc-head-close.inc' %] >+ [% IF ( print_basket ) %] > <script type="text/javascript"> > //<![CDATA[ > $(document).ready(function(){ >@@ -15,10 +12,7 @@ > }); > //]]> > </script> >-<style type="text/css"> >- @import url([% themelang %]/css/print.css); >-</style> >- [% ELSE %][% INCLUDE 'doc-head-close.inc' %] >+ [% ELSE %] > <script type="text/javascript" src="[% themelang %]/lib/jquery/plugins/jquery.checkboxes.min.js"></script> > <script type="text/javascript" src="[% themelang %]/lib/jquery/plugins/jquery.tablesorter.min.js"></script> > <script type="text/javascript"> >-- >1.8.1.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10586
:
19802
|
19813
| 19822