To test: - Print a cart from Firefox - Print a cart from Chromium In my tests Chromium printed the table borders nicely formated using a non-serif font for the text, while Firefox printed using a serif font and the table without border lines.
Created attachment 19802 [details] [review] Bug 10586 - Printing cart from Firefox seems to be missing CSS When printing the Cart from Firefox the styling is off even though it looks correct in preview. I think this may be because the preview is including stylesheets designated for screen. This patch removes special handling of JS and CSS assets for the Cart's print view, letting the page handle print styling like other pages in the OPAC. To test, put items in your Cart in the OPAC. Open your Cart and click the "print" link. Your printout should be correctly styled and match the preview.
Created attachment 19813 [details] [review] Bug 10586 - Printing cart from Firefox seems to be missing CSS When printing the Cart from Firefox the styling is off even though it looks correct in preview. I think this may be because the preview is including stylesheets designated for screen. This patch removes special handling of JS and CSS assets for the Cart's print view, letting the page handle print styling like other pages in the OPAC. To test, put items in your Cart in the OPAC. Open your Cart and click the "print" link. Your printout should be correctly styled and match the preview. Signed-off-by: Liz Rea <wizzyrea@gmail.com> Tested both fail condition and condition with patch - display is much improved. Thanks, Owen!
Created attachment 19822 [details] [review] Bug 10586 - Printing cart from Firefox seems to be missing CSS When printing the Cart from Firefox the styling is off even though it looks correct in preview. I think this may be because the preview is including stylesheets designated for screen. This patch removes special handling of JS and CSS assets for the Cart's print view, letting the page handle print styling like other pages in the OPAC. To test, put items in your Cart in the OPAC. Open your Cart and click the "print" link. Your printout should be correctly styled and match the preview. Signed-off-by: Liz Rea <wizzyrea@gmail.com> Tested both fail condition and condition with patch - display is much improved. Thanks, Owen! Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Works as advertised
Pushed to master. Thanks, Owen!
This patch has been pushed to 3.12.x, will be in 3.12.4. Thanks Owen!