Bugzilla – Attachment 20350 Details for
Bug 10710
UT : OfflineOperation's routines in C4/Circulation.t need unit tests.
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 10710: (follow-up) perltidy new code
Bug-10710-follow-up-perltidy-new-code.patch (text/plain), 2.24 KB, created by
Galen Charlton
on 2013-08-14 16:45:46 UTC
(
hide
)
Description:
Bug 10710: (follow-up) perltidy new code
Filename:
MIME Type:
Creator:
Galen Charlton
Created:
2013-08-14 16:45:46 UTC
Size:
2.24 KB
patch
obsolete
>From fe3526f4bc60e97269096b505ddc39e6ff805681 Mon Sep 17 00:00:00 2001 >From: Galen Charlton <gmc@esilibrary.com> >Date: Wed, 14 Aug 2013 16:37:49 +0000 >Subject: [PATCH] Bug 10710: (follow-up) perltidy new code > >Also, I prefer the use of parentheses for function >calls, even when no arguments are being passed. >One missed comma turns > >is(GetOfflineOperation, ...) > >into > >is(GetOfflineOperation ...) > >Signed-off-by: Galen Charlton <gmc@esilibrary.com> >--- > t/db_dependent/Circulation_OfflineOperation.t | 14 +++++++++----- > 1 file changed, 9 insertions(+), 5 deletions(-) > >diff --git a/t/db_dependent/Circulation_OfflineOperation.t b/t/db_dependent/Circulation_OfflineOperation.t >index a6e9a95..5d88440 100644 >--- a/t/db_dependent/Circulation_OfflineOperation.t >+++ b/t/db_dependent/Circulation_OfflineOperation.t >@@ -71,7 +71,7 @@ is_deeply( > { > operationid => $offline_id, > userid => 'User1', >- branchcode => $samplebranch1->{branchcode}, >+ branchcode => $samplebranch1->{branchcode}, > timestamp => "0000-00-00 00:00:00", > action => 'Action1', > barcode => 'CODE', >@@ -80,16 +80,20 @@ is_deeply( > }, > "GetOffline returns offlineoperation's informations" > ); >-is(GetOfflineOperation,undef,'GetOfflineOperation without parameters returns undef'); >-is(GetOfflineOperation(-1),undef,'GetOfflineOperation with wrong parameters returns undef'); >+is( GetOfflineOperation(), undef, >+ 'GetOfflineOperation without parameters returns undef' ); >+is( GetOfflineOperation(-1), undef, >+ 'GetOfflineOperation with wrong parameters returns undef' ); > > #Test GetOfflineOperations > #TODO later: test GetOfflineOperations > # Actually we cannot mock C4::Context->userenv in unit tests > > #Test DeleteOfflineOperation >-is (DeleteOfflineOperation($offline_id),'Deleted.','Offlineoperation has been deleted'); >-#is (DeleteOfflineOperation, undef, 'DeleteOfflineOperation without id returns undef'); >+is( DeleteOfflineOperation($offline_id), >+ 'Deleted.', 'Offlineoperation has been deleted' ); >+ >+#is (DeleteOfflineOperation(), undef, 'DeleteOfflineOperation without id returns undef'); > #is (DeleteOfflineOperation(-1),undef, 'DeleteOfflineOperation with a wrong id returns undef');#FIXME > > #End transaction >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10710
:
20267
|
20349
|
20350
|
20598
|
20599