Bugzilla – Attachment 20518 Details for
Bug 10426
Remove unused sub GetCcodes from C4::Koha
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 10426 Remove unused sub GetCcodes from Koha.pm
Bug-10426-Remove-unused-sub-GetCcodes-from-Kohapm.patch (text/plain), 2.24 KB, created by
Srdjan Jankovic
on 2013-08-21 00:53:52 UTC
(
hide
)
Description:
Bug 10426 Remove unused sub GetCcodes from Koha.pm
Filename:
MIME Type:
Creator:
Srdjan Jankovic
Created:
2013-08-21 00:53:52 UTC
Size:
2.24 KB
patch
obsolete
>From 84e3ac7cc242237603ba109b6ba0531eb1f63c78 Mon Sep 17 00:00:00 2001 >From: Colin Campbell <colin.campbell@ptfs-europe.com> >Date: Thu, 6 Jun 2013 11:42:24 +0100 >Subject: [PATCH] Bug 10426 Remove unused sub GetCcodes from Koha.pm > >Remove uncalled sub GetCcodes > >Also remove comment in opac-search.pl which is >remaining reference to it and serves no >useful purpose > >Signed-off-by: Srdjan <srdjan@catalyst.net.nz> >--- > C4/Koha.pm | 22 ---------------------- > opac/opac-search.pl | 4 ---- > 2 files changed, 26 deletions(-) > >diff --git a/C4/Koha.pm b/C4/Koha.pm >index 6f91b8b..3fb5a70 100644 >--- a/C4/Koha.pm >+++ b/C4/Koha.pm >@@ -41,7 +41,6 @@ BEGIN { > &subfield_is_koha_internal_p > &GetPrinters &GetPrinter > &GetItemTypes &getitemtypeinfo >- &GetCcodes > &GetSupportName &GetSupportList > &get_itemtypeinfos_of > &getframeworks &getframeworkinfo >@@ -286,27 +285,6 @@ END_SQL > return get_infos_of( $query, 'itemtype', undef, \@itemtypes ); > } > >-# this is temporary until we separate collection codes and item types >-sub GetCcodes { >- my $count = 0; >- my @results; >- my $dbh = C4::Context->dbh; >- my $sth = >- $dbh->prepare( >- "SELECT * FROM authorised_values ORDER BY authorised_value"); >- $sth->execute; >- while ( my $data = $sth->fetchrow_hashref ) { >- if ( $data->{category} eq "CCODE" ) { >- $count++; >- $results[$count] = $data; >- >- #warn "data: $data"; >- } >- } >- $sth->finish; >- return ( $count, @results ); >-} >- > =head2 getauthtypes > > $authtypes = &getauthtypes(); >diff --git a/opac/opac-search.pl b/opac/opac-search.pl >index 7d2b7a6..76f4fda 100755 >--- a/opac/opac-search.pl >+++ b/opac/opac-search.pl >@@ -246,10 +246,6 @@ foreach my $advanced_srch_type (@advanced_search_types) { > } > $template->param(advancedsearchesloop => \@advancedsearchesloop); > >-# # load the itypes (Called item types in the template -- just authorized values for searching) >-# my ($itypecount,@itype_loop) = GetCcodes(); >-# $template->param(itypeloop=>\@itype_loop,); >- > # The following should only be loaded if we're bringing up the advanced search template > if ( $template_type && $template_type eq 'advsearch' ) { > # load the servers (used for searching -- to do federated searching, etc.) >-- >1.8.1.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10426
:
18702
|
20518
|
20736