Only reference to routine is in a comment. Delete it Lets not waste time maintaining unused code (and I can see at least 3 things that could be fixed in it, if we were)
Created attachment 18702 [details] [review] proposed patch Removes unused code and comment
Needs removing from t/db_dependent/lib/KohaTest/Koha.pm as well I guess.
In addition to Srdjan's comment, this sub is used in misc/cronjobs/stats/monthly_circulation_statistics.pl To remove the GetCcodes sub, this script will need to be refactored or deleted.
(In reply to Kyle M Hall from comment #3) > In addition to Srdjan's comment, this sub is used in > misc/cronjobs/stats/monthly_circulation_statistics.pl > > To remove the GetCcodes sub, this script will need to be refactored or > deleted. This may not be a long term blocker. See bug 10771.
(In reply to Srdjan Jankovic from comment #2) > Needs removing from t/db_dependent/lib/KohaTest/Koha.pm as well I guess. Yes, but not necessarily a blocker overall: see bug 10539.
On balance, I think the issues raised by Srdjan and Kyle need not block testing and signoff of the proposed patch, although the dependent bugs will block pushing to master. Setting to needs signoff.
Created attachment 20518 [details] [review] Bug 10426 Remove unused sub GetCcodes from Koha.pm Remove uncalled sub GetCcodes Also remove comment in opac-search.pl which is remaining reference to it and serves no useful purpose Signed-off-by: Srdjan <srdjan@catalyst.net.nz>
Created attachment 20736 [details] [review] Everything checks out. Still needs dependencies to pass qa before it could be pushed though.
One of the dependent bugs has been pushed to master, leaving bug 10771, which needs signoff. I encourage anybody interested in seeing this patch get pushed to review the patches for 10771.
Pushed to master. Thanks, Colin!