Bugzilla – Attachment 20813 Details for
Bug 10771
three disused scripts in misc/cronjobs/stats should be removed
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 10771: remove disused statistical reports cronjobs
Bug-10771-remove-disused-statistical-reports-cronj.patch (text/plain), 17.31 KB, created by
Chris Cormack
on 2013-09-06 08:52:48 UTC
(
hide
)
Description:
Bug 10771: remove disused statistical reports cronjobs
Filename:
MIME Type:
Creator:
Chris Cormack
Created:
2013-09-06 08:52:48 UTC
Size:
17.31 KB
patch
obsolete
>From 9d416a7c447caa3ad97364b102a7b764b8f0146f Mon Sep 17 00:00:00 2001 >From: Galen Charlton <gmc@esilibrary.com> >Date: Tue, 20 Aug 2013 19:12:32 +0000 >Subject: [PATCH] Bug 10771: remove disused statistical reports cronjobs > >This patch removes three cronjobs that are believed to be >unused for the following reasons: > >[1] The commit message that introduces them indicates that they > were written for a particular library. A staff member from > that library has confirmed that they are not in use. >[2] The scripts have received essentially no patches since they > were introduced except for being caught up in a broader > code-improvement patch. >[3] They refer to a column that no longer exists in biblioitems. >[4] They no longer adhere to guidelines for command-line utilities, > and there's been no sign that anybody has felt the urge to > correct that. >[5] They are not referenced by another code or the manual, and > the mailing list archives do not include any substantive discussion > of their use. > >Signed-off-by: Galen Charlton <gmc@esilibrary.com> >Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> >--- > .../stats/monthly_circulation_statistics.pl | 168 --------------------- > .../cronjobs/stats/monthly_new_items_statistics.pl | 116 -------------- > .../stats/monthly_new_patron_statistics.pl | 128 ---------------- > 3 files changed, 412 deletions(-) > delete mode 100755 misc/cronjobs/stats/monthly_circulation_statistics.pl > delete mode 100755 misc/cronjobs/stats/monthly_new_items_statistics.pl > delete mode 100755 misc/cronjobs/stats/monthly_new_patron_statistics.pl > >diff --git a/misc/cronjobs/stats/monthly_circulation_statistics.pl b/misc/cronjobs/stats/monthly_circulation_statistics.pl >deleted file mode 100755 >index 1d8ab9f..0000000 >--- a/misc/cronjobs/stats/monthly_circulation_statistics.pl >+++ /dev/null >@@ -1,168 +0,0 @@ >-#!/usr/bin/perl >-#----------------------------------- >-# Script Name: circstats.pl >-# Script Version: 1.0 >-# Date: 2006/02/07 >-# Author: Stephen Hedges (shedges@skemotah.com) >-# Description: >-# This script creates a comma-separated value file of >-# circulation statistics for any given month and year. >-# The statistics are grouped by itemtype, then by branch, >-# then by issues and renewals. >-# Revision History: >-# 1.0 2006/02/07: original version >-#----------------------------------- >-# Contributed 2003-6 by Skemotah Solutions >-# >-# This file is part of Koha. >-# >-# Koha is free software; you can redistribute it and/or modify it under the >-# terms of the GNU General Public License as published by the Free Software >-# Foundation; either version 2 of the License, or (at your option) any later >-# version. >-# >-# Koha is distributed in the hope that it will be useful, but WITHOUT ANY >-# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR >-# A PARTICULAR PURPOSE. See the GNU General Public License for more details. >-# >-# You should have received a copy of the GNU General Public License along with >-# Koha; if not, write to the Free Software Foundation, Inc., 59 Temple Place, >-# Suite 330, Boston, MA 02111-1307 USA >- >-# use strict; >-use warnings; >- >-# UNCOMMENT the following lines if running from a command line >-# print "THIS SCRIPT produces a comma-separated values file of circulation statistics for a given month and year.\n\nDo you wish to continue? (y/n) "; >-# chomp($_ = <STDIN>); >-# die unless (/^y/i); >- >-# UNCOMMENT the following lines if getting old stats (but be aware that renewal numbers are affected by deletes) >-# YOU WILL also need to modify the SQLs to use these dates >-# my ($month,$year); >-# print "Get statistics for which month (1 to 12)? "; >-# chomp($month = <STDIN>); >-# die if ($month < 1 || $month > 12); >-# print "Get statistics for which year (2000 to 2050)? "; >-# chomp($year = <STDIN>); >-# die if ($year < 2000 || $year > 2050); >- >-open OUTFILE, ">circstats.csv" or die "Cannot open file circstats.csv: $!"; >-print OUTFILE "\"ccode\",\"branch\",\"issues\",\"renewals\"\n"; >- >-use C4::Context; >-use C4::Koha; >-use Mail::Sendmail; # comment out 3 lines if not doing e-mail sending of file >-use MIME::QuotedPrint; >-use MIME::Base64; >-# set the e-mail server -- comment out if not doing e-mail notices >-unshift @{$Mail::Sendmail::mailcfg{'smtp'}} , 'localhost'; >-# set your own mail server name here >- >-my $dbh = C4::Context->dbh; >-#my $sth1 = $dbh->prepare ("SELECT itemtype FROM itemtypes ORDER BY itemtype"); >-my $sth2 = $dbh->prepare ("SELECT branchcode, branchname FROM branches ORDER BY branchcode"); >- >-# number of checkouts for this library >-my $sth3 = $dbh->prepare ("SELECT COUNT(*) FROM biblioitems,items,statistics WHERE biblioitems.biblioitemnumber=items.biblioitemnumber AND statistics.itemnumber=items.itemnumber AND items.ccode=? AND YEAR(statistics.datetime)=YEAR(SUBDATE(CURDATE(),INTERVAL 1 MONTH)) AND MONTH(statistics.datetime)=MONTH(SUBDATE(CURDATE(),INTERVAL 1 MONTH)) AND statistics.branch=? AND statistics.type='issue' GROUP BY ccode"); >- >-# number of renewals for this library >-my $sth4 = $dbh->prepare ("SELECT COUNT(statistics.itemnumber) FROM statistics,items,biblioitems >- WHERE YEAR(statistics.datetime)=YEAR(SUBDATE(CURDATE(),INTERVAL 1 MONTH)) >- AND MONTH(statistics.datetime)=MONTH(SUBDATE(CURDATE(),INTERVAL 1 MONTH)) >- AND statistics.itemnumber=items.itemnumber >- AND biblioitems.ccode=? >- AND homebranch=? >- AND biblioitems.biblioitemnumber=items.biblioitemnumber >- AND statistics.type='renew' >- GROUP BY statistics.type"); >- >-# find the itemnumbers >-my ($rowt,$rowb,$rowi,$rowr,$itemtype,$branchcode,$branchname,$issues,$renews,$line); >- >-#$sth1->execute(); >-my ($ccode_count,@ccode_results) = GetCcodes; >- >-#for my $ccode (@ccode_results); >-# loop through every itemtype >-#while ($rowt = $sth1->fetchrow_arrayref) { >-for (my $i=0;$i<scalar(@ccode_results);$i++) { >-#for my $ccode (@ccode_results) { >- unless (!$ccode_results[$i]) { >-# use Data::Dumper; >-# warn Dumper($ccode_results[$i]); >- $itemtype = $ccode_results[$i]{'authorised_value'}; #$ccode->{authorised_value}; #rowt->[0]; >- $line = "\"$itemtype\""; >-# warn "$itemtype\n"; >- # find branchnames >- $sth2->execute(); >- >- # find the number of issues per itemtype in this branch >- while ($rowb = $sth2->fetchrow_arrayref) { >- $branchcode = $rowb->[0]; >- $branchname = $rowb->[1]; >- $sth3->execute($itemtype,$branchcode); # find issues by itemtype per branch >- $rowi = $sth3->fetchrow_arrayref; >- $issues = $rowi->[0]; # count >- unless ($issues) {$issues=""} >- $sth3->finish; >- >- $sth4->execute($itemtype,$branchcode); # find reserves by itemtype per branch >- $rowr = $sth4->fetchrow_arrayref; # count >- $renews = $rowr->[0]; >- unless ($renews) {$renews=""} >- $sth4->finish; >- >- # put the data in this line >- $line = $line . ",\"$branchname\",\"$issues\",\"$renews\""; >-# warn "LINE: $branchname $issues $renews\n"; >- } >- $sth2->finish; >- >- $line = $line . "\n"; >- print OUTFILE "$line"; >- } >-} >-#$sth1->finish; >-close OUTFILE; >-$dbh->disconnect; >- >-# send the outfile as an attachment to the library e-mail >- >-my %attachmail = ( >- from => $from_address, >- to => $to_addresses, >- subject => 'Circulation Statistics', >- ); >- >- >-my $boundary = "====" . time() . "===="; >-$attachmail{'content-type'} = "multipart/mixed; boundary=\"$boundary\""; >- >-my $attachmessage = "Attached is the file of circulation statistics for the previous month. Please open the statistics spreadsheet template for Page 1, open this file in a new spreadsheet, and paste the numbers from this file into the template.\n"; >- >-my $attachfile = "circstats.csv"; >- >-open (F, $attachfile) or die "Cannot read $attachfile: $!"; >-binmode F; undef $/; >-$attachmail{body} = encode_base64(<F>); >-close F; >- >-$boundary = '--'.$boundary; >-$attachmail{body} = <<END_OF_BODY; >-$boundary >-Content-Type: text/plain; charset="iso-8859-1" >-Content-Transfer-Encoding: quoted-printable >- >-$attachmessage >-$boundary >-Content-Type: application/octet-stream; name="circstats.csv" >-Content-Transfer-Encoding: base64 >-Content-Disposition: attachment; filename="circstats.csv" >- >-$attachmail{body} >-$boundary-- >-END_OF_BODY >- >-sendmail(%attachmail) || print "Error: $Mail::Sendmail::error\n"; >- >diff --git a/misc/cronjobs/stats/monthly_new_items_statistics.pl b/misc/cronjobs/stats/monthly_new_items_statistics.pl >deleted file mode 100755 >index d5df701..0000000 >--- a/misc/cronjobs/stats/monthly_new_items_statistics.pl >+++ /dev/null >@@ -1,116 +0,0 @@ >-#!/usr/bin/perl >-#----------------------------------- >-# Script Name: addstats.pl >-# Script Version: 1.0 >-# Date: 2006/02/24 >-# Author: Stephen Hedges (shedges@skemotah.com) >-# Description: >-# This script creates a comma-separated value file of >-# new materials statistics for any given month and year. >-# The statistics are grouped by itemtype. >-# >-# Revision History: >-# 1.0 2006/02/24: original version >-#----------------------------------- >-# Contributed 2003-6 by Skemotah Solutions >-# >-# This file is part of Koha. >-# >-# Koha is free software; you can redistribute it and/or modify it under the >-# terms of the GNU General Public License as published by the Free Software >-# Foundation; either version 2 of the License, or (at your option) any later >-# version. >-# >-# Koha is distributed in the hope that it will be useful, but WITHOUT ANY >-# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR >-# A PARTICULAR PURPOSE. See the GNU General Public License for more details. >-# >-# You should have received a copy of the GNU General Public License along with >-# Koha; if not, write to the Free Software Foundation, Inc., 59 Temple Place, >-# Suite 330, Boston, MA 02111-1307 USA >- >-use warnings; >- >-# UNCOMMENT the following lines if running from a command line >-# print "THIS SCRIPT produces a comma-separated values file of circulation statistics for a given month and year.\n\nDo you wish to continue? (y/n) "; >-# chomp($_ = <STDIN>); >-# die unless (/^y/i); >- >-# UNCOMMENT the following lines if getting old stats (but be aware that renewal numbers are affected by deletes) >-# YOU WILL also need to modify the SQLs to use these dates >-# my ($month,$year); >-# print "Get statistics for which month (1 to 12)? "; >-# chomp($month = <STDIN>); >-# die if ($month < 1 || $month > 12); >-# print "Get statistics for which year (2000 to 2050)? "; >-# chomp($year = <STDIN>); >-# die if ($year < 2000 || $year > 2050); >- >-open OUTFILE, ">addstats.csv" or die "Cannot open file addstats.csv: $!"; >-print OUTFILE "\"type\",\"count\"\n"; >- >-use C4::Context; >-use Mail::Sendmail; # comment out 3 lines if not doing e-mail sending of file >-use MIME::QuotedPrint; >-use MIME::Base64; >-# set the e-mail server -- comment out if not doing e-mail notices >-unshift @{$Mail::Sendmail::mailcfg{'smtp'}} , 'localhost'; >-# set your own mail server name here >- >-my $dbh = C4::Context->dbh; >- >-my $sth = $dbh->prepare ("SELECT biblioitems.ccode,COUNT(biblioitems.ccode) FROM items,biblioitems WHERE YEAR(items.dateaccessioned)=YEAR(SUBDATE(CURDATE(),INTERVAL 1 MONTH)) AND MONTH(items.dateaccessioned)=MONTH(SUBDATE(CURDATE(),INTERVAL 1 MONTH)) AND biblioitems.biblioitemnumber=items.biblioitemnumber GROUP BY biblioitems.ccode"); >- >-my ($row,$itemtype,$count); >- >-$sth->execute(); >- >-while ($row = $sth->fetchrow_arrayref) { >- $itemtype = $row->[0]; >- $count = $row->[1]; >- >- print OUTFILE "$itemtype,$count\n"; >-} >-$sth->finish; >-close OUTFILE; >-$dbh->disconnect; >- >-# send the outfile as an attachment to the library e-mail >- >-my %attachmail = ( >- from => $from_address, >- to => $to_addresses, >- subject => 'New Items Statistics', >- ); >- >- >-my $boundary = "====" . time() . "===="; >-$attachmail{'content-type'} = "multipart/mixed; boundary=\"$boundary\""; >- >-my $attachmessage = "Attached is the file of new materials statistics for the previous month. Please use this file to calculate the values for the adds spreadsheet.\n"; >- >-my $attachfile = "addstats.csv"; >- >-open (F, $attachfile) or die "Cannot read $attachfile: $!"; >-binmode F; undef $/; >-$attachmail{body} = encode_base64(<F>); >-close F; >- >-$boundary = '--'.$boundary; >-$attachmail{body} = <<END_OF_BODY; >-$boundary >-Content-Type: text/plain; charset="iso-8859-1" >-Content-Transfer-Encoding: quoted-printable >- >-$attachmessage >-$boundary >-Content-Type: application/octet-stream; name="addstats.csv" >-Content-Transfer-Encoding: base64 >-Content-Disposition: attachment; filename="addstats.csv" >- >-$attachmail{body} >-$boundary-- >-END_OF_BODY >- >-sendmail(%attachmail) || print "Error: $Mail::Sendmail::error\n"; >- >diff --git a/misc/cronjobs/stats/monthly_new_patron_statistics.pl b/misc/cronjobs/stats/monthly_new_patron_statistics.pl >deleted file mode 100755 >index 2ef2a14..0000000 >--- a/misc/cronjobs/stats/monthly_new_patron_statistics.pl >+++ /dev/null >@@ -1,128 +0,0 @@ >-#!/usr/bin/perl >-#----------------------------------- >-# Script Name: borrstats.pl >-# Script Version: 1.0 >-# Date: 2006/02/24 >-# Author: Stephen Hedges (shedges@skemotah.com) >-# Description: >-# This script creates a comma-separated value file of >-# new borrower statistics for any given month and year. >-# The statistics are grouped by borrower type, then by >-# branch. >-# Revision History: >-# 1.0 2006/02/24: original version >-#----------------------------------- >-# Contributed 2003-6 by Skemotah Solutions >-# >-# This file is part of Koha. >-# >-# Koha is free software; you can redistribute it and/or modify it under the >-# terms of the GNU General Public License as published by the Free Software >-# Foundation; either version 2 of the License, or (at your option) any later >-# version. >-# >-# Koha is distributed in the hope that it will be useful, but WITHOUT ANY >-# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR >-# A PARTICULAR PURPOSE. See the GNU General Public License for more details. >-# >-# You should have received a copy of the GNU General Public License along with >-# Koha; if not, write to the Free Software Foundation, Inc., 59 Temple Place, >-# Suite 330, Boston, MA 02111-1307 USA >- >-# use strict; >-use warnings; >- >-# UNCOMMENT the following lines if running from a command line >-# print "THIS SCRIPT produces a comma-separated values file of circulation statistics for a given month and year.\n\nDo you wish to continue? (y/n) "; >-# chomp($_ = <STDIN>); >-# die unless (/^y/i); >- >-# UNCOMMENT the following lines if getting old stats (but be aware that renewal numbers are affected by deletes) >-# YOU WILL also need to modify the SQLs to use these dates >-# my ($month,$year); >-# print "Get statistics for which month (1 to 12)? "; >-# chomp($month = <STDIN>); >-# die if ($month < 1 || $month > 12); >-# print "Get statistics for which year (2000 to 2050)? "; >-# chomp($year = <STDIN>); >-# die if ($year < 2000 || $year > 2050); >- >-open OUTFILE, ">borrstats.csv" or die "Cannot open file borrstats.csv: $!"; >-print OUTFILE "\"type\",\"branch\",\"count\"\n"; >- >-use C4::Context; >-use Mail::Sendmail; # comment out 3 lines if not doing e-mail sending of file >-use MIME::QuotedPrint; >-use MIME::Base64; >-# set the e-mail server -- comment out if not doing e-mail notices >-unshift @{$Mail::Sendmail::mailcfg{'smtp'}} , 'localhost'; >-# set your own mail server name here >- >-my $dbh = C4::Context->dbh; >-my $sth1 = $dbh->prepare ("SELECT categorycode FROM categories ORDER BY categorycode"); >-my $sth2 = $dbh->prepare ("SELECT branchcode,COUNT(branchcode) FROM borrowers WHERE categorycode=? AND YEAR(dateenrolled)=YEAR(SUBDATE(CURDATE(),INTERVAL 1 MONTH)) AND MONTH(dateenrolled)=MONTH(SUBDATE(CURDATE(),INTERVAL 1 MONTH)) GROUP BY branchcode"); >- >-my ($rowc,$rowb,$categorycode,$branchcode,$count,$line); >- >-$sth1->execute(); >- >-while ($rowc = $sth1->fetchrow_arrayref) { >- $categorycode = $rowc->[0]; >- $line = "\"$categorycode\""; >- >- $sth2->execute($categorycode); >- >- while ($rowb = $sth2->fetchrow_arrayref) { >- $branchcode = $rowb->[0]; >- $count = $rowb->[1]; >- >- $line = $line . ",\"$branchcode\",\"$count\""; >- } >- $sth2->finish; >- >- $line = $line . "\n"; >- print OUTFILE "$line"; >-} >-$sth1->finish; >-close OUTFILE; >-$dbh->disconnect; >- >-# send the outfile as an attachment to the library e-mail >- >-my %attachmail = ( >- from => $from_address, >- to => $to_addresses, >- subject => 'New Patrons Statistics', >- ); >- >- >-my $boundary = "====" . time() . "===="; >-$attachmail{'content-type'} = "multipart/mixed; boundary=\"$boundary\""; >- >-my $attachmessage = "Attached is the file of new borrower statistics for the previous month. Please open the statistics spreadsheet for Page 2, open this file in a new spreadsheet, and paste the numbers from this file into the statistics spreadsheet.\n"; >- >-my $attachfile = "borrstats.csv"; >- >-open (F, $attachfile) or die "Cannot read $attachfile: $!"; >-binmode F; undef $/; >-$attachmail{body} = encode_base64(<F>); >-close F; >- >-$boundary = '--'.$boundary; >-$attachmail{body} = <<END_OF_BODY; >-$boundary >-Content-Type: text/plain; charset="iso-8859-1" >-Content-Transfer-Encoding: quoted-printable >- >-$attachmessage >-$boundary >-Content-Type: application/octet-stream; name="borrstats.csv" >-Content-Transfer-Encoding: base64 >-Content-Disposition: attachment; filename="borrstats.csv" >- >-$attachmail{body} >-$boundary-- >-END_OF_BODY >- >-sendmail(%attachmail) || print "Error: $Mail::Sendmail::error\n"; >- >-- >1.8.4.rc2
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=20813">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10771
:
20510
|
20813
|
20834