Attachment 21305 Details for Bug 10911 – [SIGNED-OFF] Bug 10911 - Records with 880 fields have broken details links in intranet search results using XSLT.

[patch] [SIGNED-OFF] Bug 10911 - Records with 880 fields have broken details links in intranet search results using XSLT.

SIGNED-OFF-Bug-10911---Records-with-880-fields-hav.patch (text/plain), 3.27 KB, created by Bernardo Gonzalez Kriegel on 2013-09-21 23:17:55 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Bernardo Gonzalez Kriegel

Created: 2013-09-21 23:17:55 UTC

Size: 3.27 KB

patch

obsolete

>From e698259748895066052333f0ecce65b62e8d5191 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Wed, 18 Sep 2013 15:24:08 -0400
>Subject: [PATCH] [SIGNED-OFF] Bug 10911 - Records with 880 fields have broken
> details links in intranet search results using XSLT.
>
>Koha intranet search results using XSLT for records with 880 fields have
>the details link created by a code path that incorrectly links to some
>opac pages.
>
>Test Plan:
>1) Enable XSLT for intranet search results
>2) Upload or create a record with at least one 880 field
>3) Search for the item ( must have multiple hits to avoid redirection )
>4) Click the title link, note it is broken
>5) Apply this patch
>6) Click the title link, note it is correct
>
>Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
>Comment: Work as described, no koha-qa errors.
>
>Test
>1) imported two times sample record
>2) reindex
>3) search, find example record, broken links
>4) applied patch
>5) refresh, good links
>
>NOTE: A similar (invalid references) problem is present on
>UNIMARC and NORMAC files
>I'll file a new bug for those cases.
>---
> .../intranet-tmpl/prog/en/xslt/MARC21slimUtils.xsl |    6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slimUtils.xsl b/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slimUtils.xsl
>index 151fc7b..7334d03 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slimUtils.xsl
>+++ b/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slimUtils.xsl
>@@ -164,19 +164,19 @@
>                     <xsl:choose>
>                         <xsl:when test="boolean($bibno)">
>                             <a>
>-                                <xsl:attribute name="href">/cgi-bin/koha/opac-detail.pl?biblionumber=<xsl:value-of  select="$bibno"/></xsl:attribute>
>+                                <xsl:attribute name="href">/cgi-bin/koha/catalogue/detail.pl?biblionumber=<xsl:value-of  select="$bibno"/></xsl:attribute>
>                                 <xsl:value-of select="$str"/>
>                             </a>
>                         </xsl:when>
>                        <xsl:when test="boolean($index) and boolean(marc:subfield[@code=9]) and $UseAuthoritiesForTracings='1'">
>                             <a>
>-                                <xsl:attribute name="href">/cgi-bin/koha/opac-search.pl?q=an:<xsl:value-of  select="marc:subfield[@code=9]"/></xsl:attribute>
>+                                <xsl:attribute name="href">/cgi-bin/koha/catalogue/search.pl?q=an:<xsl:value-of  select="marc:subfield[@code=9]"/></xsl:attribute>
>                                   <xsl:value-of select="$str"/>
>                             </a>
>                         </xsl:when>
>                         <xsl:when test="boolean($index)">
>                             <a>
>-                                <xsl:attribute name="href">/cgi-bin/koha/opac-search.pl?q=<xsl:value-of  select="$index"/>:<xsl:value-of  select="marc:subfield[@code='a']"/></xsl:attribute>
>+                                <xsl:attribute name="href">/cgi-bin/koha/catalogue/search.pl?q=<xsl:value-of  select="$index"/>:<xsl:value-of  select="marc:subfield[@code='a']"/></xsl:attribute>
>                                 <xsl:value-of select="$str"/>
>                             </a>
>                         </xsl:when>
>-- 
>1.7.9.5

Actions: View | Diff | Splinter Review

Attachments on bug 10911: 21213 | 21214 | 21305 | 21308