Bug 10911 - Records with 880 fields have broken details links in intranet search results using XSLT.
Summary: Records with 880 fields have broken details links in intranet search results ...
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Kyle M Hall
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-18 19:23 UTC by Kyle M Hall
Modified: 2014-05-26 21:04 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 10911 - Records with 880 fields have broken details links in intranet search results using XSLT. (2.89 KB, patch)
2013-09-18 19:26 UTC, Kyle M Hall
Details | Diff | Splinter Review
Example record with 880 fields (1.77 KB, text/plain)
2013-09-18 19:28 UTC, Kyle M Hall
Details
[SIGNED-OFF] Bug 10911 - Records with 880 fields have broken details links in intranet search results using XSLT. (3.27 KB, patch)
2013-09-21 23:17 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review
[PASSED QA] Bug 10911 - Records with 880 fields have broken details links in intranet search results using XSLT. (3.40 KB, patch)
2013-09-22 08:59 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle M Hall 2013-09-18 19:23:35 UTC
Koha intranet search results using XSLT for records with 880 fields have the details link created by a code path that incorrectly links to some opac pages.
Comment 1 Kyle M Hall 2013-09-18 19:26:52 UTC Comment hidden (obsolete)
Comment 2 Kyle M Hall 2013-09-18 19:28:31 UTC
Created attachment 21214 [details]
Example record with 880 fields
Comment 3 Bernardo Gonzalez Kriegel 2013-09-21 23:17:55 UTC Comment hidden (obsolete)
Comment 4 Katrin Fischer 2013-09-22 08:59:48 UTC
Created attachment 21308 [details] [review]
[PASSED QA] Bug 10911 - Records with 880 fields have broken details links in intranet search results using XSLT.

Koha intranet search results using XSLT for records with 880 fields have
the details link created by a code path that incorrectly links to some
opac pages.

Test Plan:
1) Enable XSLT for intranet search results
2) Upload or create a record with at least one 880 field
3) Search for the item ( must have multiple hits to avoid redirection )
4) Click the title link, note it is broken
5) Apply this patch
6) Click the title link, note it is correct

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Comment: Work as described, no koha-qa errors.

Test
1) imported two times sample record
2) reindex
3) search, find example record, broken links
4) applied patch
5) refresh, good links

NOTE: A similar (invalid references) problem is present on
UNIMARC and NORMAC files
I'll file a new bug for those cases.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works nicely, tested with a different set of sample
records with Hebrew 880 fields.
Comment 5 Galen Charlton 2013-09-23 17:14:09 UTC
Pushed to master.  Thanks, Kyle!
Comment 6 Tomás Cohen Arazi 2013-11-13 16:25:22 UTC
This patch has been pushed to 3.12.x, will be in 3.12.7.

Thanks Kyle!