Bugzilla – Attachment 22388 Details for
Bug 11128
On cancelling receipt, the order is still listed in the received orders
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
On cancelling receipt, the order is still listed in the received orders
0001-Bug-11128-On-cancelling-receipt-the-order-is-still-l.patch (text/plain), 1.46 KB, created by
Paola Rossi
on 2013-10-25 10:54:31 UTC
(
hide
)
Description:
On cancelling receipt, the order is still listed in the received orders
Filename:
MIME Type:
Creator:
Paola Rossi
Created:
2013-10-25 10:54:31 UTC
Size:
1.46 KB
patch
obsolete
>From 743b45641135795f3794284a21aaa07d8ac13c71 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Thu, 24 Oct 2013 12:21:14 +0200 >Subject: [PATCH] Bug 11128: On cancelling receipt, the order is still listed > in the received orders > >Cause: The list of received orders is built *before* cancelling the receipt! > >Test plan: >0/ don't apply the patch >1/ create a basket >2/ create an order with 3 items >3/ receive 1 item >4/ cancel the receipt >=> The order is still listed in the received orders table! >5/ apply the patch >6/ do again steps 1 to 4 >=> The order is not listed in the received orders table. > >Signed-off-by: Paola Rossi <paola.rossi@cineca.it> >--- > acqui/parcel.pl | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > >diff --git a/acqui/parcel.pl b/acqui/parcel.pl >index 028e957..61ec330 100755 >--- a/acqui/parcel.pl >+++ b/acqui/parcel.pl >@@ -119,7 +119,7 @@ my ($template, $loggedinuser, $cookie) > > my $invoiceid = $input->param('invoiceid'); > my $invoice; >-$invoice = GetInvoiceDetails($invoiceid) if $invoiceid; >+$invoice = GetInvoice($invoiceid) if $invoiceid; > > unless( $invoiceid and $invoice->{invoiceid} ) { > $template->param( >@@ -140,6 +140,8 @@ if ($op eq 'cancelreceipt') { > } > } > >+$invoice = GetInvoiceDetails($invoiceid) if $invoiceid; >+ > my $booksellerid = $invoice->{booksellerid}; > my $bookseller = GetBookSellerFromId($booksellerid); > my $gst = $bookseller->{gstrate} // C4::Context->preference("gist") // 0; >-- >1.7.10.4 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 11128
:
22350
|
22388
|
22437