Bug 11128 - On cancelling receipt, the order is still listed in the received orders
Summary: On cancelling receipt, the order is still listed in the received orders
Status: RESOLVED DUPLICATE of bug 11108
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P5 - low major (vote)
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-24 10:22 UTC by Jonathan Druart
Modified: 2013-10-27 04:13 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 11128: On cancelling receipt, the order is still listed in the received orders (1.41 KB, patch)
2013-10-24 10:27 UTC, Jonathan Druart
Details | Diff | Splinter Review
On cancelling receipt, the order is still listed in the received orders (1.46 KB, patch)
2013-10-25 10:54 UTC, Paola Rossi
Details | Diff | Splinter Review
[PASSED QA] Bug 11128: On cancelling receipt, the order is still listed in the received orders (1.58 KB, patch)
2013-10-27 03:41 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2013-10-24 10:22:59 UTC

    
Comment 1 Jonathan Druart 2013-10-24 10:27:00 UTC Comment hidden (obsolete)
Comment 2 Paola Rossi 2013-10-25 10:54:31 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2013-10-27 03:41:09 UTC
Created attachment 22437 [details] [review]
[PASSED QA] Bug 11128: On cancelling receipt, the order is still listed in the received orders

Cause: The list of received orders is built *before* cancelling the receipt!

Test plan:
0/ don't apply the patch
1/ create a basket
2/ create an order with 3 items
3/ receive 1 item
4/ cancel the receipt
=> The order is still listed in the received orders table!
5/ apply the patch
6/ do again steps 1 to 4
=> The order is not listed in the received orders table.

Signed-off-by: Paola Rossi <paola.rossi@cineca.it>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works as described and passes all tests and QA script.
Comment 4 Katrin Fischer 2013-10-27 04:13:28 UTC
Marking as duplicate of 11108 - I have tested both patches and they both work. Bug 11108 looks a bit cleaner to me and also fixes a warn, but leaving final decision to Galen.

*** This bug has been marked as a duplicate of bug 11108 ***