Attachment 22467 Details for Bug 11146 – Bug 11146 - Show a go back link on no permission page

[patch] Bug 11146 - Show a go back link on no permission page

0001-Bug-11146-Show-a-go-back-link-on-no-permission-page.patch (text/plain), 2.82 KB, created by Fridolin Somers on 2013-10-28 12:57:09 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Fridolin Somers

Created: 2013-10-28 12:57:09 UTC

Size: 2.82 KB

patch

obsolete

>From a33dd0f17c2617d6139d433f6c343f12be9a0e7f Mon Sep 17 00:00:00 2001
>From: Fridolyn SOMERS <fridolyn.somers@biblibre.com>
>Date: Mon, 28 Oct 2013 13:46:06 +0100
>Subject: [PATCH] Bug 11146 - Show a go back link on no permission page
>
>When a user has not the permission for a page or module, the authentication page is displayed with message : "Error: You do not have permission to access this page.".
>Most librarians uses the "previous page" button of there browser to come back on the page they where before trying to get to this non-permitted page.
>
>This patch adds a button to help comming back to previous page.
>Also moves the link "Click to log out" as a button.
>
>Test plan :
>- Define a user with staff permissions but no permission on tools module
>- Login with this user
>=> You get to intranet home page
>- Edit URL to go to tools module : cgi-bin/koha/tools/tools-home.pl
>=> You get a page with a red error message and 2 buttons "Previous page" and "Log out"
>- Click on "Previous page"
>=> Go get to intranet home page
>- Edit URL to go to tools module : cgi-bin/koha/tools/tools-home.pl
>- Click on "Log out" button
>=> You are logged-out and get to authentication page : cgi-bin/koha/mainpage.pl?logout.x=1
>---
> koha-tmpl/intranet-tmpl/prog/en/css/login.css   | 11 ++++++++++-
> koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt |  9 ++++++++-
> 2 files changed, 18 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/css/login.css b/koha-tmpl/intranet-tmpl/prog/en/css/login.css
>index cbb7d81..6712f92 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/css/login.css
>+++ b/koha-tmpl/intranet-tmpl/prog/en/css/login.css
>@@ -115,11 +115,20 @@ label {
> 	width : 99%;
> }
> 
>-#login #submit {
>+#login #submit, #login .button {
> 	font-size: 1.4em;
> 	padding : .3em .6em;
> }
> 
>+#login #onerror_actions {
>+    margin-bottom: 1em;
>+    text-align: center;
>+}
>+
>+#login #onerror_actions .button {
>+    margin: 3px;
>+    color: #333333;
>+}
> 
> #footer {
>         text-align: center;
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt
>index c0b3f99..5f97758 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt
>@@ -16,7 +16,14 @@
> <div id="login">
> <h1><a href="http://koha-community.org">Koha</a></h1>
> [% IF ( nopermission ) %]
>-<div id="login_error"><strong>Error:</strong> You do not have permission to access this page. <a href="/cgi-bin/koha/mainpage.pl?logout.x=1">Click to log out</a></div>
>+<div id="login_error">
>+    <strong>Error:</strong>
>+    You do not have permission to access this page.
>+</div>
>+<div id="onerror_actions">
>+    <a href="javascript:window.history.back()" class="button">Previous page</a>
>+    <a href="/cgi-bin/koha/mainpage.pl?logout.x=1" class="button">Log out</a>
>+</div>
> [% END %]
> 
> [% IF ( timed_out ) %]
>-- 
>1.8.3.2
>

Actions: View | Diff | Splinter Review

Attachments on bug 11146: 22467 | 23048 | 23094