Attachment 22561 Details for Bug 10807 – Bug 10807: FIX if zebra is down, total is undef

[patch] Bug 10807: FIX if zebra is down, total is undef

Bug-10807-FIX-if-zebra-is-down-total-is-undef.patch (text/plain), 1.08 KB, created by Jonathan Druart on 2013-10-30 08:51:59 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2013-10-30 08:51:59 UTC

Size: 1.08 KB

patch

obsolete

>From 190309f089e81b9a085fa42c44f1875ca680863c Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@biblibre.com>
>Date: Tue, 3 Sep 2013 09:32:12 +0200
>Subject: [PATCH] Bug 10807: FIX if zebra is down, total is undef
>
>The search_history.total column cannot be undef. This patch adds a
>default value for the total value.
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>
>This change doesn't negatively affect search history as far as I can
>tell but I also can't reproduce the bug it is meant to fix, so take this
>signoff with a grain of salt.
>---
> C4/Search/History.pm |    2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/C4/Search/History.pm b/C4/Search/History.pm
>index 4a5d78b..7afdd1e 100644
>--- a/C4/Search/History.pm
>+++ b/C4/Search/History.pm
>@@ -15,7 +15,7 @@ sub add {
>     my $sessionid = $params->{sessionid};
>     my $query_desc = $params->{query_desc};
>     my $query_cgi = $params->{query_cgi};
>-    my $total = $params->{total};
>+    my $total = $params->{total} // 0;
>     my $type = $params->{type} || 'biblio';
> 
>     my $dbh = C4::Context->dbh;
>-- 
>1.7.10.4

Actions: View | Diff | Splinter Review

Attachments on bug 10807: 20734 | 20764 | 20951 | 20952 | 20988 | 20989 | 20990 | 21070 | 21362 | 21363 | 21403 | 22560 | 22561 | 22562 | 22563 | 22564 | 22565 | 23676 | 23677 | 23678 | 23679 | 23680 | 23681 | 23682 | 23712 | 24221 | 24222 | 24223 | 24224 | 24225 | 24226 | 27372 | 27373 | 27374 | 27375 | 27376 | 27377 | 27378