Attachment 22869 Details for Bug 10855 – Bug 10855: Filtering on additional fields don't work if value is equal to 0

[patch] Bug 10855: Filtering on additional fields don't work if value is equal to 0

Bug-10855-Filtering-on-additional-fields-dont-work.patch (text/plain), 1.74 KB, created by Jonathan Druart on 2013-11-12 10:09:54 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2013-11-12 10:09:54 UTC

Size: 1.74 KB

patch

obsolete

>From 85b2d7040da3030594138fb735b794ba556f28a6 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@biblibre.com>
>Date: Tue, 12 Nov 2013 11:05:17 +0100
>Subject: [PATCH] Bug 10855: Filtering on additional fields don't work if
> value is equal to 0
>
>If you tried to filter on an additional field linked to an authorised
>value, that did not work if the value was 0.
>---
> C4/Serials.pm             |    2 +-
> serials/serials-search.pl |    2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/C4/Serials.pm b/C4/Serials.pm
>index 1ef8413..da49a2e 100644
>--- a/C4/Serials.pm
>+++ b/C4/Serials.pm
>@@ -655,7 +655,7 @@ sub SearchSubscriptions {
>     my $matching_record_ids_for_additional_fields = [];
>     if ( @$additional_fields ) {
>         $matching_record_ids_for_additional_fields = Koha::AdditionalField->get_matching_record_ids({
>-                fields => $args->{additional_fields},
>+                fields => $additional_fields,
>                 tablename => 'subscription',
>                 exact_match => 0,
>         });
>diff --git a/serials/serials-search.pl b/serials/serials-search.pl
>index 50dab9a..6f924a3 100755
>--- a/serials/serials-search.pl
>+++ b/serials/serials-search.pl
>@@ -76,7 +76,7 @@ if ( $op and $op eq "close" ) {
> my $additional_fields = Koha::AdditionalField->all( { table => 'subscription', searchable => 1 } );
> my $additional_field_filters;
> for my $field ( @$additional_fields ) {
>-    if ( my $filter_value = $query->param('additional_field_' . $field->{id} . '_filter') ) {
>+    if ( defined ( my $filter_value = $query->param('additional_field_' . $field->{id} . '_filter') ) ) {
>         $additional_field_filters->{ $field->{name} } = $filter_value;
>     }
>     if ( $field->{authorised_value_category} ) {
>-- 
>1.7.10.4

Actions: View | Diff | Splinter Review

Attachments on bug 10855: 20937 | 20938 | 20939 | 20940 | 20941 | 20942 | 20943 | 20944 | 21184 | 21185 | 21186 | 21187 | 21188 | 21189 | 21190 | 21191 | 21663 | 22049 | 22050 | 22051 | 22052 | 22053 | 22054 | 22055 | 22056 | 22057 | 22359 | 22360 | 22600 | 22601 | 22602 | 22603 | 22604 | 22605 | 22606 | 22607 | 22608 | 22616 | 22698 | 22699 | 22700 | 22701 | 22702 | 22703 | 22722 | 22768 | 22769 | 22869 | 23052 | 23053 | 23142 | 23143 | 23301 | 23302 | 23594 | 23595 | 23596 | 23597 | 23598 | 23599 | 23600 | 23601 | 23602 | 23774 | 23775 | 23961 | 23962 | 23963 | 23964 | 24452 | 24453 | 24454 | 24455 | 24456 | 24457 | 24569 | 24570 | 26091 | 26092 | 26093 | 26094 | 26095 | 26096 | 26097 | 26254 | 26255 | 26256 | 26257 | 26258 | 26259 | 26260 | 26276 | 26651 | 26655 | 28929 | 28930 | 28931 | 28932 | 28933 | 28934 | 28935 | 28936 | 28937 | 28938 | 28939 | 28940 | 28941 | 29095 | 29161 | 35211 | 35212 | 35213 | 35214 | 35215 | 35216 | 35217 | 35218 | 35219 | 35220 | 35221 | 35309 | 35310 | 35369 | 35556 | 36359 | 36362 | 36363 | 36364 | 36365 | 36366 | 36367 | 36368 | 36369 | 36370 | 36371 | 36372 | 36373 | 36374 | 38549 | 38550 | 38551 | 38552 | 38553 | 38554 | 38555 | 38556 | 38557 | 38558 | 38559 | 38560 | 38561 | 42296 | 42297 | 42298 | 42299 | 42300 | 42301 | 42302 | 42303 | 42304 | 42305 | 42306 | 42307 | 42308 | 42309 | 42310 | 42332 | 42333 | 43076