Attachment 23004 Details for Bug 8683 – [SIGNED-OFF] Bug 8683: Clear button doesn't clear all item fields

[patch] [SIGNED-OFF] Bug 8683: Clear button doesn't clear all item fields

SIGNED-OFF-Bug-8683-Clear-button-doesnt-clear-all-.patch (text/plain), 2.64 KB, created by Owen Leonard on 2013-11-18 17:31:04 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Leonard

Created: 2013-11-18 17:31:04 UTC

Size: 2.64 KB

patch

obsolete

>From 1e6e25fbf195b7a08b20bc03f7d35c7d606fa5b3 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@biblibre.com>
>Date: Wed, 13 Nov 2013 11:33:05 +0100
>Subject: [PATCH] [SIGNED-OFF] Bug 8683: Clear button doesn't clear all item
> fields
>Content-Type: text/plain; charset="utf-8"
>
>The clear js function parses input text, but input filled to a plugin
>does not contain the type attribute.
>
>Test plan:
>- fill the barcode field to the barcode plugin
>- go on the new order page
>- verify the barcode plugin works as before
>- verify the clear link clears the barcode field and all others fields.
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>---
> C4/Items.pm |    4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/C4/Items.pm b/C4/Items.pm
>index 073d6f7..231e5c4 100644
>--- a/C4/Items.pm
>+++ b/C4/Items.pm
>@@ -2797,14 +2797,14 @@ sub PrepareItemrecordDisplay {
>                             my $extended_param = plugin_parameters( $dbh, undef, $tagslib, $subfield_data{id}, undef );
>                             my ( $function_name, $javascript ) = plugin_javascript( $dbh, undef, $tagslib, $subfield_data{id}, undef );
>                             $subfield_data{random}     = int(rand(1000000));    # why do we need 2 different randoms?
>-                            $subfield_data{marc_value} = qq[<input tabindex="1" id="$subfield_data{id}" name="field_value" class="input_marceditor" size="67" maxlength="255"
>+                            $subfield_data{marc_value} = qq[<input type="text" tabindex="1" id="$subfield_data{id}" name="field_value" class="input_marceditor" size="67" maxlength="255"
>                                 onfocus="Focus$function_name($subfield_data{random}, '$subfield_data{id}');"
>                                  onblur=" Blur$function_name($subfield_data{random}, '$subfield_data{id}');" />
>                                 <a href="#" class="buttonDot" onclick="Clic$function_name('$subfield_data{id}'); return false;" title="Tag Editor">...</a>
>                                 $javascript];
>                         } else {
>                             warn "Plugin Failed: $plugin";
>-                            $subfield_data{marc_value} = qq(<input tabindex="1" id="$subfield_data{id}" name="field_value" class="input_marceditor" size="67" maxlength="255" />); # supply default input form
>+                            $subfield_data{marc_value} = qq(<input type="text" tabindex="1" id="$subfield_data{id}" name="field_value" class="input_marceditor" size="67" maxlength="255" />); # supply default input form
>                         }
>                 }
>                 elsif ( $tag eq '' ) {       # it's an hidden field
>-- 
>1.7.9.5

Actions: View | Diff | Splinter Review

Attachments on bug 8683: 22896 | 23004 | 23047