Bug 8683 - Acq: Clear button doesn't clear all item fields
Summary: Acq: Clear button doesn't clear all item fields
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Jonathan Druart
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-24 06:31 UTC by Katrin Fischer
Modified: 2015-06-04 23:23 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 8683: Clear button doesn't clear all item fields (2.53 KB, patch)
2013-11-13 10:36 UTC, Jonathan Druart 		Details | Diff | Splinter Review
[SIGNED-OFF] Bug 8683: Clear button doesn't clear all item fields (2.64 KB, patch)
2013-11-18 17:31 UTC, Owen Leonard 		Details | Diff | Splinter Review
[PASSED QA] Bug 8683: Clear button doesn't clear all item fields (2.92 KB, patch)
2013-11-19 22:20 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2012-08-24 06:31:00 UTC 
UniqueItemFields: barcode
AcqCreateItem: placing an order
Autobarcode: 1, 2, 3...

When you add items to a new order, the clear link doesn't work for some of the fields. 

It doesn't work for:
- date acquired
- barcode

Maybe because of the plugins linked to those fields?
Comment 1 Jonathan Druart 2013-11-13 10:36:22 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2013-11-18 17:31:04 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2013-11-19 22:20:14 UTC 
Created attachment 23047 [details] [review]
[PASSED QA] Bug 8683: Clear button doesn't clear all item fields

The clear js function parses input text, but input filled to a plugin
does not contain the type attribute.

Test plan:
- fill the barcode field to the barcode plugin
- go on the new order page
- verify the barcode plugin works as before
- verify the clear link clears the barcode field and all others fields.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works as expected, passes all tests and QA script.
Template change only.
Barcode and date acquired are now also cleared with the
'clear' link.

But: it only works when you enter a barcode manually currently,
because the AutoBarcode functionality is broken on master (bug 11273).
Comment 4 Galen Charlton 2013-12-10 03:38:50 UTC 
Pushed to master.  Thanks, Jonathan!
Comment 5 Fridolin Somers 2013-12-24 09:47:01 UTC 
Patch pushed to 3.14.x, will be in 3.14.2.
Comment 6 Tomás Cohen Arazi (tcohen) 2014-01-13 15:28:36 UTC 
This patch has been pushed to 3.12.x, will be in 3.12.9.

Thanks Jonathan!