Attachment 23022 Details for Bug 11264 – Bug 11264: Add German seasons to serials

[patch] Bug 11264: Add German seasons to serials

Bug-11264-Add-German-seasons-to-serials.patch (text/plain), 1.87 KB, created by Jonathan Druart on 2013-11-19 09:08:38 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2013-11-19 09:08:38 UTC

Size: 1.87 KB

patch

obsolete

>From b0836cfc71cac33896b666b2db5473ccd8303001 Mon Sep 17 00:00:00 2001
>From: Katrin Fischer <Katrin.Fischer.83@web.de>
>Date: Mon, 18 Nov 2013 00:44:50 +0100
>Subject: [PATCH] Bug 11264: Add German seasons to serials
>
>This patch adds the German season names to the serials module.
>
>Requirements: You must have a German locale de_* on your system.
>
>To test:
>- Add a new subscription in the serials module
>- Create a subscription for 1/3 months, seasonal
>- Begins with and inner counter should both be 0
>- Year can be 2013 and second row empty
>- Pick de* as a locale[1]
>- Test the prediction pattern - it should tell you German seasons now
>- Save the subscription - make sure the issues are crated with German
>  seasons as well
>
>[1] It seems you have to pick it explicitly - the fallback to the
>    system locale noted on the field didn't work for me.
>
>Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
>
>Work as described. No koha-qa errors.
>
>Installed de_DE.UTF-8 and fr_FR.UTF-8 locales
>Add new suscription, picked locale manually (de_DE in this case)
>Prediction pattern shows correct labels (to selected locale)
>Received issues generated with correct numbering
>
>Really don't know at this moment how this could be added to
>general translation. I'm tempted to add a followup for Spanish
>
>Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
>---
> C4/Serials.pm |    2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/C4/Serials.pm b/C4/Serials.pm
>index 6d188e7..ee28a85 100644
>--- a/C4/Serials.pm
>+++ b/C4/Serials.pm
>@@ -2690,6 +2690,8 @@ sub _numeration {
>                     [qw(Spring Summer Fall Winter)],
>                  "fr"=>
>                     [qw(Printemps ÃtÃ© Automne Hiver)],
>+                 "de"=>
>+                    [qw(FrÃ¼hling Sommer Herbst Winter)],
>               );
>               $value = $value % 4;
>               $string = ($seasons{$seasonlocale})
>-- 
>1.7.10.4

Actions: View | Diff | Splinter Review

Attachments on bug 11264: 22991 | 23007 | 23022