Bugzilla – Attachment 23047 Details for
Bug 8683
Acq: Clear button doesn't clear all item fields
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 8683: Clear button doesn't clear all item fields
PASSED-QA-Bug-8683-Clear-button-doesnt-clear-all-i.patch (text/plain), 2.92 KB, created by
Katrin Fischer
on 2013-11-19 22:20:14 UTC
(
hide
)
Description:
[PASSED QA] Bug 8683: Clear button doesn't clear all item fields
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2013-11-19 22:20:14 UTC
Size:
2.92 KB
patch
obsolete
>From 037eab52dac9cf7046fdffba8f84e5c534e734bb Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Wed, 13 Nov 2013 11:33:05 +0100 >Subject: [PATCH] [PASSED QA] Bug 8683: Clear button doesn't clear all item > fields > >The clear js function parses input text, but input filled to a plugin >does not contain the type attribute. > >Test plan: >- fill the barcode field to the barcode plugin >- go on the new order page >- verify the barcode plugin works as before >- verify the clear link clears the barcode field and all others fields. > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> >Works as expected, passes all tests and QA script. >Template change only. >Barcode and date acquired are now also cleared with the >'clear' link. > >But: it only works when you enter a barcode manually currently, >because the AutoBarcode functionality is broken on master (bug 11273). >--- > C4/Items.pm | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/C4/Items.pm b/C4/Items.pm >index 073d6f7..231e5c4 100644 >--- a/C4/Items.pm >+++ b/C4/Items.pm >@@ -2797,14 +2797,14 @@ sub PrepareItemrecordDisplay { > my $extended_param = plugin_parameters( $dbh, undef, $tagslib, $subfield_data{id}, undef ); > my ( $function_name, $javascript ) = plugin_javascript( $dbh, undef, $tagslib, $subfield_data{id}, undef ); > $subfield_data{random} = int(rand(1000000)); # why do we need 2 different randoms? >- $subfield_data{marc_value} = qq[<input tabindex="1" id="$subfield_data{id}" name="field_value" class="input_marceditor" size="67" maxlength="255" >+ $subfield_data{marc_value} = qq[<input type="text" tabindex="1" id="$subfield_data{id}" name="field_value" class="input_marceditor" size="67" maxlength="255" > onfocus="Focus$function_name($subfield_data{random}, '$subfield_data{id}');" > onblur=" Blur$function_name($subfield_data{random}, '$subfield_data{id}');" /> > <a href="#" class="buttonDot" onclick="Clic$function_name('$subfield_data{id}'); return false;" title="Tag Editor">...</a> > $javascript]; > } else { > warn "Plugin Failed: $plugin"; >- $subfield_data{marc_value} = qq(<input tabindex="1" id="$subfield_data{id}" name="field_value" class="input_marceditor" size="67" maxlength="255" />); # supply default input form >+ $subfield_data{marc_value} = qq(<input type="text" tabindex="1" id="$subfield_data{id}" name="field_value" class="input_marceditor" size="67" maxlength="255" />); # supply default input form > } > } > elsif ( $tag eq '' ) { # it's an hidden field >-- >1.8.3.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8683
:
22896
|
23004
| 23047