Bugzilla – Attachment 23339 Details for
Bug 11225
\n in translation strings should be removed
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 11225: \n in translation strings should be removed
Bug-11225-n-in-translation-strings-should-be-remov.patch (text/plain), 3.56 KB, created by
Kyle M Hall (khall)
on 2013-12-06 13:04:26 UTC
(
hide
)
Description:
Bug 11225: \n in translation strings should be removed
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2013-12-06 13:04:26 UTC
Size:
3.56 KB
patch
obsolete
>From 16066725c3c30e009b8c7b22e15d84e858f964a7 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Tue, 12 Nov 2013 15:31:56 +0100 >Subject: [PATCH] Bug 11225: \n in translation strings should be removed > >Some strings in the serials module contain linebreaks \n that cause >problems in translation. > >Test plan: >- Update your po file >- Verify that strings in serials/subscription-add.tt and > serials/subscription-numberpatterns.tt are present and don't contain > "\n" character. > >Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> >Template only change, passes all tests and QA script. >Updated po files now contain only the strings and no line breaks. > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >No regressions found. Passes koha-qa.pl and xt. >--- > .../prog/en/modules/serials/subscription-add.tt | 8 ++++---- > .../modules/serials/subscription-numberpatterns.tt | 6 +++--- > 2 files changed, 7 insertions(+), 7 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt >index 713b3b1..18f8962 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt >@@ -256,24 +256,24 @@ function testPredictionPattern() { > var error = 0; > var error_msg = ""; > if(frequencyid == undefined || frequencyid == ""){ >- error_msg += _("- Frequency is not defined\n"); >+ error_msg += _("- Frequency is not defined") + "\n"; > error ++; > } > acquidate = $("#acqui_date").val(); > if(acquidate == undefined || acquidate == ""){ >- error_msg += _("- First publication date is not defined\n"); >+ error_msg += _("- First publication date is not defined") + "\n"; > error ++; > } > [% IF (more_than_one_serial) %] > var nextacquidate = $("#nextacquidate").val(); > if(nextacquidate == undefined || nextacquidate == ""){ >- error_msg += _("- Next issue publication date is not defined\n"); >+ error_msg += _("- Next issue publication date is not defined") + "\n"; > error ++; > } > [% END %] > > if(error){ >- alert(_("Cannot test prediction pattern for the following reason(s):\n\n") >+ alert(_("Cannot test prediction pattern for the following reason(s):") + "\n\n" > + error_msg); > return false; > } >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-numberpatterns.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-numberpatterns.tt >index 686cdc8..953882f 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-numberpatterns.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-numberpatterns.tt >@@ -11,16 +11,16 @@ > var error = 0; > var error_msg = ""; > if(frequencyid == undefined || frequencyid == "") { >- error_msg += _("- Frequency is not defined\n"); >+ error_msg += _("- Frequency is not defined") + "\n"; > error ++; > } > if(firstacquidate == undefined || firstacquidate == "") { >- error_msg += _("- First publication date is not defined\n"); >+ error_msg += _("- First publication date is not defined") + "\n"; > error ++; > } > > if(error){ >- alert(_("Cannot test prediction pattern for the following reason(s):\n\n") >+ alert(_("Cannot test prediction pattern for the following reason(s):") + "\n\n" > + error_msg); > return false; > } >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 11225
:
22880
|
22934
|
23120
| 23339