Bugzilla – Attachment 23566 Details for
Bug 11166
branch filter in budgets admin uses pattern match instead of equals
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 11166 - branch filter in budgets admin uses pattern match instead of equals
Bug-11166---branch-filter-in-budgets-admin-uses-pa.patch (text/plain), 1.53 KB, created by
Marcel de Rooy
on 2013-12-16 09:41:28 UTC
(
hide
)
Description:
Bug 11166 - branch filter in budgets admin uses pattern match instead of equals
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2013-12-16 09:41:28 UTC
Size:
1.53 KB
patch
obsolete
>From 35d4c2d13adb35053105155f56be2c6049d2007a Mon Sep 17 00:00:00 2001 >From: Fridolyn SOMERS <fridolyn.somers@biblibre.com> >Date: Wed, 30 Oct 2013 10:28:49 +0100 >Subject: [PATCH] Bug 11166 - branch filter in budgets admin uses pattern > match instead of equals >Content-Type: text/plain; charset=utf-8 > >In budgets administration, admin/aqbudgets.pl, there is a combobox for filtering by branch code. >The bug is that the filter uses a pattern match instead of equals : > next unless $budget->{budget_branchcode} =~ m/$filter_budgetbranch/; >In this case, if there is a branch with code '1' and one with code '12', filtering by branch '1' will also show budgets of branch '12'. > >Test plan : >- Create a branch with code '1' and one with code '12' >- Create budgets in both branches >- Go to admin/aqbudgets.pl >- Filter by branch '12' >=> You see only budgets of this branch >- Filter by branch '1' >=> You see only budgets of this branch > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > admin/aqbudgets.pl | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > >diff --git a/admin/aqbudgets.pl b/admin/aqbudgets.pl >index 42a39f7..229606e 100755 >--- a/admin/aqbudgets.pl >+++ b/admin/aqbudgets.pl >@@ -296,7 +296,7 @@ if ($op eq 'add_form') { > || $budget->{budget_name} =~ m/$filter_budgetname/i; > } > if ($filter_budgetbranch ) { >- next unless $budget->{budget_branchcode} =~ m/$filter_budgetbranch/; >+ next unless $budget->{budget_branchcode} eq $filter_budgetbranch; > } > > ## TOTALS >-- >1.7.7.6
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 11166
:
22573
|
23566
|
23724