Bugzilla – Attachment 23680 Details for
Bug 10807
OPAC: There is no authority search history
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 10807: FIX UT t/db_dependent/Search_SearchHistory.t
Bug-10807-FIX-UT-tdbdependentSearchSearchHistoryt.patch (text/plain), 2.21 KB, created by
Jonathan Druart
on 2013-12-19 14:23:42 UTC
(
hide
)
Description:
Bug 10807: FIX UT t/db_dependent/Search_SearchHistory.t
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2013-12-19 14:23:42 UTC
Size:
2.21 KB
patch
obsolete
>From 2d1de3cbd981f4112ffefe078de56595687d7750 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Mon, 23 Sep 2013 13:39:07 +0200 >Subject: [PATCH] Bug 10807: FIX UT t/db_dependent/Search_SearchHistory.t > >Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> >--- > t/db_dependent/Search_SearchHistory.t | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) > >diff --git a/t/db_dependent/Search_SearchHistory.t b/t/db_dependent/Search_SearchHistory.t >index 936a4ca..5f21e3e 100644 >--- a/t/db_dependent/Search_SearchHistory.t >+++ b/t/db_dependent/Search_SearchHistory.t >@@ -21,7 +21,8 @@ use Modern::Perl; > use Test::More tests => 6; > > use C4::Context; >-use_ok('C4::Search', qw/AddSearchHistory PurgeSearchHistory/); # GetSearchHistory is not exported >+use_ok('C4::Search', qw/PurgeSearchHistory/); # GetSearchHistory is not exported >+use C4::Search::History; > > # Start transaction > my $dbh = C4::Context->dbh; >@@ -36,10 +37,10 @@ is(_get_history_count(), 0, 'starting off with nothing in search_history'); > # since the search_history table doesn't have an auto_increment > # column, it appears that the value of $dbh->last_insert_id() is > # useless for determining if the insert failed. >-AddSearchHistory(12345, 'session_1', 'query_desc_1', 'query_cgi_1', 5); >-AddSearchHistory(12345, 'session_1', 'query_desc_2', 'query_cgi_2', 6); >-AddSearchHistory(12345, 'session_1', 'query_desc_3', 'query_cgi_3', 7); >-AddSearchHistory(56789, 'session_2', 'query_desc_4', 'query_cgi_4', 8); >+C4::Search::History::add({userid => 12345, sessionid => 'session_1', query_desc => 'query_desc_1', query_cgi => 'query_cgi_1', total => 5}); >+C4::Search::History::add({userid => 12345, sessionid => 'session_1', query_desc => 'query_desc_2', query_cgi => 'query_cgi_3', total => 6}); >+C4::Search::History::add({userid => 12345, sessionid => 'session_1', query_desc => 'query_desc_3', query_cgi => 'query_cgi_3', total => 7}); >+C4::Search::History::add({userid => 56789, sessionid => 'session_2', query_desc => 'query_desc_4', query_cgi => 'query_cgi_4', total => 8}); > is(_get_history_count(), 4, 'successfully added four search_history rows'); > > # We're not testing GetSearchHistory at present because it is broken... >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10807
:
20734
|
20764
|
20951
|
20952
|
20988
|
20989
|
20990
|
21070
|
21362
|
21363
|
21403
|
22560
|
22561
|
22562
|
22563
|
22564
|
22565
|
23676
|
23677
|
23678
|
23679
|
23680
|
23681
|
23682
|
23712
|
24221
|
24222
|
24223
|
24224
|
24225
|
24226
|
27372
|
27373
|
27374
|
27375
|
27376
|
27377
|
27378