Attachment 23722 Details for Bug 11410 – Bug 11410 - Cataloging search finds no results for searches with ampersands

[patch] Bug 11410 - Cataloging search finds no results for searches with ampersands

Bug-11410---Cataloging-search-finds-no-results-for.patch (text/plain), 1.44 KB, created by Kyle M Hall (khall) on 2013-12-20 16:12:47 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2013-12-20 16:12:47 UTC

Size: 1.44 KB

patch

obsolete

>From cffd1c19e167d9ddac78a9d4922ec23a35a0a444 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Tue, 17 Dec 2013 16:04:10 -0500
>Subject: [PATCH] Bug 11410 - Cataloging search finds no results for searches with ampersands
>
>The cataloging search is passing the incorrect variable to SimpleSearch.
>I'm sure this is causing other issues, but the one I have identified is
>that any searches with an "&" in them return no results.
>
>Test Plan:
>1) Catalog a new record titled "Cats & Dogs"
>2) Rebuild your zebra index so this record is indexed
>3) Browse to cataloguing/addbooks.pl
>4) Search for "Cats & Dogs"
>5) Notice you get no results
>6) Apply this patch
>7) Repeat the search
>8) Notice your result now shows up!
>
>Signed-off-by: Heather Braum <hbraum@nekls.org>
>Signed-off-by: Suzanne Fayle <sfayle@roseman.edu>
>---
> cataloguing/addbooks.pl |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/cataloguing/addbooks.pl b/cataloguing/addbooks.pl
>index b22a646..35cfa2c 100755
>--- a/cataloguing/addbooks.pl
>+++ b/cataloguing/addbooks.pl
>@@ -82,7 +82,7 @@ if ($query) {
>     }
> 
>     # find results
>-    my ( $error, $marcresults, $total_hits ) = SimpleSearch($query, $results_per_page * ($page - 1), $results_per_page);
>+    my ( $error, $marcresults, $total_hits ) = SimpleSearch($builtquery, $results_per_page * ($page - 1), $results_per_page);
> 
>     if ( defined $error ) {
>         $template->param( error => $error );
>-- 
>1.7.2.5

Actions: View | Diff | Splinter Review

Attachments on bug 11410: 23614 | 23722 | 23742