Bugzilla – Attachment 23836 Details for
Bug 11208
Multi transport types: a sms message without sms number should be marked as failed
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 11208: If no smsalertnumber is defined, the message is marked as failed
Bug-11208-If-no-smsalertnumber-is-defined-the-mess.patch (text/plain), 1.29 KB, created by
Chris Cormack
on 2013-12-27 20:52:17 UTC
(
hide
)
Description:
Bug 11208: If no smsalertnumber is defined, the message is marked as failed
Filename:
MIME Type:
Creator:
Chris Cormack
Created:
2013-12-27 20:52:17 UTC
Size:
1.29 KB
patch
obsolete
>From 69ecfa00f357e0ce3d80200f6a56ace23a569aab Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Wed, 6 Nov 2013 14:54:36 +0100 >Subject: [PATCH] Bug 11208: If no smsalertnumber is defined, the message is > marked as failed > >For DUE message (and PREDUE, etc.) there are no check before sending the >message to the message_queue table. > >This check avoids to try to send again and again the same message. Now >it is marked as "failed". > >Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> >--- > C4/Letters.pm | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > >diff --git a/C4/Letters.pm b/C4/Letters.pm >index 7125148..c78d01e 100644 >--- a/C4/Letters.pm >+++ b/C4/Letters.pm >@@ -998,7 +998,12 @@ EOS > sub _send_message_by_sms { > my $message = shift or return; > my $member = C4::Members::GetMember( 'borrowernumber' => $message->{'borrowernumber'} ); >- return unless $member->{'smsalertnumber'}; >+ >+ unless ( $member->{smsalertnumber} ) { >+ _set_message_status( { message_id => $message->{'message_id'}, >+ status => 'failed' } ); >+ return; >+ } > > my $success = C4::SMS->send_sms( { destination => $member->{'smsalertnumber'}, > message => $message->{'content'}, >-- >1.8.5.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 11208
:
22751
|
23836
|
23841